[Bug 10326] New: bulkmarcimport.pl turns off CataloguingLog sys pref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10326 Bug ID: 10326 Summary: bulkmarcimport.pl turns off CataloguingLog sys pref Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt@gmail.com Reporter: januszop@gmail.com The bulkmarcimport.pl script does not correctly restore the CataloguingLog system preference. To reproduce: 1) have CataloguingLog set to Log; 2) import some batch of bibliographic records with bulkmarcimport.pl 3) check the state of CataloguingLog system preference -- it will be set to "Don't log". A patch will follow. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10326 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |januszop@gmail.com --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 18375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18375&action=edit Proposed patch The patch corrects the issue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10326 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10326 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18375|0 |1 is obsolete| | --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 18533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18533&action=edit Bug 10326: bulkmarcimport.pl doesn't restore value of CataloguingLog syspref To test: 0) Don't apply the patch yet. 1) Have the CataloguingLog system preference set to 'Log'. 2) Import a file of bibliographic records with bulkmarcimport.pl. 3) Check the state of CataloguingLog system preference -- it will be set to 'Don't log'. 4) Apply the patch. 5) Repeat steps 1-3. The CataloguingLog system preference will be 'Log'. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10326 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- sounds logical, marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10326 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10326 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18533|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18539&action=edit Bug 10326: bulkmarcimport.pl doesn't restore value of CataloguingLog syspref To test: 0) Don't apply the patch yet. 1) Have the CataloguingLog system preference set to 'Log'. 2) Import a file of bibliographic records with bulkmarcimport.pl. 3) Check the state of CataloguingLog system preference -- it will be set to 'Don't log'. 4) Apply the patch. 5) Repeat steps 1-3. The CataloguingLog system preference will be 'Log'. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10326 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Janusz! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10326 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.1. Thanks Janusz! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10326 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10326 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz --- Comment #8 from Chris Hall <chrish@catalyst.net.nz> --- pushed to 3.8.x, will be in 3.8.14 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org