https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #134 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #133)

(In reply to Jonathan Druart from comment #131)

...

(In reply to ByWaterSandboxes from comment #130)

...

It does not affect messages in the message_queue.

So it's not "all emails" :) I was going to fail QA this patch because I was testing overdue notices.

However it seems that is was the first intention of this patch (see first patch, in comment 3). Why did you change your mind?

Why do you think it would not affect overdue notices?

It changes Koha::Email create_message_headers which is used by: SendAlerts (emails sent directly) _send_message_by_emai (processes emails from the message_queue)

Actually I think it should cover all emails and if not, other emails not using Koha::Email would be a bug.

Maybe the commit message is wrong? (or I am)

Indeed, sounds like it would work. I cannot remember what I tested 3 months ago however. -- You are receiving this mail because: You are watching all bug changes.