[Bug 7846] New: get_batch_summary massive speedup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846 Priority: P5 - low Change sponsored?: --- Bug ID: 7846 Assignee: cnighswonger@foundations.edu Summary: get_batch_summary massive speedup QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: dpavlin@rot13.org Hardware: All Status: NEW Version: master Component: Label printing Product: Koha -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846 --- Comment #1 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 8686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8686&action=edit Bug 7846 - get_batch_summary massive speedup current code is using DISTINCT and another SQL query which can be replaced with GROUP BY for massive speedup. In our case, generating Manage Batches screen DBI time decreased from 24.762 s to 0.147 s Aside from correct usage of relational database, this change also cleans up code nicely. Test scenario: 1. open Manage Batches screen and take note of time needed to generate it 2. apply this patch 3. reload page and check page genration time -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|cnighswonger@foundations.ed |dpavlin@rot13.org |u | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 8739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8739&action=edit Bug 7864: Reintroduce list of subscribers to a serial alert message Adds a link to the existing template from the serial detail page: Patron alert with: RLIST (subscribers) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8739|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 8739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8739 Bug 7864: Reintroduce list of subscribers to a serial alert message Wrong bug -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 8742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8742&action=edit Bug 7846: Little changes to the display Changes the display of subscribers a bit. - Makes each name a link to the patron account instead of having a separate 'View' link behind each name - Show the title and subscrption number as link to the subscription detail page instead of just 'subscription' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8742|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 8742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8742 Bug 7846: Little changes to the display Wrong bug again, sorry. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7119 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846 --- Comment #6 from Dobrica Pavlinusic <dpavlin@rot13.org> --- I'm still hoping for signoff :-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|get_batch_summary massive |get_batch_summary |speedup |reimplements GROUP BY in | |perl code -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- If Katrin stops putting every other patch here I'll be able to sign off :) (Now I have to hide from Katrin). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8686|0 |1 is obsolete| | --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 9000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9000&action=edit Bug 7846 - get_batch_summary massive speedup current code is using DISTINCT and another SQL query which can be replaced with GROUP BY for massive speedup. In our case, generating Manage Batches screen DBI time decreased from 24.762 s to 0.147 s Aside from correct usage of relational database, this change also cleans up code nicely. Test scenario: 1. open Manage Batches screen and take note of time needed to generate it 2. apply this patch 3. reload page and check page genration time Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Works as advertised, with the advertised speed increase -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Ian Walls <koha.sekjal@gmail.com> --- Saves us from running numerous extra queries in a loop of indefinite size. Good catch! Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> --- yikes: on my sample database there is no patch at all and = * without the patch the page /cgi-bin/koha/patroncards/manage.pl?card_element=batch load smoothly * with the patch I get a nasty: Can't use string ("-1") as an ARRAY ref while "strict refs" in use at /home/paul/koha.dev/koha-community/C4/Creators/Lib.pm line 518. Failed QA sorry ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846 --- Comment #12 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Good catch. I missed semi-column ; which are embedded at end of query if there is filter parameter. Semi-columns are not needed, so I removed them. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9000|0 |1 is obsolete| | --- Comment #13 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 9174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9174&action=edit Bug 7846 - get_batch_summary massive speedup current code is using DISTINCT and another SQL query which can be replaced with GROUP BY for massive speedup. In our case, generating Manage Batches screen DBI time decreased from 24.762 s to 0.147 s Aside from correct usage of relational database, this change also cleans up code nicely. Test scenario: 1. open Manage Batches screen and take note of time needed to generate it 2. apply this patch 3. reload page and check page genration time -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9174|0 |1 is obsolete| | --- Comment #14 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 9175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9175&action=edit Bug 7846 - get_batch_summary massive speedup current code is using DISTINCT and another SQL query which can be replaced with GROUP BY for massive speedup. In our case, generating Manage Batches screen DBI time decreased from 24.762 s to 0.147 s Aside from correct usage of relational database, this change also cleans up code nicely. This change removed semi-columns from SQL query which broke Manage Patron batches. Test scenario: 1. open Manage Batches screen and take note of time needed to generate it 2. apply this patch 3. reload page and check page genration time -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9175|0 |1 is obsolete| | --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 9545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9545&action=edit Bug 7846 - get_batch_summary massive speedup current code is using DISTINCT and another SQL query which can be replaced with GROUP BY for massive speedup. In our case, generating Manage Batches screen DBI time decreased from 24.762 s to 0.147 s Aside from correct usage of relational database, this change also cleans up code nicely. This change removed semi-columns from SQL query which broke Manage Patron batches. Test scenario: 1. open Manage Batches screen and take note of time needed to generate it 2. apply this patch 3. reload page and check page genration time Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #16 from Ian Walls <koha.sekjal@gmail.com> --- Same content as the patch I Passed QA before, but now with the semi-colon issue fixed. Marking Passed once again. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|rel_3_8 |rel_3_10 --- Comment #17 from Paul Poulain <paul.poulain@biblibre.com> --- My test database does not have batches, so I can test, but I trust the author. Report any problem ! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org