[Bug 18674] New: Show timezone for Perl and MySQL on the About Koha page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 Bug ID: 18674 Summary: Show timezone for Perl and MySQL on the About Koha page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: nengard@gmail.com Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org With the pushing of Bug 18299, we no longer have a quick way of checking the timezone of the Perl and MySQL connection. We should add some code to the About Koha page to show this info. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18299 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20123 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 72214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72214&action=edit Bug 18674: Added timezone information to about page Before patch: No timezone section After patch: timezone section at bottom of Server information tab. Actual is what is being used. Config overrides environment variables. So if there is confusion why the environment variables aren't working, it will be visible why. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20123 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- It should be noted that I had to tweak 20123 to get it to a usable state for this, so sign off can't happen immediately. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72214|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73533&action=edit Bug 18674: Added timezone information to about page Before patch: No timezone section After patch: timezone section at bottom of Server information tab. Actual is what is being used. Config overrides environment variables. So if there is confusion why the environment variables aren't working, it will be visible why. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73534&action=edit Bug 18674: Follow up on missing TZ SetEnv for plack It should also be noted that /etc/apache2/sites-enabled/{configuration file} should also contain: RequestHeader add X-Koha-SetEnv "TZ {timezone}" Where {timezone} is the desired instance timezone. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73533|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 73700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73700&action=edit Bug 18674: Added timezone information to about page Before patch: No timezone section After patch: timezone section at bottom of Server information tab. Actual is what is being used. Config overrides environment variables. So if there is confusion why the environment variables aren't working, it will be visible why. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73534|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 73701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73701&action=edit Bug 18674: Follow up on missing TZ SetEnv for plack It should also be noted that /etc/apache2/sites-enabled/{configuration file} should also contain: RequestHeader add X-Koha-SetEnv "TZ {timezone}" Where {timezone} is the desired instance timezone. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 73702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73702&action=edit Bug 18674: Style changes to match other entries Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20123 | Assignee|nengard@gmail.com |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 73720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73720&action=edit Bug 18674: TZ error handling This patch adds C4::Context->timezone bad timezone handling. The calculated 'effective' timezone is tested with the right tool and a fallback to 'local' is added. A warning is printed in the logs. A test for this is added to about.pl too, along with the right warning messages in case of problems. Tests are added for both invalid TZ and to make sure the warning is raised. To test: - Apply the patch - Run: $ kshell k$ prove t/timezones.t => SUCCESS: All tests pass Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Use of uninitialized value $config_timezone in string ne at /home/vagrant/kohaclone/about.pl line 71. Use of uninitialized value $config_timezone in string eq at /home/vagrant/kohaclone/about.pl line 76. Use of uninitialized value $env_timezone in string ne at /home/vagrant/kohaclone/about.pl line 76. Also, should not we display the date and time, could be a relevant information (especially when tz=local). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 74024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74024&action=edit Bug 18674: (QA follow-up) Add date and time This patch adds current date and time, formatted as configured. It makes the timezone name be displayed the system uses it (important for the 'local' use case). It removes some warnings too. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74024|0 |1 is obsolete| | --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 74026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74026&action=edit Bug 18674: (QA follow-up) Add date and time This patch adds current date and time, formatted as configured. It makes the timezone name be displayed the system uses it (important for the 'local' use case). It removes some warnings too. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74026|0 |1 is obsolete| | --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 74036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74036&action=edit Bug 18674: (QA follow-up) Add date and time This patch adds current date and time, formatted as configured. It makes the timezone name be displayed the system uses it (important for the 'local' use case). It removes some warnings too. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It would be good to write something about this new entry on the wiki. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 Bug 18674 depends on bug 20123, which changed state. Bug 20123 Summary: Allow multiple instances of Koha to have different timezones on the same server https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Enhancement on feature, not backported for 17.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 --- Comment #16 from David Cook <dcook@prosentient.com.au> --- It's a shame this isn't backported to at least 17.05, since 17.05 and 17.11 don't have an easy way of verifying TZ settings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to David Cook from comment #16)
It's a shame this isn't backported to at least 17.05, since 17.05 and 17.11 don't have an easy way of verifying TZ settings.
This one needs some work to be suitable for the old stable releases. You better talk to the release maintainers. If you need it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 --- Comment #18 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #17)
(In reply to David Cook from comment #16)
It's a shame this isn't backported to at least 17.05, since 17.05 and 17.11 don't have an easy way of verifying TZ settings.
This one needs some work to be suitable for the old stable releases. You better talk to the release maintainers. If you need it.
In that case, I'd say reverting https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299 for 17.05 and 17.11 might be a better idea. I ended up just copying admin/env_tz_test.pl from an older version of Koha and ran that instead for the setup of the timezone and then deleted it again. I imagine anyone who needs to check for 17.05 and 17.11 would just do the same thing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25617 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617 [Bug 25617] Error on about page when TimeFormat preference is set to 12hr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25617 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617 [Bug 25617] Error on about page when TimeFormat preference is set to 12hr -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org