[Bug 33794] New: Holds Queue builder skips least cost branch unless target item's homebranch is patron's homebranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 Bug ID: 33794 Summary: Holds Queue builder skips least cost branch unless target item's homebranch is patron's homebranch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The line next if $request->{borrowerbranch} ne $item->{homebranch}; has been in the holds queue builder since the very beginning, with no explanation. My justification for this line is that we would prefer to send an item to a patron whose home library is the same is the item's home library, assuming that patron will return the item at that library, thus reducing transportation costs. I will not argue here if this is a good feature or not. Bug 31557 makes in configurable, but perhaps it should have an 'off' feature as well. This feature does not make sense when using the transport cost matrix. We get the lowest cost branch, and then if the branches don't match we just move on the the "fall back to basics code". This line should be removed from the code section dealing with the transport cost matrix. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33795 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33795 [Bug 33795] Holds Queue builder should do cheap checks before expensive checks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 151712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151712&action=edit Bug 33794: Removing line that causes TCM to pick the most expensive item if it means that it's going back to it's home branch. Test Plan: 1. Enable the UseTransportCostMatrix system preference 2. Ensure that there are at least three test libraries set up (Library A, Library B, Library C) 3. Set up the TCM so that it is cheaper to transport an item from Library A to Library C rather than from Library B to Library C. 4. Choose or create a biblio that has three items. 1. Item 1: 1. Set home library to Library C and the holding library to Library B — cost is more expensive 2. Item 2: 1. Set home library to Library A and the holding library is Library A - cost is least expensive (The TCM should be choosing this item) 3. Item 3: 1. Set home library to Library C and holding library to Library C, but check this item out to another patron so that it is unavailable. - Just a control variable. 5. Choose or create a patron that has their holds pickup library set to Library C. Place a hold on the biblio above for them. 6. Build the holds queue 7. The holds queue shows that Item 1 (most expensive) is being chosen over Item 2 (least expensive) 8. Delete the hold and apply the patch 9. Restart the services 10. Repeat step 5 11. Run the holds queue — it is now showing that Item 2 (least expensive) is being chosen over Item 1 (most expensive) 12. Sign off! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151712|0 |1 is obsolete| | --- Comment #2 from Sam Lau <samalau@gmail.com> --- Created attachment 151987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151987&action=edit Bug 33794: Removing line that causes TCM to pick the most expensive item if it means that it's going back to it's home branch. Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Processing additional checks * Author 'John Doe' seems invalid * Email's author 'you@example.com' seems invalid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Please add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 156105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156105&action=edit Bug 33794: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156105|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 156115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156115&action=edit Bug 33794: Move relevent code to it's own subroutine -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156115|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 156117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156117&action=edit Bug 33794: Move relevent code to it's own subroutine -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 156118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156118&action=edit WIP Bug 33794: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35431, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35432 CC| |nick@bywatersolutions.com Status|ASSIGNED |In Discussion --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- See bug 35431 and bug 35432 - this seems to be the same misunderstanding I encountered. The initial check of the TCM is actually part of HoldsQueuePrioritize branch. Later in the code we use the holdingbranch variable that was set here to try and fill holds with the least cost. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catrina@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson@kreablo.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|In Discussion |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org