[Bug 26591] New: Add a choice to prevent the checkout or warn the user at the selfcheckout system if we use CheckPrevCheckout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Bug ID: 26591 Summary: Add a choice to prevent the checkout or warn the user at the selfcheckout system if we use CheckPrevCheckout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: koha@univ-lyon3.fr QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com Since BZ19457, the checkout is allowed at the selfcheckout system if if we use the system preference CheckPrevCheckout. It can be useful for some libraries but not for the others. For example, in my libray, we want to prevent users who are using the selfcheckout system to checkout an item they have just check-in. They didn't really matter the warning and they can keep a book for all the time. For some title, there's a real pressure becaus they are recommanded by the teachers and we can't have one for all the students. The behaviour should be configurable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Koha Team University Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19457 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19457 | Depends on| |19457 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457 [Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 --- Comment #1 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 112975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112975&action=edit Bug 26591: SIP option prevcheckout_block_checkout to block checkout of previously checked-out documents This patchs adds a new SIP option to block checkout of previously checked-out documents: prevcheckout_block_checkout See the CheckPrevCheckout system preference to enable previously checked-out verification in Koha. Test plan: 1) Apply this patch 2) Prove t/db_dependent/SIP/Message.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger@biblibr | |e.com Assignee|koha-bugs@lists.koha-commun |matthias.meusburger@biblibr |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112975|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 112986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112986&action=edit Bug 26591: SIP option prevcheckout_block_checkout to block checkout of previously checked-out documents This patchs adds a new SIP option to block checkout of previously checked-out documents: prevcheckout_block_checkout See the CheckPrevCheckout system preference to enable previously checked-out verification in Koha. Test plan: 1) Apply this patch 2) Prove t/db_dependent/SIP/Message.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Matthias, please provide a complete test plan. Prove is not enough here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 --- Comment #4 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Sure thing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112986|0 |1 is obsolete| | --- Comment #5 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 112991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112991&action=edit Bug 26591: SIP option prevcheckout_block_checkout to block checkout of previously checked-out documents This patchs adds a new SIP option to block checkout of previously checked-out documents: prevcheckout_block_checkout See the CheckPrevCheckout system preference to enable previously checked-out verification in Koha. Test plan: 1) Apply this patch 2) Enable the CheckPrevCheckout syspref (on "Do" for instance) 3) Enable prevcheckout_block_checkout in the SIP server config file 4) Checkout and checkin an item for a user 5) Checkout the item again with the SIP CLI tool 6) Check that the SIP message is "This item was previously checked out by you" and that the item was not checked out 7) Disable prevcheckout_block_checkout in the SIP server config file 8) Checkout the item again with the SIP CLI tool 9) Check that the SIP message is "This item was previously checked out by you" and that the item was checked out. 10) Prove t/db_dependent/SIP/Message.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- If I understand correctly, this SIP setting goes further than the corresponding system preference. My question is here: Should this be something only "hidden deeper" in the SIP config file, or should it actually be a system preference and have the same effect in the staff client ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au, | |katrin.fischer@bsz-bw.de, | |liz@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Adding a few users from bug 19457 for comment6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 --- Comment #8 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- (In reply to Marcel de Rooy from comment #6)
If I understand correctly, this SIP setting goes further than the corresponding system preference. My question is here: Should this be something only "hidden deeper" in the SIP config file, or should it actually be a system preference and have the same effect in the staff client ?
One answer to this question can be the same that Kyle made here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541#c4 "The problem with a syspref though is that the behavior cannot be changed on a per-account basis. It very well may be that such behavior is desired for a self check machine for example, but not for an AMH." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a choice to prevent the |Add a choice to prevent the |checkout or warn the user |checkout or warn the user |at the selfcheckout system |if CheckPrevCheckout is |if we use CheckPrevCheckout |used via SIP2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112991|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117210&action=edit Bug 26591: SIP option prevcheckout_block_checkout to block checkout of previously checked-out documents This patchs adds a new SIP option to block checkout of previously checked-out documents: prevcheckout_block_checkout See the CheckPrevCheckout system preference to enable previously checked-out verification in Koha. Test plan: 1) Apply this patch 2) Enable the CheckPrevCheckout syspref (on "Do" for instance) 3) Enable prevcheckout_block_checkout in the SIP server config file 4) Checkout and checkin an item for a user 5) Checkout the item again with the SIP CLI tool 6) Check that the SIP message is "This item was previously checked out by you" and that the item was not checked out 7) Disable prevcheckout_block_checkout in the SIP server config file 8) Checkout the item again with the SIP CLI tool 9) Check that the SIP message is "This item was previously checked out by you" and that the item was checked out. 10) Prove t/db_dependent/SIP/Message.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117210|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117211&action=edit Bug 26591: SIP option prevcheckout_block_checkout to block checkout of previously checked-out documents This patchs adds a new SIP option to block checkout of previously checked-out documents: prevcheckout_block_checkout See the CheckPrevCheckout system preference to enable previously checked-out verification in Koha. Test plan: 1) Apply this patch 2) Enable the CheckPrevCheckout syspref (on "Do" for instance) 3) Enable prevcheckout_block_checkout in the SIP server config file 4) Checkout and checkin an item for a user 5) Checkout the item again with the SIP CLI tool 6) Check that the SIP message is "This item was previously checked out by you" and that the item was not checked out 7) Disable prevcheckout_block_checkout in the SIP server config file 8) Checkout the item again with the SIP CLI tool 9) Check that the SIP message is "This item was previously checked out by you" and that the item was checked out. 10) Prove t/db_dependent/SIP/Message.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This patch follows the same logic as bug 25541 and allows override of the CheckPrevIssue at the sip account level. Tested and working as expected with new unit tests passing. I've added the new option to the Wiki page as required (https://wiki.koha-community.org/wiki/SIP2_configuration) and fixed a tab character that was failing the QA script. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Some libraries would like release notes| |patrons to be able to check | |out items with prior | |checkouts via SIP even if | |the CheckPrevIssue | |preference is enabled. | | | |This feature is enabled by | |adding the flag | |previssue_block_checkout to | |an account in the SIP | |configuration file, and | |setting the value of it to | |"0". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Some libraries would like |Some libraries would like release notes|patrons to be able to check |patrons to be able to check |out items with prior |out items with prior |checkouts via SIP even if |checkouts via SIP even if |the CheckPrevIssue |the CheckPrevIssue |preference is enabled. |preference is enabled. | | |This feature is enabled by |This feature is enabled by |adding the flag |adding the flag |previssue_block_checkout to |prevcheckout_block_checkout |an account in the SIP |to an account in the SIP |configuration file, and |configuration file, and |setting the value of it to |setting the value of it to |"0". |"0". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Small useful enhancement, I choose to backport. Pushed to 20.11.x for 20.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26937 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |andrew@bywatersolutions.com Resolution|--- |FIXED --- Comment #14 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Enhancement, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Juliet Heltibridle <jheltibridle@rcplib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jheltibridle@rcplib.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org