[Bug 27815] New: "Remove" in point of sale untranslatable
Debit types 5- Install at least one other language in your staff interface and switch to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27815 Bug ID: 27815 Summary: "Remove" in point of sale untranslatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Created attachment 117396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117396&action=edit Screenshot of POS "This sale" in fr-CA The "Remove" button in "This sale" in the point of sale is untranslatable. To reproduce: 1- Enable EnablePointOfSale syspref 2- Enable UseCashRegisters syspref 3- Set up at least one cash register in Administration > Cash registers 4- Set up at least on Debit type that can be sold through POS in Administration that language 6- Go to Point of sale and click Add next to one item for purchase 7- Notice on the right hand side where the purchased item is added, the Removed button is still in English I checked po/fr-CA-staff-prog.po, po/fr-CA-messages.po and po/fr-CA-messages-js.po and none of them have a "Remove" string in pay.tt. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27815 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27815 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 117444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117444&action=edit Bug 27815: "Remove" in point of sale untranslatable This patch modifies the Point of Sale template so that the "Remove" button can be translated. The string in the JavaScript block wasn't wrapped in the correct function. To test, apply the patch and test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation:
cd misc/translator perl translate update fr-FR
- Open the corresponding .po file for the strings pulled from the template: e.g. misc/translator/po/fr-FR-staff-prog.po - Locate strings pulled from pos/pay.tt for translation to confirm the update, e.g.: #: koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt:189 #, c-format msgid "Remove" msgstr "Enlever" - Install the updated translation:
perl translate install fr-FR
- In the staff client, go to Point of Sale. - Switch to the French translation and click the "Ajouter" button next to one of the items for purchase. - In the "This sale" table, the item you added should have a corresponding "Enlever" button. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27815 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27815 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117444|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 117553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117553&action=edit Bug 27815: "Remove" in point of sale untranslatable This patch modifies the Point of Sale template so that the "Remove" button can be translated. The string in the JavaScript block wasn't wrapped in the correct function. To test, apply the patch and test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation:
cd misc/translator perl translate update fr-FR
- Open the corresponding .po file for the strings pulled from the template: e.g. misc/translator/po/fr-FR-staff-prog.po - Locate strings pulled from pos/pay.tt for translation to confirm the update, e.g.: #: koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt:189 #, c-format msgid "Remove" msgstr "Enlever" - Install the updated translation:
perl translate install fr-FR
- In the staff client, go to Point of Sale. - Switch to the French translation and click the "Ajouter" button next to one of the items for purchase. - In the "This sale" table, the item you added should have a corresponding "Enlever" button. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27815 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27815 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27815 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117553|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117734&action=edit Bug 27815: "Remove" in point of sale untranslatable This patch modifies the Point of Sale template so that the "Remove" button can be translated. The string in the JavaScript block wasn't wrapped in the correct function. To test, apply the patch and test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation:
cd misc/translator perl translate update fr-FR
- Open the corresponding .po file for the strings pulled from the template: e.g. misc/translator/po/fr-FR-staff-prog.po - Locate strings pulled from pos/pay.tt for translation to confirm the update, e.g.: #: koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt:189 #, c-format msgid "Remove" msgstr "Enlever" - Install the updated translation:
perl translate install fr-FR
- In the staff client, go to Point of Sale. - Switch to the French translation and click the "Ajouter" button next to one of the items for purchase. - In the "This sale" table, the item you added should have a corresponding "Enlever" button. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27815 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27815 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27815 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27815 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.04 released in| | --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27815 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.05.00,20.11.04 |21.05.00,20.11.04,20.05.10 released in| | CC| |andrew@bywatersolutions.com --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27815 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org