[Bug 13506] New: Sip/Configuration/*.pm classes are unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13506 Bug ID: 13506 Summary: Sip/Configuration/*.pm classes are unused Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campbell@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com The classes Sip::Configuration::Account, Sip::Configuration::Institution and Sip::Configuration::Service are not actually used. Sip::Configuration calls new on all three but does not save the returned objects. Access to accounts, institutions and services is always to the hashref stored in the Configuration object not to objects of these classes. The Config code should be cleaned up by removing these Classes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13506 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 34858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34858&action=edit Proposed patch Removes the unused classes, remove the useless calls to their new methods. Took advantage to remove other obsolete code from configuration Simple Test plan: Select a repeatable series of sip transactions (e.g. an issue and discharge) run before applying patch to confirm all ok, run after applying patch and server should behave identically -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13506 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13506 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34858|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35943&action=edit Bug 13506: Remove unused Sip/Configuration Classes Sip::Configuration calls new on Account, Institution and Service classes but does not store or subsequently use the returned objects ( which immediately go out of scope ). Their existence just obscures the code and misleads the reader. Remobe them Removed redundant commented out code from Configyration module which was not serving any useful purpose Ran Configuration.pm through perltidy to make layout more consistent Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13506 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- There is 1 occurrence of Sip::Configuration::Institution left in C4/SIP/ILS.pod. Maybe should it be removed? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13506 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13506 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35943|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36083&action=edit [PASSED QA] Bug 13506: Remove unused Sip/Configuration Classes Sip::Configuration calls new on Account, Institution and Service classes but does not store or subsequently use the returned objects ( which immediately go out of scope ). Their existence just obscures the code and misleads the reader. Remobe them Removed redundant commented out code from Configyration module which was not serving any useful purpose Ran Configuration.pm through perltidy to make layout more consistent Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13506 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36084&action=edit Bug 13506 [QA Follouwp] - Fix POD -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13506 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Colin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13506 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14644 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 [Bug 14644] SIP2 terminal authentication via telnet transport broken -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org