[Bug 18264] New: Course reserves - use itemnumber for editing existing reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 Bug ID: 18264 Summary: Course reserves - use itemnumber for editing existing reserve items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Course reserves Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Some libraries have found that when using course reserves an item will have the barcode removed. If this happens the edit links break. We should use the itemnumber for links. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 61067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61067&action=edit Bug 18264 - Course reserves - use itemnumber for editing existing reserve items This patch alters the crouse reserves module to use itemnumber as the lookup method for existing reserves as opposed to barcode To test: 1 - Apply patch 2 - Add some items to a course reserves - all should work as expected 3 - Delete the barcode for an item on reserve 4 - Note the edit link still resolves to the correct item -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61067|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 61095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61095&action=edit Bug 18264 - Course reserves - use itemnumber for editing existing reserve items This patch alters the crouse reserves module to use itemnumber as the lookup method for existing reserves as opposed to barcode To test: 1 - Apply patch 2 - Add some items to a course reserves - all should work as expected 3 - Delete the barcode for an item on reserve 4 - Note the edit link still resolves to the correct item Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I do not understand the goal of this patch, why do barcodes are removed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #3)
I do not understand the goal of this patch, why do barcodes are removed?
Some workflows at libraries cause this, I think electronic items or copies may only be assigned temporary barcodes and deleted when the items are not in use - in these cases things can no longer be edited in the reserves. While having barcodes is expected for adding items to course reserves currently I think this change opens up more possibilities and doesn't hurt anything and solves a potential issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 61095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61095 Bug 18264 - Course reserves - use itemnumber for editing existing reserve items Review of attachment 61095: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18264&attachment=61095) ----------------------------------------------------------------- ::: course_reserves/add_items.pl @@ +39,2 @@
+my $item = GetBiblioFromItemNumber( $itemnumber, $barcode );
This is wrong, this subroutine uses only one parameter (also see bug 18276). @@ +50,4 @@
flagsrequired => { coursereserves => 'add_reserves' }, } ); +my $inumber = $itemnumber ? "<blank> (itemnumber:$itemnumber)" : "";
hum? <blank>? @@ +51,5 @@
} ); +my $inumber = $itemnumber ? "<blank> (itemnumber:$itemnumber)" : ""; +$template->param( ERROR_BARCODE_NOT_FOUND => $barcode . $inumber ) + unless ( $barcode && !$itemnumber && $item && $action eq 'lookup' );
How do we reach that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 61272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61272&action=edit Bug 18264 - (QA Followup) Remove use of GetBiblioFromItemNumber Replace <blank> with (blank) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #5)
+my $item = GetBiblioFromItemNumber( $itemnumber, $barcode ); This is wrong, this subroutine uses only one parameter (also see bug 18276). Removed
hum? <blank>? In case of itemnumber lookup (no barcode) we display '(blank)' for barcode and itemnumber after
How do we reach that? As above case - it shouldn't happen, but makes for a nice error if someone messes up the link example with bad itemnumber: http://localhost:8081/cgi-bin/koha/course_reserves/add_items.pl?course_id=11&itemnumber=123456789123456798&action=lookup&return=11
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61272|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 61299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61299&action=edit Bug 18264 - (QA Followup) Remove use of GetBiblioFromItemNumber Replace <blank> with (blank) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61095|0 |1 is obsolete| | Attachment #61299|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61304&action=edit Bug 18264 - Course reserves - use itemnumber for editing existing reserve items This patch alters the crouse reserves module to use itemnumber as the lookup method for existing reserves as opposed to barcode To test: 1 - Apply patch 2 - Add some items to a course reserves - all should work as expected 3 - Delete the barcode for an item on reserve 4 - Note the edit link still resolves to the correct item Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61305&action=edit Bug 18264 - (QA Followup) Remove use of GetBiblioFromItemNumber Replace <blank> with (blank) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, blank is not translatable? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #12 from Brendan Gallagher <brendan@bywatersolutions.com> --- https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Touches some strings, will take a look at this for the next 16.11.x release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18367 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18367 [Bug 18367] Fix untranslatable string from Bug 18264 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've filed bug 18367 about the string. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, a little torn about pushing this one. Opinions? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- The 'bug' part is reproducible on 16.11, I filed as a bug because it can cause issues in those limited cases where barcodes are removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tried to backport these patches, but with the patches applied, I have an error under Plack when adding an item to a course by barcode: The method biblio is not covered by tests! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17974 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #17)
Tried to backport these patches, but with the patches applied, I have an error under Plack when adding an item to a course by barcode: The method biblio is not covered by tests!
Koha::Item->biblio is added by bug 17974. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17974 [Bug 17974] Add the Koha::Item->biblio method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 Bug 18264 depends on bug 17974, which changed state. Bug 17974 Summary: Add the Koha::Item->biblio method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17974 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18264 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These patches have been pushed to 16.11.x and will be in 16.11.09. Thx for the hint, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org