[Bug 34911] New: Test suite no longer run test critic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34911 Bug ID: 34911 Summary: Test suite no longer run test critic Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Test Suite Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 32352, 34303 Since bug 34303 the test suite (when ran on jenkins) is no longer testing Perl::Critic koha_1 | fatal: Not a valid object name master koha_1 | [14:58:14] t/00-testcritic.t check_makefile.t is also failing: koha_1 | fatal: Not a valid object name master koha_1 | [15:00:01] xt/check_makefile.t We are not cloning the whole repo and "master" is not available. Additionally we do not want to test master's files on stable branches anyway... Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 [Bug 32352] xt/check_makefile.t failing on node_modules https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34303 [Bug 34303] t/00-testcritic.t should only test files part of git repo -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34911 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34911 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156199&action=edit Bug 34911: Test files from HEAD instead of 'master' Since bug 34303 the test suite (when ran on jenkins) is no longer testing Perl::Critic koha_1 | fatal: Not a valid object name master koha_1 | [14:58:14] t/00-testcritic.t We are not cloning the whole repo and "master" is not available. Additionally we do not want to test master's files on stable branches anyway... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34911 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Note that this may not be enough, we have other warnings/errors: koha_1 | error: object directory /srv/jenkins/workspace/Koha_Source/.git/objects does not exist; check .git/objects/info/alternates koha_1 | [15:00:20] t/Makefile.t Which is using HEAD. But in my test it was working. On Docker_8: /srv/jenkins/workspace/Koha_Master# perl t/Makefile.t 1..1 ok 1 - All directories should be mapped -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34911 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34911 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156199|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156213&action=edit Bug 34911: Test files from HEAD instead of 'master' Since bug 34303 the test suite (when ran on jenkins) is no longer testing Perl::Critic koha_1 | fatal: Not a valid object name master koha_1 | [14:58:14] t/00-testcritic.t We are not cloning the whole repo and "master" is not available. Additionally we do not want to test master's files on stable branches anyway... Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34911 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Status|Signed Off |Passed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Trivial: SO + QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34911 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34911 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34911 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.05 Good catch ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.05 |23.11.00,23.05.05,22.11.11 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34911 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org