[Bug 28233] New: Backport removal of excess opaccredits div
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28233 Bug ID: 28233 Summary: Backport removal of excess opaccredits div Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org This is for a backport to 20.05, as it was fixed in 20.11, but bug 20168 was too grand to back port to 20.05. Put something in the opaccredits news item, and opaccredits outputs 2 divs, because one is in the the template, and one is in the TT function that puts out the opaccredits news block. Test Plan --------- 1. Do a search 2. Look at opac details for any result. 3. View page source 4. Find opaccredits 5. See two opaccredits divs 6. Apply patch 7. Repeat steps 1-4 8. hope that memcached or something else does not makes it appear, but you should not see two opaccredits divs. 9. sign off. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28233 Mark Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |mtompset@hotmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28233 Mark Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28233 --- Comment #1 from Mark Tompsett <mtompset@hotmail.com> --- Created attachment 120189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120189&action=edit Bug 28233: Backport removal of excess opaccredits div This is for a backport to 20.05, as it was fixed in 20.11, but bug 20168 was too grand to back port to 20.05. Put something in the opaccredits news item, and opaccredits outputs 2 divs, because one is in the the template, and one is in the TT function that puts out the opaccredits news block. Test Plan --------- 1. Do a search 2. Look at opac details for any result. 3. View page source 4. Find opaccredits 5. See two opaccredits divs 6. Apply patch 7. Repeat steps 1-4 8. hope that memcached or something else does not makes it appear, but you should not see two opaccredits divs. 9. sign off. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28233 Mark Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |andrew@bywatersolutions.com | |, | |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28233 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28233 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120189|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 120208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120208&action=edit Bug 28233: Backport removal of excess opaccredits div Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28233 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28233 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28233 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120208|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120706&action=edit Bug 28233: Backport removal of excess opaccredits div Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28233 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to stable CC| |jonathan.druart+koha@gmail. | |com --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Sending to 20.05 queue. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org