[Bug 16944] New: Add "email" and "url" classes when edit or create a vendor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16944 Bug ID: 16944 Summary: Add "email" and "url" classes when edit or create a vendor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: hector.hecaxmmx@gmail.com Reporter: hector.hecaxmmx@gmail.com QA Contact: testopia@bugs.koha-community.org When edit or create a new vendor the two fields email and website don't test if the data provided is right. When you add and direction like "koha-community.org" without the protocol "https" the program redirect to an 404 error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16944 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16944 --- Comment #1 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 53501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53501&action=edit Bug 16944: Add "email" and "url" classes when edit or create a vendor When edit or create a new vendor the two fields "email" and "website" don't test if the data provided is right. When you add a direction like "koha-community.org" without the protocol "https" the program redirect to an 404 error. To reproduce the issue: 1-Go to Acquisition and create a new Vendor 2-Fill the field Website with koha-community.org 3-Use an email without at sing (@) 4-Notice that there is no error 5-Save 6-Go to the vendor created (/cgi-bin/koha/acqui/supplier.pl?booksellerid=1) 7-Click in Website: koha-community.org -> redirect to an 404 error 8-Notice the bad mailto: To test: -Apply patch -Reproduce step 1 to 8 with the same vendor or create a new one -Enter multiple wrong and valid urls -Enter urls with and without protocols http, https, ftp -Enter wrong and valid emails NOTE: The classes used are taken from 'branches.tt' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16944 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org, | |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16944 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16944 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53501|0 |1 is obsolete| | --- Comment #2 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 53504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53504&action=edit [SIGNED-OFF] Bug 16944: Add "email" and "url" classes when edit or create a vendor When edit or create a new vendor the two fields "email" and "website" don't test if the data provided is right. When you add a direction like "koha-community.org" without the protocol "https" the program redirect to an 404 error. To reproduce the issue: 1-Go to Acquisition and create a new Vendor 2-Fill the field Website with koha-community.org 3-Use an email without at sing (@) 4-Notice that there is no error 5-Save 6-Go to the vendor created (/cgi-bin/koha/acqui/supplier.pl?booksellerid=1) 7-Click in Website: koha-community.org -> redirect to an 404 error 8-Notice the bad mailto: To test: -Apply patch -Reproduce step 1 to 8 with the same vendor or create a new one -Enter multiple wrong and valid urls -Enter urls with and without protocols http, https, ftp -Enter wrong and valid emails NOTE: The classes used are taken from 'branches.tt' Signed-off-by: Liz Rea <liz@catalyst.net.nz> no longer allows entering of improper website urls or incomplete email addresses. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16944 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16944 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53504|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53683&action=edit Bug 16944: Add "email" and "url" classes when edit or create a vendor When edit or create a new vendor the two fields "email" and "website" don't test if the data provided is right. When you add a direction like "koha-community.org" without the protocol "https" the program redirect to an 404 error. To reproduce the issue: 1-Go to Acquisition and create a new Vendor 2-Fill the field Website with koha-community.org 3-Use an email without at sing (@) 4-Notice that there is no error 5-Save 6-Go to the vendor created (/cgi-bin/koha/acqui/supplier.pl?booksellerid=1) 7-Click in Website: koha-community.org -> redirect to an 404 error 8-Notice the bad mailto: To test: -Apply patch -Reproduce step 1 to 8 with the same vendor or create a new one -Enter multiple wrong and valid urls -Enter urls with and without protocols http, https, ftp -Enter wrong and valid emails NOTE: The classes used are taken from 'branches.tt' Signed-off-by: Liz Rea <liz@catalyst.net.nz> no longer allows entering of improper website urls or incomplete email addresses. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16944 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Hector! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16944 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.03. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16944 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x, will be in 3.22.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org