[Bug 16747] New: Patron card creator broken with version 16.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16747 Bug ID: 16747 Summary: Patron card creator broken with version 16.05 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger@foundations.edu Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org Patron card creator does no longer work with patron card definitions that worked with version 3.22. It seems to be related with - Move the patron images related code to Koha::Patron::Images Symptom: create-pdf.pl: Illegal division by zero at /usr/share/kohaclone/patroncards/create-pdf.pl line 200 This is due to the fact that $image_data is not filled properly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16747 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15711 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16747 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15635 --- Comment #1 from Marc Véron <veron@veron.ch> --- Bug seems to be related to Bug 15635 - Move the patron images related code to Koha::Patron::Images Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 [Bug 15635] Move the patron images related code to Koha::Patron::Images -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16747 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16747 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger@foundations.ed |veron@veron.ch |u | Status|NEW |ASSIGNED --- Comment #2 from Marc Véron <veron@veron.ch> --- Found, patch follows. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16747 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 52454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52454&action=edit Bug 16747 - Patron card creator broken with version 16.05 To reproduce: - Prepare a patron car layout with Image 1 using Patron Image - Create a patron card for a patron without patron image Result: OK, PDF can be opened wit PDF viewer - Try to create a patron card with a patron who has a patron image Result: The PDF file is corrupt (contains text only with error message) intranet error log contains: create-pdf.pl: Illegal division by zero at /usr/share/kohaclone/patroncards/create-pdf.pl line 200 To test: - Apply patch - Create a patron card with a patron who has a patron image Result: PDF is OK and contains the image Bonus test: Do the same with a card layout with an additional image (Image 2: Image source: Other image) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16747 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical Summary|Patron card creator broken |Fix regression in patron |with version 16.05 |card creator (patron image) Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16747 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16747 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52454|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 52481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52481&action=edit [SIGNED-OFF] Bug 16747 - Patron card creator broken with version 16.05 To reproduce: - Prepare a patron car layout with Image 1 using Patron Image - Create a patron card for a patron without patron image Result: OK, PDF can be opened wit PDF viewer - Try to create a patron card with a patron who has a patron image Result: The PDF file is corrupt (contains text only with error message) intranet error log contains: create-pdf.pl: Illegal division by zero at /usr/share/kohaclone/patroncards/create-pdf.pl line 200 To test: - Apply patch - Create a patron card with a patron who has a patron image Result: PDF is OK and contains the image Bonus test: Do the same with a card layout with an additional image (Image 2: Image source: Other image) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Test and bonus test pass: PDF generated without errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16747 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16747 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52481|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52483&action=edit Bug 16747 - Patron card creator broken with version 16.05 To reproduce: - Prepare a patron car layout with Image 1 using Patron Image - Create a patron card for a patron without patron image Result: OK, PDF can be opened wit PDF viewer - Try to create a patron card with a patron who has a patron image Result: The PDF file is corrupt (contains text only with error message) intranet error log contains: create-pdf.pl: Illegal division by zero at /usr/share/kohaclone/patroncards/create-pdf.pl line 200 To test: - Apply patch - Create a patron card with a patron who has a patron image Result: PDF is OK and contains the image Bonus test: Do the same with a card layout with an additional image (Image 2: Image source: Other image) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Test and bonus test pass: PDF generated without errors. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16747 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #6 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the November 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16747 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #7 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.01. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16747 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in 3.22.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16747 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|Oldversions |--- -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org