https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Felicity Brown <felicity.brown@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |felicity.brown@montgomeryco | |untymd.gov --- Comment #1 from Felicity Brown <felicity.brown@montgomerycountymd.gov> --- Conversely, it would be nice to have the option to have items check-in automatically (be removed from a customer's account) when a staff member marks them as withdrawn, so that they don't linger forever in both statuses. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Kris <kbecker@jcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kbecker@jcls.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176241&action=edit Bug 23010: Add system preference PreventWithdrawingItemsStatus -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177299&action=edit Bug 23010: Add ability to block withdrawning of items with certain statuses -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177413&action=edit Bug 23010: Add unit tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176241|0 |1 is obsolete| | --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177434&action=edit Bug 23010: Add system preference PreventWithdrawingItemsStatus To test: 1. APPLY PATCH, updatedatabase, and restart_all 2. Search for the system preference, PreventWithDrawingItemsStatus 3. Select both in transit and checked out, then save 4. Find an item and put it in transit. 5. Now from the item detail page, go to manage items > edit item 6. Using the item that was put in transit, attempt to change the status to withdrawn. 7. You should see an error at the top of the page 'In transit item cannot be withdrawn.' Make sure the item did not get marked as withdrawn. 8. Using a different item, do a checkout 9. Now from the item detail page, go to manage items > edit item 10. Using the checked out item, attempt to change the status to withdrawn. 11. vYou should see an error at the top of the page 'Onloan item cannot be withdrawn.' Make sure the item did not get marked as withdrawn. 12. Now, using the in transit item, go to the items tab. ( catalogue/moredetail.pl?biblionumber=x ) 13. Under Statuses, attempt to withdraw the item. 14. You should see an error near the top of the page "Cannot withdraw item in transit". 15. Now, using the checked out item, go to the items tab. ( catalogue/moredetail.pl?biblionumber=144 ) 16. Under Statuses, attempt to withdraw the item. 17. You should see an error near the top of the page "Cannot withdraw checked out item.". 18. Using both the in-transit and checked out item, attempt to modify the status through batchMod. 19. Ensure that the items are not being updated to withdrawn. 20. Turn off PreventWithDrawingItemsStatus system preferece. 21. Going through each of the steps again, except this time your items should successfully withdraw. prove t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177402|0 |1 is obsolete| | --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177436&action=edit Bug 23010: Handle error in updateitem.pl and template -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 --- Comment #16 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 177452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177452&action=edit Bug 23010: Add ability to block withdrawning of items with certain statuses Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 --- Comment #18 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 177454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177454&action=edit Bug 23010: Add unit tests Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177451|0 |1 is obsolete| | Attachment #177452|0 |1 is obsolete| | Attachment #177453|0 |1 is obsolete| | Attachment #177454|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177911&action=edit Bug 23010: Add system preference PreventWithdrawingItemsStatus To test: 1. APPLY PATCH, updatedatabase, and restart_all 2. Search for the system preference, PreventWithDrawingItemsStatus 3. Select both in transit and checked out, then save 4. Find an item and put it in transit. 5. Now from the item detail page, go to manage items > edit item 6. Using the item that was put in transit, attempt to change the status to withdrawn. 7. You should see an error at the top of the page 'In transit item cannot be withdrawn.' Make sure the item did not get marked as withdrawn. 8. Using a different item, do a checkout 9. Now from the item detail page, go to manage items > edit item 10. Using the checked out item, attempt to change the status to withdrawn. 11. vYou should see an error at the top of the page 'Onloan item cannot be withdrawn.' Make sure the item did not get marked as withdrawn. 12. Now, using the in transit item, go to the items tab. ( catalogue/moredetail.pl?biblionumber=x ) 13. Under Statuses, attempt to withdraw the item. 14. You should see an error near the top of the page "Cannot withdraw item in transit". 15. Now, using the checked out item, go to the items tab. ( catalogue/moredetail.pl?biblionumber=144 ) 16. Under Statuses, attempt to withdraw the item. 17. You should see an error near the top of the page "Cannot withdraw checked out item.". 18. Using both the in-transit and checked out item, attempt to modify the status through batchMod. 19. Ensure that the items are not being updated to withdrawn. 20. Turn off PreventWithDrawingItemsStatus system preferece. 21. Going through each of the steps again, except this time your items should successfully withdraw. prove t/db_dependent/Koha/Item.t Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 --- Comment #22 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177913&action=edit Bug 23010: Handle error in updateitem.pl and template Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #24 from Jonathan Druart <jonathan.druart@gmail.com> --- Rebased using the auto-rebase script, and some manual fixes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 --- Comment #25 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178808&action=edit Bug 23010: Fix file permission of atomicupdate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #26 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Needs another rebase, unfortunately :( Looking at the code, this looks very promising! I do have one question, though: in Item.pm, the store method is throwing an exception in the middle if a withdrawn status is blocked by the syspref. Wouldn't that interrupt the processing of unrelated fields? (Or am I missing some Perl magic here?) Also, quick spelling fix: the syspref name should be PreventWithdrawing... (lowercase d), not PreventWithDrawing... (uppercase D), since withdrawing is one word. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177912|0 |1 is obsolete| | --- Comment #28 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181323&action=edit Bug 23010: Add ability to block withdrawning of items with certain statuses Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177914|0 |1 is obsolete| | --- Comment #30 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181325&action=edit Bug 23010: Add unit tests Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 --- Comment #32 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181327&action=edit Bug 23010: Update pref name to PreventWithdrawingItemsStatus -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 --- Comment #35 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- (In reply to Lucas Gass (lukeg) from comment #33)

...

I do have one question, though: in Item.pm, the store method is throwing an exception in the middle if a withdrawn status is blocked by the syspref. Wouldn't that interrupt the processing of unrelated fields? (Or am I missing some Perl magic here?)

Good question, Emily! I wrote this so if you try to update an item to a status that is not allowed via the system preference, we stop and exit. You can't get into this IF statement unless the syspref is on and you are editing the withdrawn status. If you edit other fields they won't be saved.

It sounds like you would like this warn the user that they cannot updated the withdrawn status but continue to update other fields they have changes at that same time?

Thanks for clarifying the intent here, Lucas! I was partly thinking about whether other fields should still be updated, and partly concerned about whether there would be side effects from the code that runs before we stop and exit. Both of these concerns mostly came from me missing/forgetting how Koha Objects and DBIC work, so please disregard my previous comment. :) I will try to QA this next week, but I'm not confident I'll be able to get to it before the soft feature freeze, so not setting myself as the QA contact just yet. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #36 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Thanks for working on this one, Lucas! I found a few things that need follow-up, but it's pretty close! If you're able to follow up before the deadline for this cycle, I'll do my best to review it right away and move it along. == Blockers == - Test coverage needed for the changes to BatchItemUpdate.pm and Items.pm in the last patch - The Automatic Item Modification by Age tool is able to set the withdrawn status, so it needs to handle the exception. Currently, with the patchset, the cron crashes if it tries to set the withdrawn status on an item where withdrawing is not allowed. Example steps to produce the error: 1. Set PreventWithdrawingItemsStatus to prevent withdrawing on both checkout and in-transit 2. Add the following Automatic Item Modification by Age rule: age: 365 age field: items.dateaccessioned condition: items.biblionumber = 126 substitution: items.withdrawn = 1 **Note, due to bug 39864, you currently cannot do this through the staff interface, and you need to insert the rule directly into the database: INSERT INTO systempreferences(variable, value) VALUES ('automatic_item_modification_by_age_configuration', '[{"agefield":"items.dateaccessioned","conditions":[{"value":126,"field":"items.biblionumber"}],"age":"400","substitutions":[{"field":"items.withdrawn","value":"1"}]}]'); 3. Search for biblionumber 126 (Intermediate Perl) 4. Check out one of its items and put another one of its items in-transit 5. misc/cronjobs/automatic_item_modification_by_age.pl -v --> Confirm the cron will try to withdraw the 4 items from that bib 6. misc/cronjobs/automatic_item_modification_by_age.pl -c --> Cron job throws an exception (When I tested the above, one of the items that should have been withdrawn did not get withdrawn because the cron crashed, but I'm not sure what determines the order in which the items are processed, so ymmv) == Needs feedback ==

From additem.pl (around line 650):

+ } catch { + if ( ref $_ && $_->can('error') ) { + push @errors, $_->error; + } + } Should we do something else with the error (or die/rethrow) if not $_->can('error')? I imagine it would be a pretty unusual edge case for that check to fail, but if it does, we shouldn't fail silently. ----

From cataloguing_additem.js:

$(document).ready(function () { + $( + '#cataloguing_additem_newitem #f[action^="/cgi-bin/koha/cataloguing/additem.pl"]' + ); // Remove the onclick event defined in browser.js, // otherwise the deletion confirmation will not work correctly $('a[href*="biblionumber="]').off("click"); It's not clear to me what this change does or if it's intentional. If it is an intentional change, can you clarify? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 --- Comment #38 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 182129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182129&action=edit Bug 23010: Add tests for AutomaticItemModificationByAge -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 --- Comment #40 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 182130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182130&action=edit Bug 23010: Remove JS added by mistake -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 --- Comment #42 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---

== Needs feedback ==

From additem.pl (around line 650):

+ } catch { + if ( ref $_ && $_->can('error') ) { + push @errors, $_->error; + } + }

Should we do something else with the error (or die/rethrow) if not $_->can('error')? I imagine it would be a pretty unusual edge case for that check to fail, but if it does, we shouldn't fail silently.

OK, looking back here I am unclear why I did this. I don't think we need to do the `if ( ref $_ && $_->can('error') ) {` We should just try to store and if not catch the error -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 --- Comment #44 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---

- Test coverage needed for the changes to BatchItemUpdate.pm and Items.pm in the last patch

I'm really not sure how to write a test for the 1 line change in BatchItemUpdate.pm... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 --- Comment #45 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 182201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182201&action=edit Bug 23010: More unit tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181322|0 |1 is obsolete| | --- Comment #46 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 182212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182212&action=edit Bug 23010: Add system preference PreventWithdrawingItemsStatus To test: 1. APPLY PATCH, updatedatabase, and restart_all 2. Search for the system preference, PreventWithDrawingItemsStatus 3. Select both in transit and checked out, then save 4. Find an item and put it in transit. 5. Now from the item detail page, go to manage items > edit item 6. Using the item that was put in transit, attempt to change the status to withdrawn. 7. You should see an error at the top of the page 'In transit item cannot be withdrawn.' Make sure the item did not get marked as withdrawn. 8. Using a different item, do a checkout 9. Now from the item detail page, go to manage items > edit item 10. Using the checked out item, attempt to change the status to withdrawn. 11. vYou should see an error at the top of the page 'Onloan item cannot be withdrawn.' Make sure the item did not get marked as withdrawn. 12. Now, using the in transit item, go to the items tab. ( catalogue/moredetail.pl?biblionumber=x ) 13. Under Statuses, attempt to withdraw the item. 14. You should see an error near the top of the page "Cannot withdraw item in transit". 15. Now, using the checked out item, go to the items tab. ( catalogue/moredetail.pl?biblionumber=144 ) 16. Under Statuses, attempt to withdraw the item. 17. You should see an error near the top of the page "Cannot withdraw checked out item.". 18. Using both the in-transit and checked out item, attempt to modify the status through batchMod. 19. Ensure that the items are not being updated to withdrawn. 20. Turn off PreventWithDrawingItemsStatus system preferece. 21. Going through each of the steps again, except this time your items should successfully withdraw. prove t/db_dependent/Koha/Item.t Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181324|0 |1 is obsolete| | --- Comment #48 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 182214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182214&action=edit Bug 23010: Handle error in updateitem.pl and template Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181326|0 |1 is obsolete| | --- Comment #50 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 182216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182216&action=edit Bug 23010: Fix file permission of atomicupdate Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181400|0 |1 is obsolete| | --- Comment #52 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 182218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182218&action=edit Bug 23010: Report on count of items not modified via batchMod Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182129|0 |1 is obsolete| | --- Comment #54 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 182220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182220&action=edit Bug 23010: Add tests for AutomaticItemModificationByAge Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182131|0 |1 is obsolete| | --- Comment #56 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 182222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182222&action=edit Bug 23010: Clean up try/catch in additem.pl Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 --- Comment #58 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 182224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182224&action=edit Bug 23010: (QA follow-up) a few trivial fixes - Update the dbrev to use say_success, and make dbrev and installer consistent - Change error div in moredetail.tt from info to warning Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_11_candidate --- Comment #60 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is a conflict in Item.t currently when applying. This turned into quite a big set of patches, I am inclined considering the point in time in this cycle to leave this for 25.11. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182212|0 |1 is obsolete| | --- Comment #61 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 182611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182611&action=edit Bug 23010: Add system preference PreventWithdrawingItemsStatus To test: 1. APPLY PATCH, updatedatabase, and restart_all 2. Search for the system preference, PreventWithDrawingItemsStatus 3. Select both in transit and checked out, then save 4. Find an item and put it in transit. 5. Now from the item detail page, go to manage items > edit item 6. Using the item that was put in transit, attempt to change the status to withdrawn. 7. You should see an error at the top of the page 'In transit item cannot be withdrawn.' Make sure the item did not get marked as withdrawn. 8. Using a different item, do a checkout 9. Now from the item detail page, go to manage items > edit item 10. Using the checked out item, attempt to change the status to withdrawn. 11. vYou should see an error at the top of the page 'Onloan item cannot be withdrawn.' Make sure the item did not get marked as withdrawn. 12. Now, using the in transit item, go to the items tab. ( catalogue/moredetail.pl?biblionumber=x ) 13. Under Statuses, attempt to withdraw the item. 14. You should see an error near the top of the page "Cannot withdraw item in transit". 15. Now, using the checked out item, go to the items tab. ( catalogue/moredetail.pl?biblionumber=144 ) 16. Under Statuses, attempt to withdraw the item. 17. You should see an error near the top of the page "Cannot withdraw checked out item.". 18. Using both the in-transit and checked out item, attempt to modify the status through batchMod. 19. Ensure that the items are not being updated to withdrawn. 20. Turn off PreventWithDrawingItemsStatus system preferece. 21. Going through each of the steps again, except this time your items should successfully withdraw. prove t/db_dependent/Koha/Item.t Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182214|0 |1 is obsolete| | --- Comment #63 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 182613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182613&action=edit Bug 23010: Handle error in updateitem.pl and template Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182216|0 |1 is obsolete| | --- Comment #65 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 182615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182615&action=edit Bug 23010: Fix file permission of atomicupdate Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182218|0 |1 is obsolete| | --- Comment #67 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 182617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182617&action=edit Bug 23010: Report on count of items not modified via batchMod Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182220|0 |1 is obsolete| | --- Comment #69 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 182619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182619&action=edit Bug 23010: Add tests for AutomaticItemModificationByAge Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182222|0 |1 is obsolete| | --- Comment #71 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 182621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182621&action=edit Bug 23010: Clean up try/catch in additem.pl Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182224|0 |1 is obsolete| | --- Comment #73 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 182623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182623&action=edit Bug 23010: (QA follow-up) a few trivial fixes - Update the dbrev to use say_success, and make dbrev and installer consistent - Change error div in moredetail.tt from info to warning Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_25_11_candidate | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds a new |This enhancement adds a new release notes|system preference, |system preference, |PreventWithDrawingItemsStat |PreventWithDrawingItemsStat |us. When the system |us. When the system |preference is enabled it |preference is enabled it |will prevent items that are |will prevent items that are |in-transit or checked out |in-transit or checked out |from being withdrawn. |from being withdrawn. | | | |** Sponsored by Cuyahoga | |County Public Library ** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 --- Comment #77 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #78 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #79 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- What is the logic behind having this system preference in Circulation > Checkin policy? I feel like it's more of a cataloguing pref, but I'm curious as to why it was put there exactly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 --- Comment #80 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Caroline Cyr La Rose from comment #79)

What is the logic behind having this system preference in Circulation > Checkin policy? I feel like it's more of a cataloguing pref, but I'm curious as to why it was put there exactly.

Probably I didn't put enough thought into this. I think a case could be made for it to be in either? If we want to move it, I would be happy to do so. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42355 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42355 [Bug 42355] (Bug 23010 follow-up) in additem.pl improperly handled exception -- You are receiving this mail because: You are watching all bug changes.