[Bug 36127] New: Port default HOLDPLACED and HOLD_CHANGED notices to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36127 Bug ID: 36127 Summary: Port default HOLDPLACED and HOLD_CHANGED notices to Template Toolkit syntax Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: roadmap_24_05 Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: emily.lamancusa@montgomerycountymd.gov QA Contact: testopia@bugs.koha-community.org Blocks: 15278 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36127 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36127 --- Comment #1 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 175652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175652&action=edit Bug 36127: Adjust default HOLDPLACED and HOLD_CHANGED notices to use TT To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Edit system preferences: emailLibrarianWhenHoldIsPlaced - Enable ReplyToDefault - enter a fake/test email address ExpireReservesMaxPickupDelay - Allow ExpireReservesAutoFill - Do ExpireReservesAutoFillEmail - same email address as ReplyToDefault 4. Place two holds on the same bib for two different patrons, Patron A and Patron B 5. Edit an item on that bib to set a call number (if it doesn't have one already) 6. Check in that item to set Patron A's hold to waiting 7. Edit the expiration date on Patron A's hold to yesterday's date To do this in KTD: ktd --shell koha-mysql kohadev UPDATE reserves SET expirationdate = <yesterday's date> WHERE borrowernumber = <Patron A's borrowernumber>; 8. Run misc/cronjobs/holds/cancel_expired_holds.pl to automatically cancel the expired hold and fill the next one 9. Open koha-mysql again and run the following query to view the generated notices: SELECT subject, content FROM message_queue WHERE to_address = '<the email address you set in step 3>'; --> Confirm that HOLDPLACED and HOLD_CHANGED notices were both generated --> Confirm that all information has been filled in correctly for those notices -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36127 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emily.lamancusa@montgomeryc |ity.org |ountymd.gov Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36127 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175652|0 |1 is obsolete| | --- Comment #2 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 180589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180589&action=edit Bug 36127: Adjust default HOLDPLACED and HOLD_CHANGED notices to use TT To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Edit system preferences: emailLibrarianWhenHoldIsPlaced - Enable ReplyToDefault - enter a fake/test email address ExpireReservesMaxPickupDelay - Allow ExpireReservesAutoFill - Do ExpireReservesAutoFillEmail - same email address as ReplyToDefault 4. Place two holds on the same bib for two different patrons, Patron A and Patron B 5. Edit an item on that bib to set a call number (if it doesn't have one already) 6. Check in that item to set Patron A's hold to waiting 7. Edit the expiration date on Patron A's hold to yesterday's date To do this in KTD: ktd --shell koha-mysql kohadev UPDATE reserves SET expirationdate = <yesterday's date> WHERE borrowernumber = <Patron A's borrowernumber>; 8. Run misc/cronjobs/holds/cancel_expired_holds.pl to automatically cancel the expired hold and fill the next one 9. Open koha-mysql again and run the following query to view the generated notices: SELECT subject, content FROM message_queue WHERE to_address = '<the email address you set in step 3>'; --> Confirm that HOLDPLACED and HOLD_CHANGED notices were both generated --> Confirm that all information has been filled in correctly for those notices Signed-off-by: Marion Durand <marion.durand@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36127 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |marion.durand@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36127 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36127 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180589|0 |1 is obsolete| | --- Comment #3 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 184962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184962&action=edit Bug 36127: Adjust default HOLDPLACED and HOLD_CHANGED notices to use TT To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Edit system preferences: emailLibrarianWhenHoldIsPlaced - Enable ReplyToDefault - enter a fake/test email address ExpireReservesMaxPickupDelay - Allow ExpireReservesAutoFill - Do ExpireReservesAutoFillEmail - same email address as ReplyToDefault 4. Place two holds on the same bib for two different patrons, Patron A and Patron B 5. Edit an item on that bib to set a call number (if it doesn't have one already) 6. Check in that item to set Patron A's hold to waiting 7. Edit the expiration date on Patron A's hold to yesterday's date To do this in KTD: ktd --shell koha-mysql kohadev UPDATE reserves SET expirationdate = <yesterday's date> WHERE borrowernumber = <Patron A's borrowernumber>; 8. Run misc/cronjobs/holds/cancel_expired_holds.pl to automatically cancel the expired hold and fill the next one 9. Open koha-mysql again and run the following query to view the generated notices: SELECT subject, content FROM message_queue WHERE to_address = '<the email address you set in step 3>'; --> Confirm that HOLDPLACED and HOLD_CHANGED notices were both generated --> Confirm that all information has been filled in correctly for those notices Signed-off-by: Marion Durand <marion.durand@biblibre.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36127 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m Keywords|Academy, roadmap_24_05 |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36127 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36127 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36127 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36127 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36127 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36127 --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36127 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org