[Bug 9377] New: itemtype in duplicate biblio search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 Bug ID: 9377 Summary: itemtype in duplicate biblio search Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: fridolyn.somers@biblibre.com CC: m.de.rooy@rijksmuseum.nl In C4::Search::FindDuplicate, when biblio has no ISBN, the duplicate search adds : $query .= " and itemtype=$result->{itemtype}". This should be only when itemtype is defined in biblio and not in items. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 14535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14535&action=edit Proposed patch See commit comment -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14535|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 14557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14557&action=edit [SIGNED-OFF] Bug 9377 - itemtype in duplicate biblio search In C4::Search::FindDuplicate, when biblio has no ISBN, the duplicate search adds : $query .= " and itemtype=$result->{itemtype}". This should be only when itemtype is defined in biblio and not in items. Test plan : On a database with itemtype mapped in biblioitems and "item-level_itypes" syspref on "biblio record" : - Go to a biblio details page - Click on "Edit as new (duplicate)" - If ISBN is defined, remove it - Click on save => a duplicate is detected - Change biblio item type - Click on save => no duplicate detected - Set "item-level_itypes" syspref to "specific record" - Come back to biblio details page - Click on "Edit as new (duplicate)" - If ISBN is defined, remove it - Click on save => a duplicate is detected - Change biblio item type => a duplicate is detected Signed-off-by: Marc Veron <veron@veron.ch> Followed test plan. Behaves as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14557|0 |1 is obsolete| | --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 15798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15798&action=edit Bug 9377 - itemtype in duplicate biblio search In C4::Search::FindDuplicate, when biblio has no ISBN, the duplicate search adds : $query .= " and itemtype=$result->{itemtype}". This should be only when itemtype is defined in biblio and not in items. Test plan : On a database with itemtype mapped in biblioitems and "item-level_itypes" syspref on "biblio record" : - Go to a biblio details page - Click on "Edit as new (duplicate)" - If ISBN is defined, remove it - Click on save => a duplicate is detected - Change biblio item type - Click on save => no duplicate detected - Set "item-level_itypes" syspref to "specific record" - Come back to biblio details page - Click on "Edit as new (duplicate)" - If ISBN is defined, remove it - Click on save => a duplicate is detected - Change biblio item type => a duplicate is detected Signed-off-by: Marc Veron <veron@veron.ch> Followed test plan. Behaves as expected. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Tested. Works. Had some funny things when editing as new while changing frameworks, but apparently not related to your patch. Somewhat out of scope: But I am wondering if I save a new biblio with same title or ISBN and different itemtype (with item level biblio), if I would still like to have the warning? For the rest: Code looks good to me. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Why is this patch needed? Would it not be better to simply remove the itemtype check altogether, if it does not work properly? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 --- Comment #7 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #6)
Why is this patch needed? Would it not be better to simply remove the itemtype check altogether, if it does not work properly?
I agree if it is accepted by community. A false duplicate on title and author must be very unusual (maybe book and movie), and better show duplicate message too often than not enough. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #7)
I agree if it is accepted by community. A false duplicate on title and author must be very unusual (maybe book and movie), and better show duplicate message too often than not enough.
+1 from me Please send an adjusted patch or followup. I will be happy to sign off if needed.. Please change status accordingly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- +1 from me too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15798|0 |1 is obsolete| | --- Comment #10 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 15942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15942&action=edit Proposed patch (remove itemtype) Rewritten patch that simply removes item type from find duplicate. See commit message -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 15964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15964&action=edit Bug 9377 - itemtype in duplicate biblio search In C4::Search::FindDuplicate, when biblio has no ISBN, the duplicate search adds : $query .= " and itemtype=$result->{itemtype}". This is wrong when itemtype is defined in items. This patch simply removes the itemtype from dublicate search. Test plan : - Go to a biblio details page - Click on "Edit as new (duplicate)" - If ISBN is defined, remove it - Click on save => a duplicate is detected - Change biblio item type and save => a duplicate is detected Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Tested with no isbn, other itemtype. Before the patch Koha just saves the record, now it gives a duplicate warning. Great. Signed off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Code looks even better :) Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15942|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.4 and 3.8.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org