[Bug 9860] New: Incorrect box heading 'Cannot check in' when a late document is returned
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9860 Bug ID: 9860 Summary: Incorrect box heading 'Cannot check in' when a late document is returned Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: koha@univ-lyon3.fr CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Created attachment 16458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16458&action=edit cannot check in When a late document is checked in, every thing works as it should (the check in is correctly recorded) except that the warning box displays, in addition to the usual restriction applied to patron, an extra and inappropriate heading 'Cannot check in'. (cf joined image). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9860 --- Comment #1 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 17272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17272&action=edit Bug 9860 Incorrect box heading (Cannot check in) when a document is late 'Cannot check in' heading had to be displayed when an invalid return (withdrawn, not check out etc.) is processed but not when a late document is checked in. Test plan : 1. Apply patch 2. Check in Invalid Item 3. See that 'Cannot check in' header is displayed 4. Check in a late document 5. See that 'Cannot check in' header is NOT displayed 6. Sign off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9860 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 Status|NEW |Needs Signoff CC| |koha@univ-lyon3.fr See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9397 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9860 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- In order to understand the problem that needs to be fixed here we have to look at the cause: Bug 9397. The patch for that bug made the incorrect assumption that for all check-in error messages the appropriate message is "Cannot check in." As this bug shows, this is not correct. In fact the way the template was before Bug 9397 is more correct. A correct fix which covered the goals of both bugs would revert the changes made by bug 9397 and add a generic heading for all check-in messages. "Check in notice" or something vague like that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9860 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9860 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 17292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17292&action=edit Bug 9860 [Alternate] Incorrect box heading 'Cannot check in' when a late document is returned The fix for Bug 9397 moved the "cannot check in" heading from within the one conditional where it should have been displayed to the top of all check-in errors/messages. "Cannot check in" is still only valid if the item is withdrawn and BlockReturnOfWithdrawnItems is ON. In order to accomplish the goal of Bug 9397 while fixing Bug 9860 this patch puts "cannot check in" back into the correct conditional and adds a generic heading to check in messages for accessibility purposes. To test, check in items which will trigger a variety of errors including: - item must be returned to home library - item is lost - item is withdrawn (wtih BlockReturnOfWithdrawnItems on and off) - item is overdue ...as well as items which should check in normally. Messages should display correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9860 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9860 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9860 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17272|0 |1 is obsolete| | Attachment #17292|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17304&action=edit Bug 9860 [Alternate] Incorrect box heading 'Cannot check in' when a late document is returned The fix for Bug 9397 moved the "cannot check in" heading from within the one conditional where it should have been displayed to the top of all check-in errors/messages. "Cannot check in" is still only valid if the item is withdrawn and BlockReturnOfWithdrawnItems is ON. In order to accomplish the goal of Bug 9397 while fixing Bug 9860 this patch puts "cannot check in" back into the correct conditional and adds a generic heading to check in messages for accessibility purposes. To test, check in items which will trigger a variety of errors including: - item must be returned to home library - item is lost - item is withdrawn (wtih BlockReturnOfWithdrawnItems on and off) - item is overdue ...as well as items which should check in normally. Messages should display correctly. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9860 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |String patch Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: My fault, I amended the patch for bug 9397 too quickly! This one is a string patch and fix correctly the message problem. Marked as Passed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9860 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17304|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 17555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17555&action=edit Bug 9860 [Alternate] Incorrect box heading 'Cannot check in' when a late document is returned The fix for Bug 9397 moved the "cannot check in" heading from within the one conditional where it should have been displayed to the top of all check-in errors/messages. "Cannot check in" is still only valid if the item is withdrawn and BlockReturnOfWithdrawnItems is ON. In order to accomplish the goal of Bug 9397 while fixing Bug 9860 this patch puts "cannot check in" back into the correct conditional and adds a generic heading to check in messages for accessibility purposes. To test, check in items which will trigger a variety of errors including: - item must be returned to home library - item is lost - item is withdrawn (wtih BlockReturnOfWithdrawnItems on and off) - item is overdue ...as well as items which should check in normally. Messages should display correctly. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9860 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9860 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org