[Bug 23294] New: standing order not showing actual cost when modifying order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23294 Bug ID: 23294 Summary: standing order not showing actual cost when modifying order Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Bug 23020 already details how received cost for standing orders is not shown on basket.pl. 18.11 has changed how costs are calculated and displayed on neworderempty.pl, exacerbating the problem To Test: - Create a standing order basket - Add an order to that basket with no price information filled out - Receive a copy of the standing order and record an actual price at receipt - Go back to your basket and click Modify for your received order - See that it still shows $0 for Total Prior to 18.11, Total was derived from aqorders.unitprice, which reflected the Actual Cost entered when receiving. Now it is only derived from budgeted cost. This is an issue for standing orders, for which many libraries do not enter a budgeted cost, only an actual cost at receipt. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23294 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23294 --- Comment #1 from Andrew <andrew@bywatersolutions.com> ---
Prior to 18.11, Total was derived from aqorders.unitprice, which reflected the Actual Cost entered when receiving.
Sorry, I was incorrect about this bit. Prior to 18.11, orders showed both budgeted total *and* actual cost. Actual cost was removed in Bug 9775. For what it's worth, see also Bug 23020, which is also about getting actual cost to be visible from the basket end of things. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23294 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Depends on| |9775 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23320 Version|18.11 |master CC| |nick@bywatersolutions.com --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Bug 9775 removed this field as it didn't fit all workflows I propose we should restore it and make it easily hideable for those who don't want to see it. Standing order baskets allow modification of received orders and we have hidden information Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9775 [Bug 9775] unitprice should be hidden when creating an order -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23294 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23294 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91540&action=edit Bug 23294: Show actual price when ordering To test: 1 - Have a basket 2 - Add an order 3 - Modify the order, note you cannot see the unitprice/Actual cost 4 - Apply patch 5 - Note it is there 6 - Add to IntranetUserCSS: .ordering_unitprice{ display:none; } 7 - Reload 8 - Note it is hidden -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23294 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23294 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91540|0 |1 is obsolete| | --- Comment #4 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 91673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91673&action=edit Bug 23294: Show actual price when ordering To test: 1 - Have a basket 2 - Add an order 3 - Modify the order, note you cannot see the unitprice/Actual cost 4 - Apply patch 5 - Note it is there 6 - Add to IntranetUserCSS: .ordering_unitprice{ display:none; } 7 - Reload 8 - Note it is hidden Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23294 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |maryse.simard@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23294 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the question was not about seeing, but if we want to be able to edit the value at this point in time. I notice that there is a difference in behaviour to before bug 9775 and with this patch now - the input field used to appear as readonly when the basket was closed. I have no strong opinion here - when the basket is closed we don't offer edit links, so the difference is only seen if you try a little harder. It might be useful in some cases. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23294 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23294 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91673|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92358&action=edit Bug 23294: Show actual price when ordering To test: 1 - Have a basket 2 - Add an order 3 - Modify the order, note you cannot see the unitprice/Actual cost 4 - Apply patch 5 - Note it is there 6 - Add to IntranetUserCSS: .ordering_unitprice{ display:none; } 7 - Reload 8 - Note it is hidden Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23294 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've rephrased this - it's not only for standing orders. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23294 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23294 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23294 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|standing order not showing |Restore actual cost input |actual cost when modifying |field on order page |order | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23294 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.04 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23294 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23294 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23294 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27203 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203 [Bug 27203] Order unitprice is not set anymore and totals are 0. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org