[Bug 31919] New: Hovered items in "More" should change background color
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 Bug ID: 31919 Summary: Hovered items in "More" should change background color Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 30952 when I am on acqui-home.pl, the nav menu is showing the item hovered by the pointer with a nice green label on the left of the element, and changing its background. However the behaviour in the "More" dropdown menu is to simply underline the selected items. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 142709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142709&action=edit Bug 31919: Add background-color to a:hover in the header -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |martin.renvoize@ptfs-europe | |.com, oleonard@myacpl.org Status|NEW |In Discussion --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Like that? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142709|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142755&action=edit Bug 31919: Add background-color to a:hover in the header Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I like it I think.. though I'm not 100% on the bottom marging staying black.. Signing off, but other opinions are welcome. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please don't forget to set assignee! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142755|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142810&action=edit Bug 31919: Add background-color to a:hover in the header Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I like that this makes it easier visible what you have selected. Love it on the pull downs, not completely sure about the menu items. But I think it's better than the underline that is not as visible by far. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #5)
Please don't forget to set assignee!
It was not a clean patch (it was not NSO) and hadn't more time to spend on this, it was only a suggestion patch and didn't set the assignee on purpose ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I would wait for Owen's opinion before pushing this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142810|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142828&action=edit Bug 31919: [alternate] Add backgground color to hovered items in header dropdowns This alternate patch is different in a few ways: - Add a hover background color only to items in dropdown menus. - Use an SCSS variable for the background color - Update the specificity of the hover CSS to more fully override Bootstrap's default. To test, apply the patch and rebuild the staff interface CSS. - On any page in the staff interface, test the behavior of links in the nav header. - The always-visible links (Circulation, Patrons, etc) should keep the same style as before: Underline on hover. - In dropdown menus like "More" and the user menu in the upper right corner, hovered links should have a green background. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- The behaviour of the background-color for the "Search bottom array" is really weird. But it's not coming from this patch I think. Could you have a look? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142828|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 142831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142831&action=edit Bug 31919: Add backgground color to hovered items in header dropdowns This alternate patch is different in a few ways: - Add a hover background color only to items in dropdown menus. - Use an SCSS variable for the background color - Update the specificity of the hover CSS to more fully override Bootstrap's default. To test, apply the patch and rebuild the staff interface CSS. - On any page in the staff interface, test the behavior of links in the nav header. - The always-visible links (Circulation, Patrons, etc) should keep the same style as before: Underline on hover. - In dropdown menus like "More" and the user menu in the upper right corner, hovered links should have a green background. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|jonathan.druart+koha@gmail. |oleonard@myacpl.org |com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142831|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142893&action=edit Bug 31919: Add backgground color to hovered items in header dropdowns This alternate patch is different in a few ways: - Add a hover background color only to items in dropdown menus. - Use an SCSS variable for the background color - Update the specificity of the hover CSS to more fully override Bootstrap's default. To test, apply the patch and rebuild the staff interface CSS. - On any page in the staff interface, test the behavior of links in the nav header. - The always-visible links (Circulation, Patrons, etc) should keep the same style as before: Underline on hover. - In dropdown menus like "More" and the user menu in the upper right corner, hovered links should have a green background. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31919 Bug 31919 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org