[Bug 22639] New: Elasticsearc ability export/import mappings and facets settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Bug ID: 22639 Summary: Elasticsearc ability export/import mappings and facets settings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: black23@gmail.com Target Milestone: --- For easier maintance export/import of settings will be great feature. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com, | |ere.maijala@helsinki.fi, | |josef.moravec@gmail.com, | |rbit@rbit.cz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #1 from Ere Maijala <ere.maijala@helsinki.fi> --- Import is sort of there already. You can define custom files in koha-conf.xml with the following settings: <elasticsearch_index_config> <elasticsearch_field_config> <elasticsearch_index_mappings> Whenever you reset the mappings in Administration, elasticsearch_index_mappings, if specified, is used to locate the default mappings. When you drop and recreate the index, elasticsearch_index_config and elasticsearch_field_config are used to create the new index. Actually, the only thing missing is export of current mappings. I believe it wouldn't be needed regularly if you decided to use a custom mappings.yaml to define the settings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I imagine maybe Michal was thinking about something that could be done form the GUI, not requiring access to the server to set/change file paths. Ere - is this behavior below documented somewhere? (wiki or manual?) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #3 from Ere Maijala <ere.maijala@helsinki.fi> --- True, and I'm not saying they wouldn't be useful, but the files are the only place where the index and field configs are stored, so import/export would be sort of like file transfers. Looks like I may have forgotten to add documentation to the wiki page, I'll fix that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Elasticsearc ability |Elasticsearch ability |export/import mappings and |export/import mappings and |facets settings |facets settings -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #5 from Michal Denar <black23@gmail.com> --- My descriotion fault. I'm thinking about import/export from UI. I think that many librarians hasn't access to server filesystem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #6 from Ere Maijala <ere.maijala@helsinki.fi> --- Makes sense. Worth noting is that index config and most aspects of field config are irrelevant unless you can also schedule a full reindexing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #7 from Michal Denar <black23@gmail.com> --- Hi Ere, I agree with you. This bug can solve it beuace give chance to reindex from UI: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22637 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22637 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #8 from Ere Maijala <ere.maijala@helsinki.fi> --- Katrin, wiki page updated: https://wiki.koha-community.org/wiki/Elasticsearch#Advanced_Index_Settings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Ere Maijala from comment #8)
Katrin, wiki page updated: https://wiki.koha-community.org/wiki/Elasticsearch#Advanced_Index_Settings
Awesome, thank you! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 axel Amghar <axel.amghar@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |axel.amghar@biblibre.com Assignee|koha-bugs@lists.koha-commun |axel.amghar@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #10 from axel Amghar <axel.amghar@biblibre.com> --- Created attachment 90022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90022&action=edit Bug 22639: Elasticsearch ability to export mappings and facets settings With this patch you can download search fields , biblios and authorities table in search engine configuration Test plan: - apply the patch - make sure you have "elasticsearch" as value for the syspref "SearchEngine" - go to search engine configuration in the admin page - in the search fields part, you have a button "Download ... table" - download in (.csv), (.tab), (.ods) - verify that you have the same table in your file than in the search fields table - make the same test for bibliographic records and authorities - Then add some mappings and dowload, your new file has to be modified -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 axel Amghar <axel.amghar@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #11 from axel Amghar <axel.amghar@biblibre.com> --- Hello, I added a patch to download tables separately. Do you think that a button who download all the tables would be good ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #12 from Michal Denar <black23@gmail.com> --- Hello, I'kk take look on this later today. I set this to Need sign-off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #13 from axel Amghar <axel.amghar@biblibre.com> --- (In reply to Michal Denar from comment #12)
Hello, I'kk take look on this later today. I set this to Need sign-off.
There is only the export option for now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #14 from axel Amghar <axel.amghar@biblibre.com> --- And do you want the possibility to download the facet order table too in bibliographic records ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #15 from Michal Denar <black23@gmail.com> --- Everything works for me. Download of biblio facets order will be fine. Now we can focuse on import. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90022|0 |1 is obsolete| | --- Comment #16 from Michal Denar <black23@gmail.com> --- Created attachment 90052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90052&action=edit Bug 22639: Elasticsearch ability to export mappings and facets settings With this patch you can download search fields , biblios and authorities table in search engine configuration Test plan: - apply the patch - make sure you have "elasticsearch" as value for the syspref "SearchEngine" - go to search engine configuration in the admin page - in the search fields part, you have a button "Download ... table" - download in (.csv), (.tab), (.ods) - verify that you have the same table in your file than in the search fields table - make the same test for bibliographic records and authorities - Then add some mappings and dowload, your new file has to be modified Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- If this is only for export, please change the bug title accordingly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #18 from Michal Denar <black23@gmail.com> --- Hi Katrin, I hope that folow-ups for import are comming. Export without import feature is useless. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #19 from axel Amghar <axel.amghar@biblibre.com> --- (In reply to Michal Denar from comment #18)
Hi Katrin, I hope that folow-ups for import are comming. Export without import feature is useless.
Hi, I could work on it next week :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #20 from Michal Denar <black23@gmail.com> --- Hi, great news :-) Thank you -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it would make sense to either wait or to export on a second depending bug, what do you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Elasticsearch ability |Elasticsearch ability |export/import mappings and |export mappings and facets |facets settings |settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22994 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22994 [Bug 22994] Elasticsearch ability import mappings and facets settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22994 Depends on|22994 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22994 [Bug 22994] Elasticsearch ability import mappings and facets settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22994 Blocks|22994 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22994 [Bug 22994] Elasticsearch ability import mappings and facets settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 axel Amghar <axel.amghar@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90052|0 |1 is obsolete| | --- Comment #22 from axel Amghar <axel.amghar@biblibre.com> --- Created attachment 90151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90151&action=edit Bug 22639: Elasticsearch ability to export mappings and facets settings With this patch you can download search fields , facets order, biblios and authorities table in search engine configuration Test plan: - apply the patch - make sure you have "elasticsearch" as value for the syspref "SearchEngine" - go to search engine configuration in the admin page - in the search fields part, you have a button "Download ... table" - download in (.csv), (.tab), (.ods) - verify that you have the same table in your file than in the search fields table - make the same test for : biblios table : facet order table : authorities table - Add some mappings, modify some fields, change the facets order - Save your modifications - Then dowload again - Your new files must be modified -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 axel Amghar <axel.amghar@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #23 from axel Amghar <axel.amghar@biblibre.com> --- I added the dowload of facet order table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90151|0 |1 is obsolete| | --- Comment #24 from Michal Denar <black23@gmail.com> --- Created attachment 90165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90165&action=edit Bug 22639: Elasticsearch ability to export mappings and facets settings With this patch you can download search fields , facets order, biblios and authorities table in search engine configuration Test plan: - apply the patch - make sure you have "elasticsearch" as value for the syspref "SearchEngine" - go to search engine configuration in the admin page - in the search fields part, you have a button "Download ... table" - download in (.csv), (.tab), (.ods) - verify that you have the same table in your file than in the search fields table - make the same test for : biblios table : facet order table : authorities table - Add some mappings, modify some fields, change the facets order - Save your modifications - Then dowload again - Your new files must be modified Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 axel Amghar <axel.amghar@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20588 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 [Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 axel Amghar <axel.amghar@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90165|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 axel Amghar <axel.amghar@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #25 from axel Amghar <axel.amghar@biblibre.com> --- My previous patch must be redone because we can add the export button on the dataTable. You have an example in cgi-bin/koha/circ/pendingreserves.pl Like that the export will be similar with the others page and there will be less code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #26 from axel Amghar <axel.amghar@biblibre.com> --- Created attachment 90601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90601&action=edit Bug 22639: Elasticsearch ability to export mappings and facets settings With this patch you can download search fields , facets order, biblios and authorities table in search engine configuration Test plan: - apply the patch - make sure you have "elasticsearch" as value for the syspref "SearchEngine" - go to search engine configuration in the admin page - in the search fields part, you have a button "Export" - verify all formats are correct - verify that you have the same table in your file than in the search fields table - make the same test for : biblios table : authorities table - Add some mappings, modify some fields, change the facets order - Save your modifications - Then dowload again - Your new files must be modified ps:with this patch you can't download the facet order table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 axel Amghar <axel.amghar@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90601|0 |1 is obsolete| | --- Comment #27 from axel Amghar <axel.amghar@biblibre.com> --- Created attachment 90602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90602&action=edit Bug 22639: Elasticsearch ability to export mappings and facets settings With this patch you can download search fields , facets order, biblios and authorities table in search engine configuration Test plan: - apply the patch - make sure you have "elasticsearch" as value for the syspref "SearchEngine" - go to search engine configuration in the admin page - in the search fields part, you have a button "Export" - verify all formats are correct - verify that you have the same table in your file than in the search fields table - make the same test for : biblios table : authorities table - Add some mappings, modify some fields, change the facets order - Save your modifications - Then dowload again - Your new files must be modified - You can remove some colomns to dowload only Name and label columns for example ps: with this patch you can't download the facet order table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #28 from axel Amghar <axel.amghar@biblibre.com> --- Hello, I remade the patch with DataTable But i found lot of issues to fix: - the export for search field table aren't working good -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #29 from axel Amghar <axel.amghar@biblibre.com> --- Hello, I tried my best to remade the patch with DataTable (look 22588 for more info) But i found lot of issues to fix: - the export for search field table aren't working good - when you try do dowload elements in the table that are <select> <option></option> ... </select> that shows all the options in the export table, but we want only the selected option They might be some more issues. Good Luck :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |23204 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204 [Bug 23204] Add script for exporting Elasticsearch mappings to YAML -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #30 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Bug 23204 added Koha::SearchEngine::Elasticsearch::raw_elasticsearch_mappings() -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Bug 22639 depends on bug 23204, which changed state. Bug 23204 Summary: Add script for exporting Elasticsearch mappings to YAML https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 22994 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Bug 22639 depends on bug 22994, which changed state. Bug 22994 Summary: Elasticsearch ability import mappings and facets settings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22994 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Bug 22639 depends on bug 20588, which changed state. Bug 20588 Summary: Elasticsearch - Apply dataTable on search fields and mapping tables https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41669 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|axel.amghar@biblibre.com |tomascohen@gmail.com CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90602|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #32 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 195853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195853&action=edit Bug 22639: Add GET /config/search_mappings endpoint This patch adds a new API endpoint to retrieve the search field mappings configuration (search fields and their MARC mappings, grouped by index). The endpoint supports content negotiation: - application/json (default) - application/yaml (for export/import compatibility) An optional 'type' query parameter allows filtering mappings by MARC type (marc21 or unimarc). Implementation notes: - New controller: Koha::REST::V1::Config::SearchMappings - Reuses Koha::SearchEngine::Elasticsearch::raw_elasticsearch_mappings - Registers 'application/yaml' MIME type in Koha::REST::V1 - Permission: manage_search_engine_config To test: 1. Apply this patch 2. Rebuild the API bundle: $ yarn api:bundle 3. Restart Plack 4. Run: $ prove t/db_dependent/api/v1/config_search_mappings.t => SUCCESS: Tests pass 5. Test manually: $ curl -u user:pass /api/v1/config/search_mappings => SUCCESS: Returns JSON with search field mappings $ curl -u user:pass -H 'Accept: application/yaml' \ /api/v1/config/search_mappings => SUCCESS: Returns YAML output $ curl -u user:pass /api/v1/config/search_mappings?type=marc21 => SUCCESS: Only marc21 mappings are returned 6. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #33 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 195906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195906&action=edit Bug 22639: Add export mappings button to mappings page This patch adds an 'Export mappings' button to the Elasticsearch mappings configuration page. It triggers a YAML download of the current search field mappings using the new API endpoint. To test: 1. Apply this patch (and the previous API endpoint patch) 2. Navigate to Administration > Search engine configuration => SUCCESS: An 'Export mappings' button appears next to 'Reset mappings' 3. Click 'Export mappings' => SUCCESS: A 'search_mappings.yaml' file is downloaded 4. Verify the YAML file contains the expected mappings structure => SUCCESS: File contains search fields grouped by index 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Bug 22639 depends on bug 22994, which changed state. Bug 22994 Summary: Elasticsearch ability import mappings and facets settings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22994 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22994 Depends on|22994 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22994 [Bug 22994] Elasticsearch ability import mappings and facets settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195853|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195906|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #34 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 195939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195939&action=edit Bug 22639: Add GET /config/search_mappings endpoint This patch adds a new API endpoint to retrieve the search field mappings configuration (search fields and their MARC mappings, grouped by index). The endpoint supports content negotiation: - application/json (default) - application/yaml (for export/import compatibility) An optional 'type' query parameter allows filtering mappings by MARC type (marc21 or unimarc). Implementation notes: - New controller: Koha::REST::V1::Config::SearchMappings - Reuses Koha::SearchEngine::Elasticsearch::raw_elasticsearch_mappings - Registers 'application/yaml' MIME type in Koha::REST::V1 - Permission: manage_search_engine_config To test: 1. Apply this patch 2. Rebuild the API bundle: $ yarn api:bundle 3. Restart Plack 4. Run: $ prove t/db_dependent/api/v1/config_search_mappings.t => SUCCESS: Tests pass 5. Test manually: $ curl -u user:pass /api/v1/config/search_mappings => SUCCESS: Returns JSON with search field mappings $ curl -u user:pass -H 'Accept: application/yaml' \ /api/v1/config/search_mappings => SUCCESS: Returns YAML output $ curl -u user:pass /api/v1/config/search_mappings?type=marc21 => SUCCESS: Only marc21 mappings are returned 6. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #35 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 195940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195940&action=edit Bug 22639: Add export mappings button to mappings page This patch adds an 'Export mappings' button to the Elasticsearch mappings configuration page. It triggers a YAML download of the current search field mappings using the new API endpoint. To test: 1. Apply this patch (and the previous API endpoint patch) 2. Navigate to Administration > Search engine configuration => SUCCESS: An 'Export mappings' button appears next to 'Reset mappings' 3. Click 'Export mappings' => SUCCESS: A 'search_mappings.yaml' file is downloaded 4. Verify the YAML file contains the expected mappings structure => SUCCESS: File contains search fields grouped by index 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195939|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195940|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #36 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 196125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196125&action=edit Bug 22639: Add GET /config/search_mappings endpoint This patch adds a new API endpoint to retrieve the search field mappings configuration (search fields and their MARC mappings, grouped by index). The endpoint supports content negotiation: - application/json (default) - application/yaml (for export/import compatibility) An optional 'type' query parameter allows filtering mappings by MARC type (marc21 or unimarc). Implementation notes: - New controller: Koha::REST::V1::Config::SearchMappings - Reuses Koha::SearchEngine::Elasticsearch::raw_elasticsearch_mappings - Registers 'application/yaml' MIME type in Koha::REST::V1 - Permission: manage_search_engine_config To test: 1. Apply this patch 2. Rebuild the API bundle: $ yarn api:bundle 3. Restart Plack 4. Run: $ prove t/db_dependent/api/v1/config_search_mappings.t => SUCCESS: Tests pass 5. Test manually: $ curl -u user:pass /api/v1/config/search_mappings => SUCCESS: Returns JSON with search field mappings $ curl -u user:pass -H 'Accept: application/yaml' \ /api/v1/config/search_mappings => SUCCESS: Returns YAML output $ curl -u user:pass /api/v1/config/search_mappings?type=marc21 => SUCCESS: Only marc21 mappings are returned 6. Sign off :-D Signed-off-by: Laurence <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #37 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 196126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196126&action=edit Bug 22639: Add export mappings button to mappings page This patch adds an 'Export mappings' button to the Elasticsearch mappings configuration page. It triggers a YAML download of the current search field mappings using the new API endpoint. To test: 1. Apply this patch (and the previous API endpoint patch) 2. Navigate to Administration > Search engine configuration => SUCCESS: An 'Export mappings' button appears next to 'Reset mappings' 3. Click 'Export mappings' => SUCCESS: A 'search_mappings.yaml' file is downloaded 4. Verify the YAML file contains the expected mappings structure => SUCCESS: File contains search fields grouped by index 5. Sign off :-D Signed-off-by: Laurence <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Laurence Rault <laurence.rault@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laurence.rault@biblibre.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |domm@plix.at --- Comment #38 from Thomas Klausner <domm@plix.at> --- *** Bug 39548 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |domm@plix.at -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #39 from Thomas Klausner <domm@plix.at> --- Everything works as described in the plan, very nice! (Small side note, but that's something for another bug: The exported yaml file does not exactly match what's in admin/searchengine/elasticsearch/mappings.yaml (because each entry in the exported yaml has a "filter: ''" that's not there in the default file)) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196125|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196126|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #40 from Thomas Klausner <domm@plix.at> --- Created attachment 196433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196433&action=edit Bug 22639: Add GET /config/search_mappings endpoint This patch adds a new API endpoint to retrieve the search field mappings configuration (search fields and their MARC mappings, grouped by index). The endpoint supports content negotiation: - application/json (default) - application/yaml (for export/import compatibility) An optional 'type' query parameter allows filtering mappings by MARC type (marc21 or unimarc). Implementation notes: - New controller: Koha::REST::V1::Config::SearchMappings - Reuses Koha::SearchEngine::Elasticsearch::raw_elasticsearch_mappings - Registers 'application/yaml' MIME type in Koha::REST::V1 - Permission: manage_search_engine_config To test: 1. Apply this patch 2. Rebuild the API bundle: $ yarn api:bundle 3. Restart Plack 4. Run: $ prove t/db_dependent/api/v1/config_search_mappings.t => SUCCESS: Tests pass 5. Test manually: $ curl -u user:pass /api/v1/config/search_mappings => SUCCESS: Returns JSON with search field mappings $ curl -u user:pass -H 'Accept: application/yaml' \ /api/v1/config/search_mappings => SUCCESS: Returns YAML output $ curl -u user:pass /api/v1/config/search_mappings?type=marc21 => SUCCESS: Only marc21 mappings are returned 6. Sign off :-D Signed-off-by: Laurence <laurence.rault@biblibre.com> Signed-off-by: Thomas Klausner <domm@plix.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #41 from Thomas Klausner <domm@plix.at> --- Created attachment 196434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196434&action=edit Bug 22639: Add export mappings button to mappings page This patch adds an 'Export mappings' button to the Elasticsearch mappings configuration page. It triggers a YAML download of the current search field mappings using the new API endpoint. To test: 1. Apply this patch (and the previous API endpoint patch) 2. Navigate to Administration > Search engine configuration => SUCCESS: An 'Export mappings' button appears next to 'Reset mappings' 3. Click 'Export mappings' => SUCCESS: A 'search_mappings.yaml' file is downloaded 4. Verify the YAML file contains the expected mappings structure => SUCCESS: File contains search fields grouped by index 5. Sign off :-D Signed-off-by: Laurence <laurence.rault@biblibre.com> Signed-off-by: Thomas Klausner <domm@plix.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds an release notes| |'Export mappings' button to | |the Elasticsearch mappings | |configuration page to | |download the current search | |field mappings as YAML. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #42 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #43 from Fridolin Somers <fridolin.somers@biblibre.com> --- Oh this looks strange : --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt @@ -18,9 +18,9 @@ cursor: pointer; } </style> -</head> +<!--</head>--> -<body id="admin_searchengine_mappings" class="admin"> +<!--<body id="admin_searchengine_mappings" class="admin">--> [% WRAPPER 'header.inc' %] [% INCLUDE 'prefs-admin-search.inc' %] [% END %] Is it a mistake ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Elasticsearch ability |Ability to export |export mappings and facets |Elasticsearch mappings and |settings |facets settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 --- Comment #44 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Fridolin Somers from comment #43)
Oh this looks strange :
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/ mappings.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/ mappings.tt @@ -18,9 +18,9 @@ cursor: pointer; } </style> -</head> +<!--</head>-->
-<body id="admin_searchengine_mappings" class="admin"> +<!--<body id="admin_searchengine_mappings" class="admin">--> [% WRAPPER 'header.inc' %] [% INCLUDE 'prefs-admin-search.inc' %] [% END %]
Is it a mistake ?
Bad rebase at some point, sorry! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #45 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org