[Bug 42707] New: Malformed Bootstrap dropdown in reports output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42707 Bug ID: 42707 Summary: Malformed Bootstrap dropdown in reports output Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 35402 If you run a report which returns a patron barcode column clicking a barcode in the results triggers a Bootstrap dropdown (actually a dropup) with a "Check out" link. The dropup is malformed because it lacks a "dropdown-item" class. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42707 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42707 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff Sponsorship status|--- |Sponsored Comma delimited| |Athens County Public list of Sponsors| |Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42707 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199615&action=edit Bug 42707: Malformed Bootstrap dropdown in reports output This patch updates the SQL report results markup in order to make sure Bootstrap dropdowns are formatted correctly. To test, apply the patch and locate or create a report which returns patron card number, e.g. SELECT cardnumber, borrowernumber FROM borrowers LIMIT 10 In the results, test the menus triggered when you click a card number or a borrowernumber. The menu in the cardnumber column should be formatted like the menu for borrowernumber. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42707 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42707 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199615|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42707 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 199633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199633&action=edit Bug 42707: Malformed Bootstrap dropdown in reports output This patch updates the SQL report results markup in order to make sure Bootstrap dropdowns are formatted correctly. To test, apply the patch and locate or create a report which returns patron card number, e.g. SELECT cardnumber, borrowernumber FROM borrowers LIMIT 10 In the results, test the menus triggered when you click a card number or a borrowernumber. The menu in the cardnumber column should be formatted like the menu for borrowernumber. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42707 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 199634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199634&action=edit Screenshots - Before and after -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42707 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42707 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199633|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42707 --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 199680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199680&action=edit Bug 42707: Malformed Bootstrap dropdown in reports output This patch updates the SQL report results markup in order to make sure Bootstrap dropdowns are formatted correctly. To test, apply the patch and locate or create a report which returns patron card number, e.g. SELECT cardnumber, borrowernumber FROM borrowers LIMIT 10 In the results, test the menus triggered when you click a card number or a borrowernumber. The menu in the cardnumber column should be formatted like the menu for borrowernumber. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42707 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the formatting release notes| |of the patron card number | |(cardnumber) column in | |reports. It now uses the | |"dropdown-item" class and | |is formatted the same as | |other dropdown lists, such | |as borrowernumber. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42707 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42707 --- Comment #5 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42707 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42707 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.02 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org