https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26659 CC| |joonas.kylmala@helsinki.fi --- Comment #3 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Let me come back to this later but I'm pretty sure we cannot do this because (at least how the parameter is used in the bug 28013) it wouldn't follow circulation rules. We have libraries intentionally defining the amounts of holds a patron in a specific patron category and in a specific library can do to a specific item type. See also Bug 26659. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- (In reply to Nick Clemens from comment #4)

(In reply to Joonas Kylmälä from comment #3)

...

Let me come back to this later but I'm pretty sure we cannot do this because (at least how the parameter is used in the bug 28013) it wouldn't follow circulation rules. We have libraries intentionally defining the amounts of holds a patron in a specific patron category and in a specific library can do to a specific item type. See also Bug 26659.

I see what you are saying, the way I understand it is this: In CanBookBeRenewed we call CanItemBeReserved to see if the item could fill the reserve

Those are two different questions:

CanItemBeReserved answers the question: "Can the patron place a hold on this item?"

What we are asking in CanBookBeRenewed is: "Can this item fill any hold for this patron?"

In the first question the number of holds the patron currently has should be taken into account as the end result would be adding one more

In the second question the number of holds don't matter, because we will not add any holds, we just want to know if we can fill the hold

The other solution is two subroutines: CanItemBeReserved CanItemFillHold

Note: We do have Koha::Holds->get_items_that_can_fill, however, that leaves out checks on transfer limits and counts of holds

Interesting. I see now you added the condition

&& (!$params->{ignore_hold_counts} || $allowedreserves == 0 )

so it still keeps follows the circulation rules also when allowedreserves rules is 0. Maybe doing the check on also how many hold requests the patron has to the biblio or item is not relevant here as you said. However, I think this patch should also skip the itemAlreadyOnHold return value for this to work on item-level holds as well, could you please re-do the patch? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 119220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119220&action=edit Bug 28078: (follow-up) Add param check to 'itemAlreadyOnHold' test -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 --- Comment #8 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 119264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119264&action=edit Bug 28078: (follow-up) Add param check to 'itemAlreadyOnHold' test Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- + should not check if there are too many holds as we only csre about reservability Is it a typo for "care" ? This is more enhancement than bug no ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.06 released in| | --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.06 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28078 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.