[Bug 20157] New: Use group 'features' to decide which groups to use for group searching functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 Bug ID: 20157 Summary: Use group 'features' to decide which groups to use for group searching functionality Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Depends on: 16735, 20133 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 [Bug 20133] "Hide patron information" feature should not affect all library groups -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Instead of basing the group searches on the group name, which is an inherently touchy system, we should use the same checkbox style that Jonathan introduced for the patron limits by group feature. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71320&action=edit Bug 20157 - Use group 'features' to decide which groups to use for group searching functionality Instead of basing the group searches on the group name, which is an inherently touchy system, we should use the same checkbox style that Jonathan introduced for the patron limits by group feature. Test Plan: 1) Check to ensure existing group searches still show as they used to -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71321&action=edit Bug 20157 - Update Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71320|0 |1 is obsolete| | Attachment #71321|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71323&action=edit Bug 20157 - Use group 'features' to decide which groups to use for group searching functionality Instead of basing the group searches on the group name, which is an inherently touchy system, we should use the same checkbox style that Jonathan introduced for the patron limits by group feature. Test Plan: 1) Check to ensure existing group searches still show as they used to -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71324&action=edit Bug 20157 - Update Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71382&action=edit Bug 20157: Save the features that have been checked Previous patch forgot to modify the controller script to save the changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71383&action=edit Bug 20157: Correctly hide the features for non first level groups -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71385&action=edit Bug 20157 [QA Followup] - Fix error triggered by subgroups being added to group -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71387&action=edit Bug 20157: Group search groups together We do not actually need 2 groups, the previous feature worked for both OPAC and STAFF interface. The only difference was the "show_in_pulldown" feature. Here we are going to REMOVE this feature for ergonomic reasons. We will already have 3 features and it will surcharge the interface to add another one. Moreover the feature will have to be applied at the OPAC (and so will add lot of JS checks to keep data consistent: only useful if ft_search_groups_opac is set). Moreover it is quite easy to remove entry from the dropdown list in JavaScript. If people was really using this feature, we will re-add it, just let us know. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Attachment #71385|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 71385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71385 Bug 20157 [QA Followup] - Fix error triggered by subgroups being added to group Moved to bug 18403 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71323|0 |1 is obsolete| | Attachment #71324|0 |1 is obsolete| | Attachment #71382|0 |1 is obsolete| | Attachment #71383|0 |1 is obsolete| | Attachment #71387|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71395&action=edit Bug 20157 - Use group 'features' to decide which groups to use for group searching functionality Instead of basing the group searches on the group name, which is an inherently touchy system, we should use the same checkbox style that Jonathan introduced for the patron limits by group feature. Test Plan: 1) Check to ensure existing group searches still show as they used to Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71396&action=edit Bug 20157 - Update Schema Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71397&action=edit Bug 20157: Save the features that have been checked Previous patch forgot to modify the controller script to save the changes. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71398&action=edit Bug 20157: Correctly hide the features for non first level groups Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71399&action=edit Bug 20157: Do not display OPAC groups on the staff interface Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71400&action=edit Bug 20157: Group search groups together We do not actually need 2 groups, the previous feature worked for both OPAC and STAFF interface. The only difference was the "show_in_pulldown" feature. Here we are going to REMOVE this feature for ergonomic reasons. We will already have 3 features and it will surcharge the interface to add another one. Moreover the feature will have to be applied at the OPAC (and so will add lot of JS checks to keep data consistent: only useful if ft_search_groups_opac is set). Moreover it is quite easy to remove entry from the dropdown list in JavaScript. If people was really using this feature, we will re-add it, just let us know. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am going to push this change along with bug 16735 and bug 20133. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 Bug 20157 depends on bug 16735, which changed state. Bug 16735 Summary: Replace existing library search groups functionality with the new hierarchical groups system https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 Bug 20157 depends on bug 20133, which changed state. Bug 20133 Summary: "Hide patron information" feature should not affect all library groups https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |nick@bywatersolutions.com Status|Pushed to Master |RESOLVED --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Enhancement, not backported to stable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21910 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21910 [Bug 21910] Koha::Library::Groups->get_search_groups should return the groups, not the children -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org