http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12965 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #1 from Marc Véron <veron@veron.ch> --- Confirmed for current master 3.19.00.000 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12965 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Status|NEW |Needs Signoff Severity|critical |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12965 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40928|0 |1 is obsolete| | --- Comment #3 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 40942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40942&action=edit Bug 12965: Prevent to erase an existing item type Tested: Works well, no errors -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12965 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14520 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12965 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40942|0 |1 is obsolete| | --- Comment #4 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 41456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41456&action=edit Bug 12965: Prevent to erase an existing item type On creating an item type, if it already exists, it will replace the existing one. This patch prevent that and display a message to the interface. Note: The fields are lost. Test plan: 1/ Create an item type 'AAA', description 'AAA' 2/ Edit it, update the description with 'BBB' 3/ Create an item type 'AAA' with a description 'CCC' => you should get a warning "already exists". Works well, no errors Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12965 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41456|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 42181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42181&action=edit [PASSED QA] Bug 12965: Prevent to erase an existing item type On creating an item type, if it already exists, it will replace the existing one. This patch prevent that and display a message to the interface. Note: The fields are lost. Test plan: 1/ Create an item type 'AAA', description 'AAA' 2/ Edit it, update the description with 'BBB' 3/ Create an item type 'AAA' with a description 'CCC' => you should get a warning "already exists". Works well, no errors Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Warning message is triggered. Adding, editing and deleting item types still works. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12965 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.4 -- You are receiving this mail because: You are watching all bug changes.