http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11872 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25720 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25720&action=edit Bug 11872 - Lost overdue items should not generate fines An item can be marked as lost by longoverdue.pl, but left checked out to the patron. In this case, the item will continue to accrue fines. Test Plan: 1) Check out an item and back date it so it is overdue and should generate fines. 2) Mark the item as lost by either using longoverdue.pl, or just by setting itemlost to 1 by directly accessing the database 3) Run fines.pl 4) Note the overdue generated a fine 5) Repeat steps 1-2 6) Apply this patch 7) Run fines.pl 8) Note a fine was not generated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11872 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- *** Bug 9559 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11872 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25720|0 |1 is obsolete| | CC| |matted-34813@mypacks.net --- Comment #3 from wajasu <matted-34813@mypacks.net> --- Created attachment 25830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25830&action=edit [SIGNED-OFF] Bug 11872 - Lost overdue items should not generate fines 1-Checked out item backdated 5 months. 2-Ran longoverdue.pl --lost 90=2 --confirm to get the itemlost flag set. 3-Ran fines.pl -v to get fines accrued. (So at this point in UI I saw $146 FU fine, and $5.00 Rental.) 4-Payed fines and checked in item. 5-Applied patch. 6 Did steps 1-3 At this point only saw $5.00 Rental, but no accrued fines. Correct. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11872 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- At least one unit test is required for this change. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11872 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11872 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think Jonathan raises a good point here - we need to decide if lost items count as overdues and then treat them consistently. I tend to say they are overdue AND lost, so should still show up with your overdue items. If we want the logic in the routine, maybe it could be a parameter. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11872 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11872 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #6)

Otherwise, a routine named "Getoverdues" should return all overdues (even lost items). In this case you could remove the lost items in the 2 scripts calling this routine.

I agree, I've submitted an alternative patch that uses this path to resolution. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11872 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Srdjan Jankovic from comment #11)

I'm not saying that the patch is wrong, but can someone explain reported numbers from those scripts please. They seem to be out of sync.

Srdjan, Sorry but I don't understand your question. What do you mean by "reported numbers"? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11872 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30294|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33913&action=edit Bug 11872 - Lost overdue items should not generate fines An item can be marked as lost by longoverdue.pl, but left checked out to the patron. In this case, the item will continue to accrue fines. Test Plan: 1) Check out an item and back date it so it is overdue and should generate fines. 2) Mark the item as lost by either using longoverdue.pl, or just by setting itemlost to 1 by directly accessing the database 3) Run fines.pl 4) Note the overdue generated a fine 5) Repeat steps 1-2 6) Apply this patch 7) Run fines.pl 8) Note a fine was not generated Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11872 --- Comment #15 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- (In reply to Jonathan Druart from comment #12)

Srdjan, Sorry but I don't understand your question. What do you mean by "reported numbers"?

I do apologise, I cannot remember myself any more. I probably meant "what is the difference between fines.pl and staticfines.p, they report different numbers". But on the other hand, why would there be two scripts if they did the same thing... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11872 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33913|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 33980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33980&action=edit [PASSED QA] Bug 11872 - Lost overdue items should not generate fines An item can be marked as lost by longoverdue.pl, but left checked out to the patron. In this case, the item will continue to accrue fines. Test Plan: 1) Check out an item and back date it so it is overdue and should generate fines. 2) Mark the item as lost by either using longoverdue.pl, or just by setting itemlost to 1 by directly accessing the database 3) Run fines.pl 4) Note the overdue generated a fine 5) Repeat steps 1-2 6) Apply this patch 7) Run fines.pl 8) Note a fine was not generated Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11872 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11872 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #20 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes.