[Bug 24746] New: Duplicate id in opacheader markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24746 Bug ID: 24746 Summary: Duplicate id in opacheader markup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 22880 '<div id="opacheader">' should be removed from masthead.inc because the same markup is generated by koha_news_block. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880 [Bug 22880] Convert opacheader system preference to news block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24746 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24746 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 99709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99709&action=edit Bug 24746: Duplicate id in opacheader markup This patch removes '<div id="opacheader">' from masthead.inc because the same markup is generated by koha_news_block. To reproduce the bug, make sure there is an opacheader news block defined. Add this to the OPACUserCSS system preference: View the main page of the OPAC. You should see two blue borders around the opacheader content. Apply the patch and reload the OPAC page. There should now be only one blue border. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24746 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24745 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24746 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24746 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99709|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 99738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99738&action=edit Bug 24746: Duplicate id in opacheader markup This patch removes '<div id="opacheader">' from masthead.inc because the same markup is generated by koha_news_block. To reproduce the bug, make sure there is an opacheader news block defined. Add this to the OPACUserCSS system preference: View the main page of the OPAC. You should see two blue borders around the opacheader content. Apply the patch and reload the OPAC page. There should now be only one blue border. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested whith OPACUserCSS -> #opacheader { border: 1px solid blue; padding: 1px; } don't know the intended value but works :) Work as described following test plan, no errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24746 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wonder if this could create issues for people who have tied markup etc. to the id without having the pref filled? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24746 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24746 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99738|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 99802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99802&action=edit Bug 24746: Duplicate id in opacheader markup This patch removes '<div id="opacheader">' from masthead.inc because the same markup is generated by koha_news_block. To reproduce the bug, make sure there is an opacheader news block defined. Add this to the OPACUserCSS system preference: View the main page of the OPAC. You should see two blue borders around the opacheader content. Apply the patch and reload the OPAC page. There should now be only one blue border. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested whith OPACUserCSS -> #opacheader { border: 1px solid blue; padding: 1px; } don't know the intended value but works :) Work as described following test plan, no errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24746 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99802|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 99803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99803&action=edit Bug 24746: Duplicate id in opacheader markup This patch removes '<div id="opacheader">' from masthead.inc because the same markup is generated by koha_news_block. To reproduce the bug, make sure there is an opacheader news block defined. Add this to the OPACUserCSS system preference: View the main page of the OPAC. You should see two blue borders around the opacheader content. Apply the patch and reload the OPAC page. There should now be only one blue border. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested whith OPACUserCSS -> #opacheader { border: 1px solid blue; padding: 1px; } don't know the intended value but works :) Work as described following test plan, no errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24746 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99803|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 99804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99804&action=edit Bug 24746: Duplicate id in opacheader markup This patch removes '<div id="opacheader">' from masthead.inc because the same markup is generated by koha_news_block. To reproduce the bug, make sure there is an opacheader news block defined. Add this to the OPACUserCSS system preference: View the main page of the OPAC. You should see two blue borders around the opacheader content. Apply the patch and reload the OPAC page. There should now be only one blue border. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested whith OPACUserCSS -> #opacheader { border: 1px solid blue; padding: 1px; } don't know the intended value but works :) Work as described following test plan, no errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24746 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99804|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 99805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99805&action=edit Bug 24746: Duplicate id in opacheader markup This patch removes '<div id="opacheader">' from masthead.inc because the same markup is generated by koha_news_block. To reproduce the bug, make sure there is an opacheader news block defined. Add this to the OPACUserCSS system preference: View the main page of the OPAC. You should see two blue borders around the opacheader content. Apply the patch and reload the OPAC page. There should now be only one blue border. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested whith OPACUserCSS -> #opacheader { border: 1px solid blue; padding: 1px; } don't know the intended value but works :) Work as described following test plan, no errors. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24746 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24746 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24746 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #9 from Joy Nelson <joy@bywatersolutions.com> --- not backported 19.11.x due to dependencies -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org