[Bug 27964] New: Link to subscription in serial collections view is broken - the field subscriptionid is undefined in the subscription object.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27964 Bug ID: 27964 Summary: Link to subscription in serial collections view is broken - the field subscriptionid is undefined in the subscription object. Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: andreas.jonsson@kreablo.se QA Contact: testopia@bugs.koha-community.org The functions C4::Serials::GetSubscription and C4::Serials::GetSubscriptionsFromBiblionumber return subscriptions where subscriptionid is undefined when the subscription have no subscription history. The database queries use wildcards to include fields from a left joined table. subscriptionhistory.subscriptionid will be NULL, which might be the value choosen as the field subscriptionid. How the field is chosen may depend on the version of DBI as this problem was discovered after an upgrade to Ubuntu Focal Fossa from Bionic Beaver. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27964 --- Comment #1 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 118291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118291&action=edit Bug 27964: Don't use wildcards for subscriptionhistory table in subscription queries -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27964 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Andreas, could you please include a test plan and problem description in your commit message? Should this be Needs Signoff? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27964 Janet McGowan <janet.mcgowan@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27964 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust@univ-lyo | |n2.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27964 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can confirm this for 20.11, have to retest on master still. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27964 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #2)
Hi Andreas, could you please include a test plan and problem description in your commit message? Should this be Needs Signoff?
Katrin's questions still await a response! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27964 --- Comment #5 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- I think it is hard to come up with a test plan for this issue. But it is obviously a problem that if several columns with the same name is included the resulting rows will not be well defined when fetched as hashes. I know that there is code that crashes when the subscriptionhistory entry is missing. This patch do not fix all problems, however. The real problem is that the database schema is flawed. The history table should, if designed according to normal database principles, contain one entry per historic number. But it seem to be designed to always contain exactly one entry that that enumerates the historic numbers in one attribute. However, deletes in the biblio table cascades to the subscriptionhistory table, so the subscriptionhistory entry can be missing. Note that the biblionumber in the history entry may be different from the biblionumber in the subscription. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27964 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9121 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org