[Bug 18906] New: Superlibrarian and budget_manage_all users should always see all funds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18906 Bug ID: 18906 Summary: Superlibrarian and budget_manage_all users should always see all funds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org If you have the superlibrarian or budget_manage_all permission you should be able to see all funds at all times - otherwise it's not possible to centrally manage and edit funds in a multi-branch system. Also, if someone logged themselves out from a fund by wrong configuration, users with those permissions need to be able to fix it. To test: - Make sure your user has superlibrarian permission - Go into acquisisitions - Create a new budget - Create a new fund - set library to 'not your home library' - set restricted to 'owner, users and library' - Verify that after saving the fund, you can no longer access it. - Change your home branch - log out and log in again - Verify you can now see the fund Repeat with all acq permissions including budget_manage_all - you will also experience that you are logged out from accessing the fund you created. Note: visibility on the acq start page will work correctly in these scenarios. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18906 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18906 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64874&action=edit Bug 18906: Display all funds the logged in user can use There are complex conditions to know if a librarian can use a fund, we cannot do that with a SQL query, we need to use C4::Budgets::CanUserUseBudget -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18906 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I do not provide a test plan as I am not sure what is the expected behaviours. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18906 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18906 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64874|0 |1 is obsolete| | --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 65288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65288&action=edit Bug 18906: Display all funds the logged in user can use There are complex conditions to know if a librarian can use a fund, we cannot do that with a SQL query, we need to use C4::Budgets::CanUserUseBudget When this patch is applied then all funds are visible to both superlibrarian patrons and patrons with all acq permissions Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18906 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18906 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65288|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65361&action=edit Bug 18906: Display all funds the logged in user can use There are complex conditions to know if a librarian can use a fund, we cannot do that with a SQL query, we need to use C4::Budgets::CanUserUseBudget When this patch is applied then all funds are visible to both superlibrarian patrons and patrons with all acq permissions Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18906 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Permissions could be more thought out, but this ensures that superlibrarians and users that can manage_all_budgets can access any fund to correct permissions/add users/etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18906 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18906 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.04. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18906 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.12. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18906 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #9 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.17 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org