[Bug 19028] New: Add 'shelving location' to holdings table in detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19028 Bug ID: 19028 Summary: Add 'shelving location' to holdings table in detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Bug 16759 adds a simpler way to customize what columns are displayed on the holdings table in the OPAC detail view. It would be desired to allow moving the shelving location from below the library name, into its own column. This should be done in a way that preserves current behaviour. This can easily achieved by introducing a new syspref. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19028 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |tomascohen@gmail.com Change sponsored?|--- |Sponsored Depends on| |16759 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 [Bug 16759] Make opac holdings table configurable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19028 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 65480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65480&action=edit Bug 19028: Add OPACLocationOnDetail syspref This patch renames the 'OpacLocationBranchToDisplayShelving' syspref into 'OPACLocationOnDetail' and adds it a fourth option, 'column', that makes the OPAC display shelving location on a separate column, instead of the library names (home, holding or both). Sponsored-by: Dover -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19028 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 65481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65481&action=edit Bug 19028: Add 'shelving location' to holdings table in detail page This patch adds the option to show shelving locations on a separate column. This is controlled by a new syspref, 'OPACLocationOnDetail', which replaces 'OpacLocationBranchToDisplayShelving', adding a conveniente 'column' option. The new 'Shelving location' column is conveniently added to the columns configuration entry added by bug 16759 for this purpose. The current behaviour is preserved. To test: - Apply this patches - Run the upgrade: $ sudo koha-shell kohadev k$ cd kohaclone k$ perl installer/data/mysql/updatedatabase.pl => SUCCESS: Upgrade doesn't fail - Have an item with shelving location set to something not void - Have the item set home and holding libraries for testing purposes. - Set 'OpacLocationBranchToDisplay' to 'home and holding libraries' [*] - Visit the OPAC detail page for the record containing the item => SUCCESS: Both home and holding libraries are displayed. - Loop through all OPACLocationOnDetail options (except from 'column', we leave it for later). => SUCCESS: Works as expected. - Go to Administration > Columns settings - Make item_shelving_location available in the OPAC section - Reload the OPAC detail page => SUCCESS: No change - Set OPACLocationOnDetail to 'on a separate column' - Reload the OPAC detail page => SUCCESS: Shelving location is displayed on a separate column - Sign off :-D Sponsored-by: Dover [*] For testing purposes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19028 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org, | |wizzyrea@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19028 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65480|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 65516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65516&action=edit Bug 19028: Add OpacLocationOnDetail syspref This patch renames the 'OpacLocationBranchToDisplayShelving' syspref into 'OpacLocationOnDetail' and adds it a fourth option, 'column', that makes the OPAC display shelving location on a separate column, instead of the library names (home, holding or both). Sponsored-by: Dover -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19028 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65481|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 65517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65517&action=edit Bug 19028: Add 'shelving location' to holdings table in detail page This patch adds the option to show shelving locations on a separate column. This is controlled by a new syspref, 'OpacLocationOnDetail', which replaces 'OpacLocationBranchToDisplayShelving', adding a conveniente 'column' option. The new 'Shelving location' column is conveniently added to the columns configuration entry added by bug 16759 for this purpose. The current behaviour is preserved. To test: - Apply this patches - Run the upgrade: $ sudo koha-shell kohadev k$ cd kohaclone k$ perl installer/data/mysql/updatedatabase.pl => SUCCESS: Upgrade doesn't fail - Have an item with shelving location set to something not void - Have the item set home and holding libraries for testing purposes. - Set 'OpacLocationBranchToDisplay' to 'home and holding libraries' [*] - Visit the OPAC detail page for the record containing the item => SUCCESS: Both home and holding libraries are displayed. - Loop through all OpacLocationOnDetail options (except from 'column', we leave it for later). => SUCCESS: Works as expected. - Go to Administration > Columns settings - Make item_shelving_location available in the OPAC section - Reload the OPAC detail page => SUCCESS: No change - Set OpacLocationOnDetail to 'on a separate column' - Reload the OPAC detail page => SUCCESS: Shelving location is displayed on a separate column - Sign off :-D Sponsored-by: Dover [*] For testing purposes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19028 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19028 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65516|0 |1 is obsolete| | Attachment #65517|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 65565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65565&action=edit [SIGNED-OFF] Bug 19028: Add OpacLocationOnDetail syspref This patch renames the 'OpacLocationBranchToDisplayShelving' syspref into 'OpacLocationOnDetail' and adds it a fourth option, 'column', that makes the OPAC display shelving location on a separate column, instead of the library names (home, holding or both). Sponsored-by: Dover Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19028 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 65566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65566&action=edit [SIGNED-OFF] Bug 19028: Add 'shelving location' to holdings table in detail page This patch adds the option to show shelving locations on a separate column. This is controlled by a new syspref, 'OpacLocationOnDetail', which replaces 'OpacLocationBranchToDisplayShelving', adding a conveniente 'column' option. The new 'Shelving location' column is conveniently added to the columns configuration entry added by bug 16759 for this purpose. The current behaviour is preserved. To test: - Apply this patches - Run the upgrade: $ sudo koha-shell kohadev k$ cd kohaclone k$ perl installer/data/mysql/updatedatabase.pl => SUCCESS: Upgrade doesn't fail - Have an item with shelving location set to something not void - Have the item set home and holding libraries for testing purposes. - Set 'OpacLocationBranchToDisplay' to 'home and holding libraries' [*] - Visit the OPAC detail page for the record containing the item => SUCCESS: Both home and holding libraries are displayed. - Loop through all OpacLocationOnDetail options (except from 'column', we leave it for later). => SUCCESS: Works as expected. - Go to Administration > Columns settings - Make item_shelving_location available in the OPAC section - Reload the OPAC detail page => SUCCESS: No change - Set OpacLocationOnDetail to 'on a separate column' - Reload the OPAC detail page => SUCCESS: Shelving location is displayed on a separate column - Sign off :-D Sponsored-by: Dover [*] For testing purposes Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19028 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19028 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65565|0 |1 is obsolete| | Attachment #65566|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 68466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68466&action=edit Bug 19028: Add OpacLocationOnDetail syspref This patch renames the 'OpacLocationBranchToDisplayShelving' syspref into 'OpacLocationOnDetail' and adds it a fourth option, 'column', that makes the OPAC display shelving location on a separate column, instead of the library names (home, holding or both). Sponsored-by: Dover Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19028 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 68467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68467&action=edit Bug 19028: Add 'shelving location' to holdings table in detail page This patch adds the option to show shelving locations on a separate column. This is controlled by a new syspref, 'OpacLocationOnDetail', which replaces 'OpacLocationBranchToDisplayShelving', adding a conveniente 'column' option. The new 'Shelving location' column is conveniently added to the columns configuration entry added by bug 16759 for this purpose. The current behaviour is preserved. To test: - Apply this patches - Run the upgrade: $ sudo koha-shell kohadev k$ cd kohaclone k$ perl installer/data/mysql/updatedatabase.pl => SUCCESS: Upgrade doesn't fail - Have an item with shelving location set to something not void - Have the item set home and holding libraries for testing purposes. - Set 'OpacLocationBranchToDisplay' to 'home and holding libraries' [*] - Visit the OPAC detail page for the record containing the item => SUCCESS: Both home and holding libraries are displayed. - Loop through all OpacLocationOnDetail options (except from 'column', we leave it for later). => SUCCESS: Works as expected. - Go to Administration > Columns settings - Make item_shelving_location available in the OPAC section - Reload the OPAC detail page => SUCCESS: No change - Set OpacLocationOnDetail to 'on a separate column' - Reload the OPAC detail page => SUCCESS: Shelving location is displayed on a separate column - Sign off :-D Sponsored-by: Dover [*] For testing purposes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19028 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Why do we have item_shelving_location hidden by default? If you set OpacLocationOnDetail="on a separate column", it will not be displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19028 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #9)
Why do we have item_shelving_location hidden by default? If you set OpacLocationOnDetail="on a separate column", it will not be displayed.
The idea was to keep the current behaviour, plus adding the option to display on a separate column. What's missing on this patchset, is an explanation on the syspref description, stating that it is not enough to choose 'on a separate column', enabling the colum in the columns settings is required for it to take effect. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19028 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 68535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68535&action=edit Bug 19028: Add a note to the pref description The idea was to keep the current behaviour, plus adding the option to display on a separate column. We need an explanation on the syspref description, stating that it is not enough to choose 'on a separate column', enabling the colum in the columns settings is required for it to take effect. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19028 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19028 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org