[Bug 33024] New: Lazy load the components in the routes definition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33024 Bug ID: 33024 Summary: Lazy load the components in the routes definition Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com CC: jonathan.druart+koha@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, pedro.amorim@ptfs-europe.com In routes/erm.js we should lazy load the components https://vuejs.org/guide/components/async.html -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33024 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major CC| |julian.maurice@biblibre.com | |, | |matt.blenkinsop@ptfs-europe | |.com, | |paul.derscheid@lmscloud.de Keywords| |rel_24_05_candidate --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- I didn't manage to provide a good solution for this problem. Can I get some help on this one please? I think it must be fixed for 24.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33024 --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 165357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165357&action=edit Bug 33024: (DO NOT PUSH): Test example Apply patch, run yarn js:build The AgreementsShow and AgreementsFormAdd components are bundled separately, AgreementsList isn't but maybe that is an issue with it being the parent route? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33024 --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Looking at this page it says not to use async components for routes: https://router.vuejs.org/guide/advanced/lazy-loading.html The test patch uses the method above - if you run yarn build you can see two of the Agreements routes are bundled separately. AgreementsList isn't but I think this might be because it is the parent route for the agreement components? Just an example for discussion for now, this may not be what you were looking for -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33024 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36674 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- I actually commented on the wrong bug, but thanks Matt for your patch! I meant... a bug that I hadn't opened yet! But it exists now, see bug 36674! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33024 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33024 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Confused.. what's the current state of this one then? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33024 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Nice one, Matt. I wonder if this should be an umbrella bug and individual reports could look at using the lazy loading for a small group of components? Or are we still looking into why AgreementsList isn't bundled separately? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org