http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 40748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40748&action=edit Bug 14484: Silences warns triggered when changing patron password Use of uninitialized value $roadtype To test: 1) Go to any patron's page, click Change password 2) Notice warns in error log 3) Apply patch, reload page 4) Click Change password 5) Notice warns are gone and page still works correctly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- I'd suggest my $roadtype = C4::Koha::GetAuthorisedValueByCode( 'ROADTYPE', $bor->{streettype} ) // ''; -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 --- Comment #3 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 41095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41095&action=edit Bug 14484: Jonathan Druart's fix To test: 1) Go to any patron's page, click Change password 2) Notice warns in error log 3) Apply patch, reload page 4) Click Change password 5) Notice warns are gone and page still works correctly -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mirko@abunchofthings.net --- Comment #4 from Mirko Tietgen <mirko@abunchofthings.net> --- I get an error when I try to apply the patch:

Applying: Bug 14484: Jonathan Druart's fix fatal: sha1 information is lacking or useless (members/member-password.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 14484: Jonathan Druart's fix

It looks like the second patch modifies the first one, so 1) the first patch should not be obsoleted OR 2) the second one should be done against master without the first in between the second being the better option. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 --- Comment #5 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 41454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41454&action=edit Bug 14484: warns when changing patron pw To test: 1) Go to any patron's page, click Change password 2) Notice warns in error log 3) Apply patch, reload page 4) Click Change password 5) Notice warns are gone and page still works correctly -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Mirko Tietgen <mirko@abunchofthings.net> --- Sorry, but the new attachment looks the same as the one before (and I get the same error) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41454|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 41487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41487&action=edit Bug 14484: warns when changing patron pw To test: 1) Go to any patron's page, click Change password 2) Notice warns in error log 3) Apply patch, reload page 4) Click Change password 5) Notice warns are gone and page still works correctly -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41487|0 |1 is obsolete| | --- Comment #8 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 41495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41495&action=edit Bug 14484: warns when changing patron pw Warning disappears, code looks good. Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41495|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41603&action=edit Bug 14484: warns when changing patron pw To test: 1) Go to any patron's page, click Change password 2) Notice warns in error log 3) Apply patch, reload page 4) Click Change password 5) Notice warns are gone and page still works correctly Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.