[Bug 40949] New: Bookings to collect shouldn't tell staff to check in items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40949 Bug ID: 40949 Summary: Bookings to collect shouldn't tell staff to check in items Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: aude.charillon@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Depends on: 33736 On the Bookings to collect page (pendingbookings.pl), under the headers is the text: "The following items have not been collected for bookings. Please retrieve them and check them in." The second sentence does not make sense: checking items is relevant for holds but bookings do not need to be checked in. The second sentence should be removed on this page - or updated to something relevant to bookings. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 [Bug 33736] Add bookings to collect circulation report -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40949 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Circulation| |Bookings function| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40949 Bug 40949 depends on bug 33736, which changed state. Bug 33736 Summary: Add bookings to collect circulation report https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40949 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de --- Comment #1 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Just found this as well, patch incoming. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40949 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40949 --- Comment #2 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 190074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190074&action=edit Bug 40949: Remove second sentence of guidance text on Bookings to Collect page - We don't need it since we don't have to trigger anything by checkin like we do with holds - The first sentence already communicates all relevant information -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40949 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40949 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190074|0 |1 is obsolete| | --- Comment #3 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 190377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190377&action=edit Bug 40949: Remove second sentence of guidance text on Bookings to Collect page - We don't need it since we don't have to trigger anything by checkin like we do with holds - The first sentence already communicates all relevant information Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40949 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Aude Charillon <aude.charillon@openfifth.co.uk> --- Works as described: the message now only says "The following items have not been collected for bookings." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40949 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40949 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190377|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 190471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190471&action=edit Bug 40949: Remove second sentence of guidance text on Bookings to Collect page - We don't need it since we don't have to trigger anything by checkin like we do with holds - The first sentence already communicates all relevant information Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40949 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Version|unspecified |Main Assignee|koha-bugs@lists.koha-commun |paul.derscheid@lmscloud.de |ity.org | QA Contact|testopia@bugs.koha-communit |david@davidnind.com |y.org | Text to go in the| |This removes the sentence release notes| |"Please retrieve them and | |check them in." from the | |bookings to collect page | |(Circulation > Holds and | |bookings > Bookings to | |collect). This is not | |required, as checking in | |items is not relevant for | |bookings. --- Comment #6 from David Nind <david@davidnind.com> --- Passed QA. QA script happy. Added assigned and a release note. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40949 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40949 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40949 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40949 --- Comment #8 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40949 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Minor, lets skip for 25.05.x backport. Also avoids translation work :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org