[Bug 19796] New: [16.11] Subscription info appears doubled up on OPAC detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19796 Bug ID: 19796 Summary: [16.11] Subscription info appears doubled up on OPAC detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: chris@bigballofwax.co.nz, colin.campbell@ptfs-europe.com When bug 18754 was merged into 16.11 a little mistake crept in. The "Subscripiton from: ..." line now appears twice on the subscription tab on the OPAC detail page. 823 [% END %] 824 <p>Subscription from: [% subscription.histstartdate | $KohaDates %] to:[% IF ( subscription.histenddate ) %] [% subscription.histenddate | $KohaDates %] [% ELSE %] now (current)[% END %]</p> 825 <p class="subscription_dates">Subscription from: [% subscription.histstartdate | $KohaDates %] to:[% IF ( subscription.histenddate ) %] [% subscription.histenddate | $KohaDates %] [% ELSE %] now (current)[% END %]</p> 826 [% IF ( subscription.missinglist ) %] This is where the mistake happened: http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b0d86d104438... Problem is in 16.11 only, doesn't appear in 17.05 and up. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19796 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |16.11 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19796 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19796 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19796 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 69705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69705&action=edit Bug 19796 - Fix doubled up subscription info on OPAC detail page The info "Subscription from..." is showing twice on the subscription tab on the OPAC detail page because of a bad merge. This patch removes the doubled up information. To test: - Add a subscription - Search for the record in the OPAC - Switch to the subscription tab - Verify that the 'Subscription from...' line is repeated - Apply patch - Verify only one line remains and nothing is missing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19796 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19796 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69705|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 69932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69932&action=edit Bug 19796 - Fix doubled up subscription info on OPAC detail page The info "Subscription from..." is showing twice on the subscription tab on the OPAC detail page because of a bad merge. This patch removes the doubled up information. To test: - Add a subscription - Search for the record in the OPAC - Switch to the subscription tab - Verify that the 'Subscription from...' line is repeated - Apply patch - Verify only one line remains and nothing is missing Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19796 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looks good to me. Moving to Stable status -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19796 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19796 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19796 --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 16.11.x will be in 16.11.15 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org