https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105236|0 |1 is obsolete| | --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 105237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105237&action=edit Bug 25560: Database and installer changes -- Adds boolean flag itemtypes.updatenotforloanstatusoncheckin Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 105239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105239&action=edit Bug 25560: Updated schema file Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #6 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 105241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105241&action=edit Bug 25560: Exclude itemtypes from UpdateNotForLoanStatusOnCheckin Sponsored-By: Waikati Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105240|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #8 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 105243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105243&action=edit Bug 25560: Exclude itemtypes from UpdateNotForLoanStatusOnCheckin Adds a boolean flag itemtypes.updatenotforloanstatusoncheckin, enabled by default. When disabled (if the UpdateNoForLoanStatusOnCheckin syspref is configured) when an item of the type if checked in the notforloan status does not update. This enhancement respects the 'item-level_itypes' syspref, so will look at the authoritative item type when determining to update the notforloan status. Test plan: 1. Paste into UpdateNotForLoanStatusOnCheckin syspref 0 : 1 2. Issue and return an item and observe the item's notforloan status updates 3. Apply patch & update database cd installer/data/mysql sudo koha-shell <instancename> ./updatedatabase.pl 4. Restart plack 5. Go to BK (Book) item type page (Administration > Item types > BK). 6. Observe the 'Update not for loan status on check-in' checkbox is selected by default. Untick it. 7. Make sure the 'item-level_itypes' syspref is set to 'specific item' 8. Issue and return a BK item (item level itype='BK') and observe item's notforloan status does not update 9. Issue and return a CR (Continuing Resources) item (item level itype='CR') and observe the item's notforloan status updates 10. Change 'item-level_itypes' syspref to 'bibliographic record' 11. Issue and return an item (with biblio-level itemtype='BK' & item-level itype='CR') and observe the item's notforloan status does not update 12. Issue and return an item (with biblio-level itemtype='CR' & item-level itype='BK') and observe the item's notforloan status updates Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105244|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105245|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105242|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105238|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #12 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 109563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109563&action=edit Bug 25560: Updated schema file Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #14 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 109565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109565&action=edit Bug 25560: Exclude itemtypes from UpdateNotForLoanStatusOnCheckin Adds a boolean flag itemtypes.updatenotforloanstatusoncheckin, enabled by default. When disabled (if the UpdateNoForLoanStatusOnCheckin syspref is configured) when an item of the type if checked in the notforloan status does not update. This enhancement respects the 'item-level_itypes' syspref, so will look at the authoritative item type when determining to update the notforloan status. Test plan: 1. Paste into UpdateNotForLoanStatusOnCheckin syspref 0 : 1 2. Issue and return an item and observe the item's notforloan status updates 3. Apply patch & update database cd installer/data/mysql sudo koha-shell <instancename> ./updatedatabase.pl 4. Restart plack 5. Go to BK (Book) item type page (Administration > Item types > BK). 6. Observe the 'Update not for loan status on check-in' checkbox is selected by default. Untick it. 7. Make sure the 'item-level_itypes' syspref is set to 'specific item' 8. Issue and return a BK item (item level itype='BK') and observe item's notforloan status does not update 9. Issue and return a CR (Continuing Resources) item (item level itype='CR') and observe the item's notforloan status updates 10. Change 'item-level_itypes' syspref to 'bibliographic record' 11. Issue and return an item (with biblio-level itemtype='BK' & item-level itype='CR') and observe the item's notforloan status does not update 12. Issue and return an item (with biblio-level itemtype='CR' & item-level itype='BK') and observe the item's notforloan status updates Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #16 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Rebased against master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #17 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 109567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109567&action=edit Bug 25560: Unit tests Test plan: 1. Run tests sudo koha-shell <instancename> prove xt prove t prove t/db_dependent/Circulation/issue.t prove t/db_dependent/Koha/Object.t Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Still applies, comes with a nice test plan, written in NZ... might be nice for DIY at KohaCon. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109567|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #21 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi David, I think I've solved the problem of t/db_dependent/Circulation/issue.t failing. Unfortunately I haven't yet been able to replicate the other failed tests you encountered ( comment #19 ) I think I'll need to ask some other members of the team if they have any ideas. Could you please re-test the unit tests again to see if the change I've made has at least fixed up the t/db_dependent/Circulation/issue.t test? Thanks, Alex -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #23 from David Nind <david@davidnind.com> --- Hi Alex. I ran the tests again, both before and after applying the patches, and running through the test plan: - prove xt: all pass both before and after patches applied, and after working through the test plan - prove t: the tests that fail are the same that fail BEFORE the patch is applied - prove t/db_dependent/Circulation/issue.t: tests pass after patches applied, tests fail after have worked through the test plan and run tests again * - prove t/db_dependent/Koha/Object.t: all pass both before and after patches applied I'm not sure how the tests that fail before the patches are applied get fixed up, but obviously not caused by the patches in this bug. David * Failed tests for prove t/db_dependent/Circulation/issue.t after patches applied and have walked through the test plan not ok 33 - UpdateNotForLoanStatusOnCheckin does not update notforloan value when itemtypes.updatenotforloanstatusoncheckin = 0 # Failed test 'UpdateNotForLoanStatusOnCheckin does not update notforloan value when itemtypes.updatenotforloanstatusoncheckin = 0' # at t/db_dependent/Circulation/issue.t line 440. not ok 50 - The reserve should have been correctly cancelled # Failed test 'The reserve should have been correctly cancelled' # at t/db_dependent/Circulation/issue.t line 529. # got: 'Koha::Hold=HASH(0x555f3aa32530)' # expected: undef # Looks like you failed 2 tests of 50. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/50 subtests Test Summary Report ------------------- t/db_dependent/Circulation/issue.t (Wstat: 512 Tests: 50 Failed: 2) Failed tests: 33, 50 Non-zero exit status: 2 Files=1, Tests=50, 6 wallclock secs ( 0.03 usr 0.01 sys + 4.84 cusr 0.38 csys = 5.26 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112492|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #26 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi David, I've attached a (hopefully!) fixed up unit tests patch. Would you mind re-testing the unit tests and see if the t/db_dependent/Circulation/issue.t test now passes for you? Many thanks, Alex -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112887|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #29 from David Nind <david@davidnind.com> --- For prove -v t/db_dependent/Circulation/issue.t 1. If I run before and after the patches are applied - all tests pass! 2. If I run after running through the test plan - test 33 fails not ok 33 - UpdateNotForLoanStatusOnCheckin does not update notforloan value when itemtypes.updatenotforloanstatusoncheckin = 0 # Failed test 'UpdateNotForLoanStatusOnCheckin does not update notforloan value when itemtypes.updatenotforloanstatusoncheckin = 0' # at t/db_dependent/Circulation/issue.t line 440. 3. If I change item-level_itypes system preference back to 'specific item' - everything passes! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #30 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 113212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113212&action=edit Bug 25560: Unit tests Test plan: 1. Run tests sudo koha-shell <instancename> prove xt prove t prove t/db_dependent/Circulation/issue.t prove t/db_dependent/Koha/Object.t Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #32 from David Nind <david@davidnind.com> --- Hi Alex. Success! Now signing off! I ran the tests again, both before and after applying the patches, and running through the test plan: - prove xt: the tests that fail are the same that fail BEFORE the patch is applied, and after working through the test plan (xt/check_makefile.t is the test that fails) - prove t: the tests that fail are the same that fail BEFORE the patch is applied, and after working through the test plan (t/Logger.t is the test that fails) - prove t/db_dependent/Circulation/issue.t: all pass both before and after patches applied, and test plan worked through (also passes with changing item-level_itypes) - prove t/db_dependent/Koha/Object.t: all pass both before and after patches applied, and test plan worked through (also passes with changing item-level_itypes) David -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109562|0 |1 is obsolete| | --- Comment #33 from David Nind <david@davidnind.com> --- Created attachment 113213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113213&action=edit Bug 25560: Database and installer changes -- Adds boolean flag itemtypes.updatenotforloanstatusoncheckin Sponsored-By: Waikato Institute of Technology, NZ Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109564|0 |1 is obsolete| | --- Comment #35 from David Nind <david@davidnind.com> --- Created attachment 113215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113215&action=edit Bug 25560: Template & syspref yaml changes Sponsored-By: Waikato Institute of Technology, NZ Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113212|0 |1 is obsolete| | --- Comment #37 from David Nind <david@davidnind.com> --- Created attachment 113217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113217&action=edit Bug 25560: Unit tests Test plan: 1. Run tests sudo koha-shell <instancename> prove xt prove t prove t/db_dependent/Circulation/issue.t prove t/db_dependent/Koha/Object.t Sponsored-By: Waikato Institute of Technology, NZ Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #39 from Nick Clemens <nick@bywatersolutions.com> --- Hi Alex, This looks good, that's a long column name :-) Few things: 1 - We should check the itemtype outside of the loop, I would actually check it before loading and parsing the pref 2 - You can use effective_itemtype to avoid the conditional, in fact there is a fetch of that in code above, so you just need to get the object 3 - I am not sure what the behvaiour should be if the itemtype isn't defined or doesn't match a defined value - just mentioning as it may error when you try to fetch the object -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113217|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113215|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113213|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #41 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 131817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131817&action=edit Bug 25560: Updated schema file Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #43 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 131819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131819&action=edit Bug 25560: Exclude itemtypes from UpdateNotForLoanStatusOnCheckin Adds a boolean flag itemtypes.updatenotforloanstatusoncheckin, enabled by default. When disabled (if the UpdateNoForLoanStatusOnCheckin syspref is configured) when an item of the type if checked in the notforloan status does not update. This enhancement respects the 'item-level_itypes' syspref, so will look at the authoritative item type when determining to update the notforloan status. Test plan: 1. Paste into UpdateNotForLoanStatusOnCheckin syspref 0 : 1 2. Issue and return an item and observe the item's notforloan status updates 3. Apply patch & update database cd installer/data/mysql sudo koha-shell <instancename> ./updatedatabase.pl 4. Restart plack 5. Go to BK (Book) item type page (Administration > Item types > BK). 6. Observe the 'Update not for loan status on check-in' checkbox is selected by default. Untick it. 7. Make sure the 'item-level_itypes' syspref is set to 'specific item' 8. Issue and return a BK item (item level itype='BK') and observe item's notforloan status does not update 9. Issue and return a CR (Continuing Resources) item (item level itype='CR') and observe the item's notforloan status updates 10. Change 'item-level_itypes' syspref to 'bibliographic record' 11. Issue and return an item (with biblio-level itemtype='BK' & item-level itype='CR') and observe the item's notforloan status does not update 12. Issue and return an item (with biblio-level itemtype='CR' & item-level itype='BK') and observe the item's notforloan status updates Sponsored-By: Waikato Institute of Technology, NZ Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #45 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Nick Clemens from comment #39)

Hi Alex,

This looks good, that's a long column name :-) Few things: 1 - We should check the itemtype outside of the loop, I would actually check it before loading and parsing the pref 2 - You can use effective_itemtype to avoid the conditional, in fact there is a fetch of that in code above, so you just need to get the object 3 - I am not sure what the behvaiour should be if the itemtype isn't defined or doesn't match a defined value - just mentioning as it may error when you try to fetch the object

Hi Nick, My apologies for my slow response! I think I've implemented your suggestions from comment #39 now. I have handled point 3 by checking if the object for the effective_itemtype is defined before fetching the updatenotforloan value. I've also shortened the column name to itemtypes.updatenotforloan, hopefully that is better too. Would you mind re-testing? Many thanks, Alex -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131820|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #47 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 135742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135742&action=edit Bug 25560: Exclude itemtypes from UpdateNotForLoanStatusOnCheckin Adds a boolean flag itemtypes.updatenotforloanstatusoncheckin, enabled by default. When disabled (if the UpdateNoForLoanStatusOnCheckin syspref is configured) when an item of the type if checked in the notforloan status does not update. This enhancement respects the 'item-level_itypes' syspref, so will look at the authoritative item type when determining to update the notforloan status. Test plan: 1. Paste into UpdateNotForLoanStatusOnCheckin syspref 0 : 1 2. Issue and return an item and observe the item's notforloan status updates 3. Apply patch & update database cd installer/data/mysql sudo koha-shell <instancename> ./updatedatabase.pl 4. Restart plack 5. Go to BK (Book) item type page (Administration > Item types > BK). 6. Observe the 'Update not for loan status on check-in' checkbox is selected by default. Untick it. 7. Make sure the 'item-level_itypes' syspref is set to 'specific item' 8. Issue and return a BK item (item level itype='BK') and observe item's notforloan status does not update 9. Issue and return a CR (Continuing Resources) item (item level itype='CR') and observe the item's notforloan status updates 10. Change 'item-level_itypes' syspref to 'bibliographic record' 11. Issue and return an item (with biblio-level itemtype='BK' & item-level itype='CR') and observe the item's notforloan status does not update 12. Issue and return an item (with biblio-level itemtype='CR' & item-level itype='BK') and observe the item's notforloan status updates Sponsored-By: Waikato Institute of Technology, NZ Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #49 from Alex Buckley <alexbuckley@catalyst.net.nz> --- This patchset is rebased against master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131816|0 |1 is obsolete| | Attachment #131817|0 |1 is obsolete| | Attachment #131818|0 |1 is obsolete| | Attachment #135742|0 |1 is obsolete| | Attachment #135743|0 |1 is obsolete| | --- Comment #50 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 136079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136079&action=edit Bug 25560: Database and installer changes -- Adds boolean flag itemtypes.updatenotforloan Sponsored-By: Waikato Institute of Technology, NZ Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #52 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 136081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136081&action=edit Bug 25560: Template & syspref yaml changes Sponsored-By: Waikato Institute of Technology, NZ Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #54 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 136083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136083&action=edit Bug 25560: Unit tests Test plan: 1. Run tests sudo koha-shell <instancename> prove xt prove t/db_dependent/Circulation/issue.t prove t/db_dependent/Koha/Object.t Sponsored-By: Waikato Institute of Technology, NZ Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #56 from Nick Clemens <nick@bywatersolutions.com> --- This works and is a relatively small change so signing off. I do think this would be better if it didn't split this control into two places: syspref and itemtype administration. The existing syspref is YAML based, and could be expanded to take itemtypes into account, and would consolidate the feature into a single control. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #58 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Nick Clemens from comment #56)

This works and is a relatively small change so signing off.

I do think this would be better if it didn't split this control into two places: syspref and itemtype administration.

The existing syspref is YAML based, and could be expanded to take itemtypes into account, and would consolidate the feature into a single control.

I've had the same thought actually. Having different places to check always makes it harder to debug any configuration issues as it's hard to keep all options in mind that might have an influence on a certain behaviour. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #60 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Katrin, Yes, I can certainly adapt this patchet. Nick and Jonathan, could you please detail how this could look? Thanks, Alex -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #61 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Just to note I have a working patchset that can use YAML defined in the UpdateNotForLoanStatusOnCheckin syspref like so: BK: -1: 0 CR: -2: 0 I am currently working on how to handle existing values in the syspref so they still apply for all itemtypes for upgrading libraries. Any suggestions would be much appreciated on this point. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136084|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136082|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136080|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #63 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 138494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138494&action=edit Bug 25560: Database changes Sponsored-by: Waikato Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #65 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 138496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138496&action=edit Bug 25560: Define item-type specific rules in UpdateNotForLoanStatusOnCheckin This enhancement respects the 'item-level_itypes' syspref, so will look at the authoritative item type when determining to update the notforloan status. Test plan: 1. Set -1 to 'Ordered', and 1 to 'Not for Loan' in Administration > Authorised values > NOT_LOAN 2. Make sure the 'item-level_itypes' syspref is set to 'specific item' 3. Add the following rules in UpdateNotForLoanStatusOnCheckin system preference: -1: 0 4. Apply patch & update database cd installer/data/mysql sudo koha-shell <instancename> ./updatedatabase.pl 5. Restart plack 6. Observe the UpdateNotForLoanStatusOnCheckin syspref values have updated to the following format: <itemtype_1>: -1: 0 <itemtype_2>: -1: 0 etc. Each item type setup in Koha has the existing rule(s) listed under it 7. Check in an 'Ordered' item of any item type and confirm it is changed to 'Available for loan' 8. Reset the UpdateNotForLoanStatusOnCheckin syspref to: BK: -1: 0 CD: 1: 0 9. Check-in an 'ordered' BK item (item level itype='BK') and observe the item's notforloan status updates 10. Check-in a 'Not for Loan' CD item (item level itype='CD') and observe the item's notforloan status updates 11. Check-in an 'ordered' DVD item (item level itype='DVD') and observe the items notforloan status does not change 12. Change 'item-level_itypes' syspref to 'bibliographic record' 13. Check-in an 'ordered' item (with biblio-level itemtype='BK' & item-level itype='DVD') and observe the item's notforloan status updates 14. Check-in an 'ordered' item (with biblio-level itemtype='DVD' & item-level itype='BK') and observe the item's notforloan status does not change Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual, | |release-notes-needed Summary|Exclude itemtypes from |Define itemtype specific |UpdateNotForLoanStatusOnChe |rules in the |ckin |UpdateNotForLoanStatusOnChe | |ckin system preference Text to go in the|Add boolean flag |The release notes|itemtypes.updatenotforloan, |UpdateNotForLoanStatusOnChe |enabled by default. |ckin system preference is | |now more flexible: you can |When |define rules to be applied |this item type flag is |to specific item types upon |disabled items of that type |check-in. |will not be updated on | |check-in. |Adding the item | |type code followed by a | |colon, and then in separate | |lines below each value pair | |rules with leading spaces. | |Example: | | | |BK | | -1: 0 | | | |If an | |item type is not defined in | |UpdateNotForLoanStatusOnChe | |ckin then items of that | |type will not have their | |notforloan status change on | |check-in, irrespective of | |their current notforloan | |value. --- Comment #67 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Nick Clemens from comment #62)

(In reply to Alex Buckley from comment #61)

...

Just to note I have a working patchset that can use YAML defined in the UpdateNotForLoanStatusOnCheckin syspref like so:

BK: -1: 0

CR: -2: 0

I am currently working on how to handle existing values in the syspref so they still apply for all itemtypes for upgrading libraries. Any suggestions would be much appreciated on this point.

Maybe add an _ALL_ option - and then existing rules can be placed under that? Similar to UpdateItemLocationOnCheckin - but probably not make _ALL_ override the other rules as it does on that pref

Thanks for that Nick. Am certainly happy to make that change if you would like. You will see in the attached patchset I have just added, that I'm listing the existing rules under each item type, like so: BK: -1: 0 CR: -1: 0 etc. The reason for this is I had a chat with Chris and we wondered whether having an _ALL_ option could create user confusion in which rule is overridden in a situation of conflicting rules, like: _ALL_: -1: 0 BK: -1: 2 By explicitly defining every item type and all rules that could apply for it, as I have in my attached patchset, it clarifies any potential confusion around rules overriding. It does, however, mean librarians will need to write a rule under every item type option for it to be applied to all items. I'm not sure if this should be 'Need signoff' so will leave it with the current setting for now. Happy to hear your thoughts though? :) Alex -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138496|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #69 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 138499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138499&action=edit Bug 25560: Unit tests Test plan: 1. Run tests sudo koha-shell <instancename> prove xt prove t/db_dependent/Circulation/issue.t Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30407 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com --- Comment #72 from Kyle M Hall <kyle@bywatersolutions.com> --- Alex, why not add a wildcard option ( say "*" )? That way, if a notforloan change applies to all itemtypes, it won't require creating a section for each and every itemtype. It should also simplify the upgrade patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #74 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---

I am working on amending my patches to do that now.

Kind regards, Alex

Hi Alex, moving this out of queue for now - please switch back to Signed-off once you are ready! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138499|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138495|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #76 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 146556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146556&action=edit Bug 25560: Database changes Sponsored-by: Waikato Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #78 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 146558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146558&action=edit Bug 25560: Define item-type specific rules in UpdateNotForLoanStatusOnCheckin This enhancement respects the 'item-level_itypes' syspref, so will look at the authoritative item type when determining to update the notforloan status. Test plan: 1. Set -1 to 'Ordered', and 1 to 'Not for Loan' in Administration > Authorised values > NOT_LOAN 2. Make sure the 'item-level_itypes' syspref is set to 'specific item' 3. Add the following rules in UpdateNotForLoanStatusOnCheckin system preference: -1: 0 4. Apply patch & update database cd installer/data/mysql sudo koha-shell <instancename> ./updatedatabase.pl 5. Restart plack 6. Observe the UpdateNotForLoanStatusOnCheckin syspref values have updated to the following format: _ALL_: -1: 0 7. Check in an 'Ordered' item of any item type and confirm it is changed to 'Available for loan' (NOT_LOAN=0) 8. Reset the UpdateNotForLoanStatusOnCheckin syspref to: _ALL_: -1: 0 CD: -1: 2 2: 0 9. Check-in an 'ordered' (NOT_LOAN=-1) CD item (item level itype='CD') and observe the item's notforloan status updates to 'Staff collection' (NOT_LOAN=2). This is because the _ALL_ rule does not override all other rules. 10. Check-in a 'Staff collection' (NOT_LOAN=2) CD item (item level itype='CD') and observe the item's notforloan status updates to 'Available for loan' (NOT_LOAN=0) 11. Check-in a 'Staff collection' (NOT_LOAN=2) DVD item (item level itype='DVD') and observe the items notforloan status does not change 12. Check-in an 'ordered' (NOT_LOAN=-1) DVD item (item level itype='DVD') and observe the items notforloan status updates to 'Available for loan' (NOT_LOAN=0) Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #80 from Alex Buckley <alexbuckley@catalyst.net.nz> --- I've attached some updated patches that use a wildcard '_ALL_' as a special term to apply for all item types. These patches are not quite ready for testing yet. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #81 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 146993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146993&action=edit Bug 25560: Unit tests Test plan: 1. Run tests sudo koha-shell <instancename> prove t/db_dependent/Circulation/issue.t Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|The |The release notes|UpdateNotForLoanStatusOnChe |UpdateNotForLoanStatusOnChe |ckin system preference is |ckin system preference is |now more flexible: you can |now more configurable: you |define rules to be applied |can define rules to be |to specific item types upon |applied to specific item |check-in. |types upon check-in. | | |Adding the item |Add |type code followed by a |the item type code followed |colon, and then in separate |by a colon, and then on |lines below each value pair |separate lines below define |rules with leading spaces. |each notforloan value pair |Example: |with leading spaces. | |Example: |BK | | -1: 0 |BK | | -1: 0 |If an | |item type is not defined in |You |UpdateNotForLoanStatusOnChe |can use an _ALL_ wildcard |ckin then items of that |to target all item types. |type will not have their |The _ALL_ wildcard does NOT |notforloan status change on |override item-type specific |check-in, irrespective of |rules. |their current notforloan |Example: |value. | | |_ALL_: | | | |-1: 2 | | | |If an item type is | |not defined in the | |UpdateNotForLoanStatusOnChe | |ckin system preference, and | |there are no _ALL_ rules | |defined, then items of that | |type will not have their | |notforloan status change on | |check-in, irrespective of | |their current notforloan | |value. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146556|0 |1 is obsolete| | Attachment #146557|0 |1 is obsolete| | Attachment #146558|0 |1 is obsolete| | Attachment #146993|0 |1 is obsolete| | --- Comment #83 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 148679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148679&action=edit Bug 25560: Database changes Sponsored-by: Waikato Institute of Technology, New Zealand Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #85 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 148681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148681&action=edit Bug 25560: Template changes Sponsored-by: Waikato Institute of Technology, New Zealand Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #87 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 148683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148683&action=edit Bug 25560: Unit tests Test plan: 1. Run tests sudo koha-shell <instancename> prove t/db_dependent/Circulation/issue.t Sponsored-By: Waikato Institute of Technology, NZ Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35692 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED Keywords|Academy, Manual, | |release-notes-needed, | |rel_23_11_candidate | CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/912 Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35292 -- You are receiving this mail because: You are watching all bug changes.