[Bug 12508] New: The removal of a contract which is linked to a basket does not display an error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12508 Bug ID: 12508 Summary: The removal of a contract which is linked to a basket does not display an error Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: yohann.dufour@biblibre.com QA Contact: testopia@bugs.koha-community.org When we delete a contract which is linked to a basket, the removal is not done but no errors is displayed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12508 Yohann Dufour <yohann.dufour@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |12493 Assignee|koha-bugs@lists.koha-commun |yohann.dufour@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12508 Yohann Dufour <yohann.dufour@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12487 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12508 Yohann Dufour <yohann.dufour@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12508 --- Comment #1 from Yohann Dufour <yohann.dufour@biblibre.com> --- Created attachment 29392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29392&action=edit Bug 12508: adding an error message if a contract cannot be removed If a contract cannot be removed, no errors is displayed. Now, it displays an dialog messag error and the list of contracts. Test plan: 1) Log on with a superlibrarian permission 2) Go on the page acqui/supplier.pl (Acquisitions > Button "New vendor") 3) Record a vendor with a nonzero "name" 4) Go on the page admin/aqcontract.pl (click on the "Contracts" item in the menu) 5) Click on the button "New" > "Contract" and record a new one 6) Click on "New" > "Basket" and record a basket by selectioning the created contract 7) Click on the contract name, then click on the "Contracts" item in the left menu 8) Try to delete this contract, an error is displayed : "Contract has not been deleted. Maybe a basket linked to this contract exists." 9) Delete the basket linked to the contract 10) Delete the contract, no errors is displayed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12508 Juhani Seppälä <jseppal@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jseppal@student.uef.fi --- Comment #2 from Juhani Seppälä <jseppal@student.uef.fi> --- Hi, I tested this first without the patch and confirmed the behaviour (usability issue). Trying to remove a contract pre-patch is pretty confusing, much clearer after this patch - I'm signing off. On succesful contract removal: would it be against the guidelines to have a success message here (e.g. "contract removed succesfully")? Currently it's a bit vague. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12508 Juhani Seppälä <jseppal@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29392|0 |1 is obsolete| | --- Comment #3 from Juhani Seppälä <jseppal@student.uef.fi> --- Created attachment 29421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29421&action=edit Bug 12508: adding an error message if a contract cannot be removed If a contract cannot be removed, no errors is displayed. Now, it displays an dialog messag error and the list of contracts. Test plan: 1) Log on with a superlibrarian permission 2) Go on the page acqui/supplier.pl (Acquisitions > Button "New vendor") 3) Record a vendor with a nonzero "name" 4) Go on the page admin/aqcontract.pl (click on the "Contracts" item in the menu) 5) Click on the button "New" > "Contract" and record a new one 6) Click on "New" > "Basket" and record a basket by selectioning the created contract 7) Click on the contract name, then click on the "Contracts" item in the left menu 8) Try to delete this contract, an error is displayed : "Contract has not been deleted. Maybe a basket linked to this contract exists." 9) Delete the basket linked to the contract 10) Delete the contract, no errors is displayed Signed-off-by: Juhani Seppälä <jseppal@student.uef.fi> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12508 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- About to test, already signed. Status changed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12508 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 29512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29512&action=edit [PASSED QA] Bug 12508: adding an error message if a contract cannot be removed If a contract cannot be removed, no errors is displayed. Now, it displays an dialog messag error and the list of contracts. Test plan: 1) Log on with a superlibrarian permission 2) Go on the page acqui/supplier.pl (Acquisitions > Button "New vendor") 3) Record a vendor with a nonzero "name" 4) Go on the page admin/aqcontract.pl (click on the "Contracts" item in the menu) 5) Click on the button "New" > "Contract" and record a new one 6) Click on "New" > "Basket" and record a basket by selectioning the created contract 7) Click on the contract name, then click on the "Contracts" item in the left menu 8) Try to delete this contract, an error is displayed : "Contract has not been deleted. Maybe a basket linked to this contract exists." 9) Delete the basket linked to the contract 10) Delete the contract, no errors is displayed Signed-off-by: Juhani Seppälä <jseppal@student.uef.fi> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes QA script an tests. Also tested adding, editing and deleting unused contracts. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12508 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 29513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29513&action=edit Bug 12508: Follow up - corrects capitalization Corrects 2 strings: - 'Delete this contract' - 'Contract deleted' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12508 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12508 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29421|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12508 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Yohann! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org