[Bug 30774] New: Typo: i %sEdit %sReserve %s
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30774 Bug ID: 30774 Summary: Typo: i %sEdit %sReserve %s Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org The single i here seems misplaced: koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt:33 i %sEdit %sReserve %s -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30774 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30774 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30774 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 135059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135059&action=edit Bug 30774: Typo: i %sEdit %sReserve %s This patch removes an out of place "i" and replaces it with a space. The patch also removes obsolete CDATA markers in the page's JavaScript. To test, apply the patch and go to Course reserves. - Create a course if necessary, then view the details of your course. - Click the "Add reserves" button. - Enter a barcode or biblionumber. - On the next page, the heading "Reserve [title] for [course]" should look correct, with no extra "i" at the beginning of the line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30774 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30774 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135059|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 135078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135078&action=edit Bug 30774: Typo: i %sEdit %sReserve %s This patch removes an out of place "i" and replaces it with a space. The patch also removes obsolete CDATA markers in the page's JavaScript. To test, apply the patch and go to Course reserves. - Create a course if necessary, then view the details of your course. - Click the "Add reserves" button. - Enter a barcode or biblionumber. - On the next page, the heading "Reserve [title] for [course]" should look correct, with no extra "i" at the beginning of the line. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30774 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Depends on| |27631 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 [Bug 27631] Accessibility: Staff interface - `h1` on each page is Logo but should be page description/title -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30774 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> ---
The patch also removes obsolete CDATA markers in the page's JavaScript.
C -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30774 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> ---
The patch also removes obsolete CDATA markers in the page's JavaScript.
Can you open an enhancement request on the qa-test-tools project please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30774 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30774 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135078|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135108&action=edit Bug 30774: Typo: i %sEdit %sReserve %s This patch removes an out of place "i" and replaces it with a space. The patch also removes obsolete CDATA markers in the page's JavaScript. To test, apply the patch and go to Course reserves. - Create a course if necessary, then view the details of your course. - Click the "Add reserves" button. - Enter a barcode or biblionumber. - On the next page, the heading "Reserve [title] for [course]" should look correct, with no extra "i" at the beginning of the line. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30774 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- VIM did it ^^ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30774 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30774 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30774 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.01 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30774 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |arthur.suzuki@biblibre.com --- Comment #9 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Not backporting, not relevant to 21.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org