[Bug 26990] New: No feedback if holds override is disabled and hold fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26990 Bug ID: 26990 Summary: No feedback if holds override is disabled and hold fails Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com placerequest.pl checks CanItemBeReserved and correctly fails a hold, however, an item that is not holdable because it cannot be transferred is selectable while placing holds and will fail silently as placerequest.pl doesn't set any params for feedback if a hold fails, it expects the hold screen to block any unwanted holds To recreate: 1 - Set preferences: UseBranchTransferLimits: enforce BranchTransferLimitsType: itype AllowHoldPolicyOverride: Don't allow 2 - Set Centerville 'Book' items to not be allowed to transfer to any other library 3 - Make sure Hold policy is set to 'any library' 4 - Find a record with a Centerville item and other items 5 - Attempt to place an item level hold on the Centerville item 6 - You are taken to the holds list, but your hold is not placed 7 - Nothing indicates why hold has failed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26990 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26990 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Ensure that the pickup library is different than CPL -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26990 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Severity|major |critical Depends on| |23116 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by commit 2c5e9bed7de83d01be755475b96a3cf439e0126c Bug 23116: AllowHoldPolicyOverride allows a librarian to almost place a hold on an item already on hold Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23116 [Bug 23116] Cannot place overridden holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26990 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23116 |22284 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by: commit 546a3b6d4d6333fe938572f0247dfcbe4a4d35a8 Bug 22284: New message, new column and filter pickup locations in reserve/request.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 [Bug 22284] Add ability to define groups of locations for hold pickup https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23116 [Bug 23116] Cannot place overridden holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26990 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- - my $can_item_be_reserved = CanItemBeReserved( $patron->borrowernumber, $itemnumber, $pickup )->{status}; - $item->{not_holdable} = $can_item_be_reserved unless $can_item_be_reserved eq 'OK'; + my $can_item_be_reserved = CanItemBeReserved( $patron->borrowernumber, $itemnumber )->{status}; The $pickup parameter disappears. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26990 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26990 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 113497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113497&action=edit Bug 26990: (bug 22284 follow-up) Prevent hold to be placed if cannot be transferred There is a missing parameter to CanItemBeReserved, we need to know if the hold can be placed at a given pickup library. Test plan: 1 - Set preferences: UseBranchTransferLimits: enforce BranchTransferLimitsType: itype AllowHoldPolicyOverride: Don't allow 2 - Set Centerville 'Book' items to not be allowed to transfer to any other library 3 - Make sure Hold policy is set to 'any library' 4 - Find a record with a Centerville item and other items 5 - Attempt to place an item level hold on the Centerville item (with a pickup library different than Centerville) => Without this patch you are taken to the holds list, but your hold is not placed Nothing indicates why hold has failed => With this patch you cannot select the item from Centerville "Cannot be transferred to pickup library" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26990 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26990 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113497|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 113532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113532&action=edit Bug 26990: (bug 22284 follow-up) Prevent hold to be placed if cannot be transferred There is a missing parameter to CanItemBeReserved, we need to know if the hold can be placed at a given pickup library. Test plan: 1 - Set preferences: UseBranchTransferLimits: enforce BranchTransferLimitsType: itype AllowHoldPolicyOverride: Don't allow 2 - Set Centerville 'Book' items to not be allowed to transfer to any other library 3 - Make sure Hold policy is set to 'any library' 4 - Find a record with a Centerville item and other items 5 - Attempt to place an item level hold on the Centerville item (with a pickup library different than Centerville) => Without this patch you are taken to the holds list, but your hold is not placed Nothing indicates why hold has failed => With this patch you cannot select the item from Centerville "Cannot be transferred to pickup library" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26990 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- My notes from testing Step 2: 1. Go to Administration > Patrons and circulation > Library transfer limits. 2. Make sure Centerville is selected as the library. 3. For BK click on clear all then save. 4. Note that CPL still stays selected. Step 4, before step 4 change the library in the staff interface to a library other than Centerville. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26990 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26990 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113532|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113554&action=edit Bug 26990: (bug 22284 follow-up) Prevent hold to be placed if cannot be transferred There is a missing parameter to CanItemBeReserved, we need to know if the hold can be placed at a given pickup library. Test plan: 1 - Set preferences: UseBranchTransferLimits: enforce BranchTransferLimitsType: itype AllowHoldPolicyOverride: Don't allow 2 - Set Centerville 'Book' items to not be allowed to transfer to any other library 3 - Make sure Hold policy is set to 'any library' 4 - Find a record with a Centerville item and other items 5 - Attempt to place an item level hold on the Centerville item (with a pickup library different than Centerville) => Without this patch you are taken to the holds list, but your hold is not placed Nothing indicates why hold has failed => With this patch you cannot select the item from Centerville "Cannot be transferred to pickup library" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26990 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26990 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26990 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.06 released in| | --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26990 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #11 from Aleisha Amohia <aleisha@catalyst.net.nz> --- missing dependencies, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26990 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org