[Bug 31275] New: AdditionalContents.search_for_display returns branch block and All block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31275 Bug ID: 31275 Summary: AdditionalContents.search_for_display returns branch block and All block Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org If there is a branch specific block, you normally dont want the All block to appear too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31275 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31275 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- That could be a feature... :) However I've created a OpacNavRight for all and CPL, and only the one from all is displayed. And this is definitely a bug. Which block did you try? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31275 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I don't think that assumption is correct in general. Often you have contents that are relevant for all branches and branch specific. The current behavior sounds correct to me. "All libraries" has never acted as a fallback for library specific. If this is about translations: default and specific language should not both show together. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31275 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
However I've created a OpacNavRight for all and CPL, and only the one from all is displayed. And this is definitely a bug.
Were you logged in? Branch specific only show to logged in users. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31275 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #3)
However I've created a OpacNavRight for all and CPL, and only the one from all is displayed. And this is definitely a bug.
Were you logged in? Branch specific only show to logged in users.
Ha, that might be it! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31275 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #1)
That could be a feature... :)
However I've created a OpacNavRight for all and CPL, and only the one from all is displayed. And this is definitely a bug.
Which block did you try?
I encountered this behavior while testing bug 29144 which creates a OpacBranchInfo block to replace branches.opac_info. I somehow assumed the All branches to be a fallback for not having a branch specific one.. When i let the kohanews process directive display the return of AdditionalContents.get in the template, it shows both. Note that other templates perhaps show one result, but since the sort order is number, it will be a bit random which one appears? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31275 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #2)
I don't think that assumption is correct in general. Often you have contents that are relevant for all branches and branch specific. The current behavior sounds correct to me. "All libraries" has never acted as a fallback for library specific.
This sounds counterintuitive. If you have a specific block, I would understand it to override the All branches stuff. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31275 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #3)
However I've created a OpacNavRight for all and CPL, and only the one from all is displayed. And this is definitely a bug.
Were you logged in? Branch specific only show to logged in users.
I entered one for All and CPL. I am logged into CPL. And I see both OpacNav blocks. And I really wonder if that should be the case.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31275 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #7)
(In reply to Katrin Fischer from comment #3)
However I've created a OpacNavRight for all and CPL, and only the one from all is displayed. And this is definitely a bug.
Were you logged in? Branch specific only show to logged in users.
I entered one for All and CPL. I am logged into CPL. And I see both OpacNav blocks. And I really wonder if that should be the case..
We have inherited this from the news module. I think changing it now could be quite disruptive to libraries as the OPAC behaviour would change. I think if we want a fallback, maybe we could have an additional checkbox or so? "Use only if no library specific content was generated" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31275 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #8)
We have inherited this from the news module. I think changing it now could be quite disruptive to libraries as the OPAC behaviour would change.
Not sure about that. But no worry, we can add a new method where another behavior is definitely wanted. Have a look at bug 29144, patch Add $contents->find_best_match, $library->opac_info. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31275 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29144 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31275 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I agree with Katrin, the 'All libraries' option is clear to me that is displays for "All libraries'.. i.e. always displays.. we have customers using that in production.. it would be a regression to change the meaning. However.. I may well be nice to have a fallback option as an alternative too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org