[Bug 36118] New: ILL request log does not display patron information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Bug ID: 36118 Summary: ILL request log does not display patron information Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com CC: pedro.amorim@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162277&action=edit Bug 36118: [DONT PUSH] patch to test patron notice only -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162278&action=edit Bug 36118: Send patron object to template -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162279&action=edit Bug 36118: Update status and send notice core actions logging 1) Enable ILLlog sys pref 2) Enable ILLModule and install 'FreeForm', run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Create a new FreeForm request, visit: <INTRA_URL>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 4) Pick a type, insert '42' on cardnumber and pick a library, hit 'Create' 5) On the next screen, click 'Confirm request' and confirm. 6) Click 'ILL request log', notice the entry is there but has no information about who did the logged action. 7) Apply patches. Repeat steps 3) to 6). Notice the logged action now has information about the user who did the action. 8) Extra: Click 'Send notice to patron' and confirm that action is also logged with patron information. To my knowledge, these are the only 2 actions logged by core Logger. Backends logging their own actions that want patron information need to add it themselves following this pattern. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, nugged@gmail.com, | |tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162278|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162585&action=edit Bug 36118: Send patron object to template Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162279|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162586&action=edit Bug 36118: Update status and send notice core actions logging 1) Enable ILLlog sys pref 2) Enable ILLModule and install 'FreeForm', run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Create a new FreeForm request, visit: <INTRA_URL>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 4) Pick a type, insert '42' on cardnumber and pick a library, hit 'Create' 5) On the next screen, click 'Confirm request' and confirm. 6) Click 'ILL request log', notice the entry is there but has no information about who did the logged action. 7) Apply patches. Repeat steps 3) to 6). Notice the logged action now has information about the user who did the action. 8) Extra: Click 'Send notice to patron' and confirm that action is also logged with patron information. To my knowledge, these are the only 2 actions logged by core Logger. Backends logging their own actions that want patron information need to add it themselves following this pattern. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162587&action=edit Bug 36118: Tidy changed code block Simple tidy of the codeblock we added a line to so we get through the tidy requirements of the QA script. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice improvement. Signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
4) Pick a type, insert '42' on cardnumber and pick a library, hit 'Create'
picking a type results in error 403
Programming error - No CSRF token passed for POST http://localhost:8081/intranet/ill/ill-requests.pl?method=create&backend=FreeForm (referer: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm)
Is that already reported? It doesn't seem to be in Bug 36195 's pad and bug 34478 's dependencies. So can't test for now. Code looks good at least :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162277|0 |1 is obsolete| | --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 163178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163178&action=edit Bug 36118: [DONT PUSH] patch to test patron notice only -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162585|0 |1 is obsolete| | --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 163179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163179&action=edit Bug 36118: Send patron object to template Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162586|0 |1 is obsolete| | --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 163180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163180&action=edit Bug 36118: Update status and send notice core actions logging 1) Enable ILLlog sys pref 2) Enable ILLModule and install 'FreeForm', run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Create a new FreeForm request, visit: <INTRA_URL>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 4) You need to checkout FreeForm's branch compatible with the CSRF work: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout b_36243 koha-plack --restart kohadev 5) Pick a type, insert '42' on cardnumber and pick a library, hit 'Create' 6) On the next screen, click 'Confirm request' and confirm. 7) Click 'ILL request log', notice the entry is there but has no information about who did the logged action. 8) Apply patches. Repeat steps 3) to 6). Notice the logged action now has information about the user who did the action. 9) Extra: Click 'Send notice to patron' and confirm that action is also logged with patron information. To my knowledge, these are the only 2 actions logged by core Logger. Backends logging their own actions that want patron information need to add it themselves following this pattern. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162587|0 |1 is obsolete| | --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 163181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163181&action=edit Bug 36118: Tidy changed code block Simple tidy of the codeblock we added a line to so we get through the tidy requirements of the QA script. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 --- Comment #13 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Victor Grousset/tuxayo from comment #8)
4) Pick a type, insert '42' on cardnumber and pick a library, hit 'Create'
picking a type results in error 403
Programming error - No CSRF token passed for POST http://localhost:8081/intranet/ill/ill-requests.pl?method=create&backend=FreeForm (referer: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm)
Is that already reported? It doesn't seem to be in Bug 36195 's pad and bug 34478 's dependencies.
So can't test for now. Code looks good at least :)
Thanks Victor, the original test plan was missing a step, I've since added it: 4) You need to checkout FreeForm's branch compatible with the CSRF work: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout b_36243 koha-plack --restart kohadev -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163178|0 |1 is obsolete| | --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 163283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163283&action=edit Bug 36118: [DONT PUSH] patch to test patron notice only Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163179|0 |1 is obsolete| | --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 163284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163284&action=edit Bug 36118: Send patron object to template Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163180|0 |1 is obsolete| | --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 163285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163285&action=edit Bug 36118: Update status and send notice core actions logging 1) Enable ILLlog sys pref 2) Enable ILLModule and install 'FreeForm', run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Create a new FreeForm request, visit: <INTRA_URL>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 4) You need to checkout FreeForm's branch compatible with the CSRF work: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout b_36243 koha-plack --restart kohadev 5) Pick a type, insert '42' on cardnumber and pick a library, hit 'Create' 6) On the next screen, click 'Confirm request' and confirm. 7) Click 'ILL request log', notice the entry is there but has no information about who did the logged action. 8) Apply patches. Repeat steps 3) to 6). Notice the logged action now has information about the user who did the action. 9) Extra: Click 'Send notice to patron' and confirm that action is also logged with patron information. To my knowledge, these are the only 2 actions logged by core Logger. Backends logging their own actions that want patron information need to add it themselves following this pattern. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163181|0 |1 is obsolete| | --- Comment #17 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 163286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163286&action=edit Bug 36118: Tidy changed code block Simple tidy of the codeblock we added a line to so we get through the tidy requirements of the QA script. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |victor@tuxayo.net --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
7) Click 'ILL request log', notice the entry is there but has no information about who did the logged action.
Testing notes: need to have this commit applied "Bug 36118: [DONT PUSH] patch to test patron notice only" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/PTFS-Eur | |ope/koha/commits/bug_36118/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163283|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163284|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163285|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163286|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld@ptfs-europe.com | |, | |edith.speller@ukhsa.gov.uk, | |jeremy.evans@ukhsa.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 --- Comment #20 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164181&action=edit Bug 36118: [DONT PUSH] patch to test patron notice only -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 --- Comment #21 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164182&action=edit Bug 36118: Send patron object to template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 --- Comment #22 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164183&action=edit Bug 36118: Preparation: Move action logs tt methods This moves action logs related methods to its own .inc file in order to be reusable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 --- Comment #23 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164184&action=edit Bug 36118: Move common ILL log parts to single ill-request-log.inc file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 --- Comment #24 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164185&action=edit Bug 36118: Update status and send notice core actions logging 1) Enable ILLlog sys pref 2) Enable ILLModule and install 'FreeForm', run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Create a new FreeForm request, visit: <INTRA_URL>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 4) You need to checkout FreeForm's branch compatible with the CSRF work: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout b_36243 koha-plack --restart kohadev 5) Pick a type, insert '42' on cardnumber and pick a library, hit 'Create' 6) On the next screen, click 'Confirm request' and confirm. 7) Click 'ILL request log', notice the entry is there but has no information about who did the logged action. 8) Apply patches. Repeat steps 3) to 6). Notice the logged action now has information about the user who did the action. 9) Extra: Click 'Send notice to patron' and confirm that action is also logged with patron information. To my knowledge, these are the only 2 actions logged by core Logger. Backends logging their own actions that want patron information need to add it themselves following this pattern. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 --- Comment #25 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Hi guys, Martin and Victor, thanks for SO and QA. Implementing this for another backend, I found some flaws in the original implementation: - patron_notice.tt and status_change.tt were not DRY. - The previous implementation did not consider the possibility of a log entry not having a patron (it may have been added by command-line or cron). The new implementation considers this and displays accordingly. I've revisited it and since this had not yet been pushed I'm resubmitting here. The test plan is the same. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |**Sponsored by** *UKHSA - release notes| |UK Health Security Agency* | |and *PTFS Europe Ltd* Change sponsored?|--- |Sponsored Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Pedro, better to add the Sponsored by to the bug, see here: https://wiki.koha-community.org/wiki/Commit_messages#Sponsor_line And also this here from Martin ;) https://gitlab.com/koha-community/qa-test-tools/-/merge_requests/67 It will look better and can be counted by the release script for the sponsorships I believe. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164181|0 |1 is obsolete| | --- Comment #27 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 164398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164398&action=edit Bug 36118: [DONT PUSH] patch to test patron notice only Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164182|0 |1 is obsolete| | --- Comment #28 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 164399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164399&action=edit Bug 36118: Send patron object to template Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164183|0 |1 is obsolete| | --- Comment #29 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 164400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164400&action=edit Bug 36118: Preparation: Move action logs tt methods This moves action logs related methods to its own .inc file in order to be reusable Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164184|0 |1 is obsolete| | --- Comment #30 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 164401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164401&action=edit Bug 36118: Move common ILL log parts to single ill-request-log.inc file Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164185|0 |1 is obsolete| | --- Comment #31 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 164402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164402&action=edit Bug 36118: Update status and send notice core actions logging 1) Enable ILLlog sys pref 2) Enable ILLModule and install 'FreeForm', run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Create a new FreeForm request, visit: <INTRA_URL>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 4) You need to checkout FreeForm's branch compatible with the CSRF work: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout b_36243 koha-plack --restart kohadev 5) Pick a type, insert '42' on cardnumber and pick a library, hit 'Create' 6) On the next screen, click 'Confirm request' and confirm. 7) Click 'ILL request log', notice the entry is there but has no information about who did the logged action. 8) Apply patches. Repeat steps 3) to 6). Notice the logged action now has information about the user who did the action. 9) Extra: Click 'Send notice to patron' and confirm that action is also logged with patron information. To my knowledge, these are the only 2 actions logged by core Logger. Backends logging their own actions that want patron information need to add it themselves following this pattern. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #32 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It works :) ---
[% content | $raw %]
Where is the `content` variable from? ---- Review note: here is how to see the diff with the moved parts colored as such, thus leaving less lines to analyze in details. git diff upstream/master --color-moved --color-moved-ws=allow-indentation-change Also, there are some parts with alignment changes that are trivial to read with this: git diff --color-words=. upstream/master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 --- Comment #33 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Thank you, Victor. The content variable contains the HTML within the WRAPPER directive: https://template-toolkit.org/docs/manual/Directives.html#section_WRAPPER -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164398|0 |1 is obsolete| | --- Comment #34 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164405&action=edit Bug 36118: [DONT PUSH] patch to test patron notice only Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164399|0 |1 is obsolete| | --- Comment #35 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164406&action=edit Bug 36118: Send patron object to template Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164400|0 |1 is obsolete| | --- Comment #36 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164407&action=edit Bug 36118: Preparation: Move action logs tt methods This moves action logs related methods to its own .inc file in order to be reusable Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164401|0 |1 is obsolete| | --- Comment #37 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164408&action=edit Bug 36118: Move common ILL log parts to single ill-request-log.inc file Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164402|0 |1 is obsolete| | --- Comment #38 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164409&action=edit Bug 36118: Update status and send notice core actions logging 1) Enable ILLlog sys pref 2) Enable ILLModule and install 'FreeForm', run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Create a new FreeForm request, visit: <INTRA_URL>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 4) You need to checkout FreeForm's branch compatible with the CSRF work: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout b_36243 koha-plack --restart kohadev 5) Pick a type, insert '42' on cardnumber and pick a library, hit 'Create' 6) On the next screen, click 'Confirm request' and confirm. 7) Click 'ILL request log', notice the entry is there but has no information about who did the logged action. 8) Apply patches. Repeat steps 3) to 6). Notice the logged action now has information about the user who did the action. 9) Extra: Click 'Send notice to patron' and confirm that action is also logged with patron information. To my knowledge, these are the only 2 actions logged by core Logger. Backends logging their own actions that want patron information need to add it themselves following this pattern. Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 --- Comment #39 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Pedro Amorim from comment #33)
The content variable contains the HTML within the WRAPPER directive: https://template-toolkit.org/docs/manual/Directives.html#section_WRAPPER
Oh, right! Thanks. Works, makes sense, QA script happy, code looks good, count my QA stamp in :) Needs a signoff, looks a bit too much to directly pass QA. Is it already in production/pre-production? with other people (librarian or colleagues) having used the enhancement? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164405|0 |1 is obsolete| | --- Comment #40 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 170450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170450&action=edit Bug 36118: [DONT PUSH] patch to test patron notice only Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164406|0 |1 is obsolete| | --- Comment #41 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 170451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170451&action=edit Bug 36118: Send patron object to template Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164407|0 |1 is obsolete| | --- Comment #42 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 170452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170452&action=edit Bug 36118: Preparation: Move action logs tt methods This moves action logs related methods to its own .inc file in order to be reusable Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164408|0 |1 is obsolete| | --- Comment #43 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 170453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170453&action=edit Bug 36118: Move common ILL log parts to single ill-request-log.inc file Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164409|0 |1 is obsolete| | --- Comment #44 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 170454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170454&action=edit Bug 36118: Update status and send notice core actions logging 1) Enable ILLlog sys pref 2) Enable ILLModule and install 'FreeForm', run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Create a new FreeForm request, visit: <INTRA_URL>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 4) You need to checkout FreeForm's branch compatible with 24.05: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout 24.05.x koha-plack --restart kohadev 5) Pick a type, insert '42' on cardnumber and pick a library, hit 'Create' 6) On the next screen, click 'Confirm request' and confirm. 7) Click 'ILL request log', notice the entry is there but has no information about who did the logged action. 8) Apply patches. Repeat steps 3) to 6). Notice the logged action now has information about the user who did the action. 9) Extra: Click 'Send notice to patron' and confirm that action is also logged with patron information. To my knowledge, these are the only 2 actions logged by core Logger. Backends logging their own actions that want patron information need to add it themselves following this pattern. Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 --- Comment #45 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171372&action=edit [23.11] Bug 36118: Send patron object to template Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 --- Comment #46 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171373&action=edit [23.11] Bug 36118: Preparation: Move action logs tt methods This moves action logs related methods to its own .inc file in order to be reusable Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 --- Comment #47 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171374&action=edit [23.11] Bug 36118: Move common ILL log parts to single ill-request-log.inc file Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 --- Comment #48 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171375&action=edit [23.11] Bug 36118: Update status and send notice core actions logging 1) Enable ILLlog sys pref 2) Enable ILLModule and install 'FreeForm', run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Create a new FreeForm request, visit: <INTRA_URL>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 4) You need to checkout FreeForm's branch compatible with 24.05: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout 24.05.x koha-plack --restart kohadev 5) Pick a type, insert '42' on cardnumber and pick a library, hit 'Create' 6) On the next screen, click 'Confirm request' and confirm. 7) Click 'ILL request log', notice the entry is there but has no information about who did the logged action. 8) Apply patches. Repeat steps 3) to 6). Notice the logged action now has information about the user who did the action. 9) Extra: Click 'Send notice to patron' and confirm that action is also logged with patron information. To my knowledge, these are the only 2 actions logged by core Logger. Backends logging their own actions that want patron information need to add it themselves following this pattern. Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170450|0 |1 is obsolete| | --- Comment #49 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172785&action=edit Bug 36118: [DONT PUSH] patch to test patron notice only Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170451|0 |1 is obsolete| | --- Comment #50 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172786&action=edit Bug 36118: Send patron object to template Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170452|0 |1 is obsolete| | --- Comment #51 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172787&action=edit Bug 36118: Preparation: Move action logs tt methods This moves action logs related methods to its own .inc file in order to be reusable Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170453|0 |1 is obsolete| | --- Comment #52 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172788&action=edit Bug 36118: Move common ILL log parts to single ill-request-log.inc file Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170454|0 |1 is obsolete| | --- Comment #53 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172789&action=edit Bug 36118: Update status and send notice core actions logging 1) Enable ILLlog sys pref 2) Enable ILLModule and install 'FreeForm', run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Create a new FreeForm request, visit: <INTRA_URL>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 4) You need to checkout FreeForm's branch compatible with 24.05: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout 24.05.x koha-plack --restart kohadev 5) Pick a type, insert '42' on cardnumber and pick a library, hit 'Create' 6) On the next screen, click 'Confirm request' and confirm. 7) Click 'ILL request log', notice the entry is there but has no information about who did the logged action. 8) Apply patches. Repeat steps 3) to 6). Notice the logged action now has information about the user who did the action. 9) Extra: Click 'Send notice to patron' and confirm that action is also logged with patron information. To my knowledge, these are the only 2 actions logged by core Logger. Backends logging their own actions that want patron information need to add it themselves following this pattern. Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 --- Comment #54 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Victor Grousset/tuxayo from comment #39)
Needs a signoff, looks a bit too much to directly pass QA. Is it already in production/pre-production? with other people (librarian or colleagues) having used the enhancement?
Hi Victor. Yes, we have been using it in production and I've now added the sign-off from Jeremy Evans. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #55 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks, that was the last missing piece. No code change since my last test on Comment 39 QA script still happy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #56 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) This is untranslatable: +[% WRAPPER ill_request_log action_label = "Patron notice sent: " %] +[% WRAPPER ill_request_log action_label = "Status changed" %] ... The rough guideline for TT is that the parser will parce everything that is inside an HTML element. We can also get some attributes like button texts etc. from HTML elements. But in this here there is no indicator for the translation script that this is a display text. Please fix! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37103 --- Comment #57 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hope you are not going to hate me for it, but please rebase on top of bug 37103. I hope as this is only template changes it won't give to much trouble. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37103 [Bug 37103] Link log viewer options to corresponding system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 --- Comment #58 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173023&action=edit Bug 36118: (QA follow-up): Make labels translatable Also move the space+colon from 'Patron notice sent: ' label to ill-request-log.inc template Adjust status_change.tt 'From' capitalized because for status changed this is now: $ Status changed: From "New request" to "Requested" Instead of the previous: $ Status changed from "New request" to "Requested" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172785|0 |1 is obsolete| | --- Comment #59 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173024&action=edit Bug 36118: [DONT PUSH] patch to test patron notice only Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172786|0 |1 is obsolete| | --- Comment #60 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173025&action=edit Bug 36118: Send patron object to template Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172787|0 |1 is obsolete| | --- Comment #61 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173026&action=edit Bug 36118: Preparation: Move action logs tt methods This moves action logs related methods to its own .inc file in order to be reusable Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172788|0 |1 is obsolete| | --- Comment #62 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173027&action=edit Bug 36118: Move common ILL log parts to single ill-request-log.inc file Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172789|0 |1 is obsolete| | --- Comment #63 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173028&action=edit Bug 36118: Update status and send notice core actions logging 1) Enable ILLlog sys pref 2) Enable ILLModule and install 'FreeForm', run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Create a new FreeForm request, visit: <INTRA_URL>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 4) You need to checkout FreeForm's branch compatible with 24.05: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout 24.05.x koha-plack --restart kohadev 5) Pick a type, insert '42' on cardnumber and pick a library, hit 'Create' 6) On the next screen, click 'Confirm request' and confirm. 7) Click 'ILL request log', notice the entry is there but has no information about who did the logged action. 8) Apply patches. Repeat steps 3) to 6). Notice the logged action now has information about the user who did the action. 9) Extra: Click 'Send notice to patron' and confirm that action is also logged with patron information. To my knowledge, these are the only 2 actions logged by core Logger. Backends logging their own actions that want patron information need to add it themselves following this pattern. Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173023|0 |1 is obsolete| | --- Comment #64 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173029&action=edit Bug 36118: (QA follow-up): Make labels translatable Also move the space+colon from 'Patron notice sent: ' label to ill-request-log.inc template Adjust status_change.tt 'From' capitalized because for status changed this is now: $ Status changed: From "New request" to "Requested" Instead of the previous: $ Status changed from "New request" to "Requested" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173024|0 |1 is obsolete| | --- Comment #65 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173030&action=edit Bug 36118: [DONT PUSH] patch to test patron notice only Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173025|0 |1 is obsolete| | --- Comment #66 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173031&action=edit Bug 36118: Send patron object to template Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173026|0 |1 is obsolete| | --- Comment #67 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173032&action=edit Bug 36118: Preparation: Move action logs tt methods This moves action logs related methods to its own .inc file in order to be reusable Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173027|0 |1 is obsolete| | --- Comment #68 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173033&action=edit Bug 36118: Move common ILL log parts to single ill-request-log.inc file Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173028|0 |1 is obsolete| | --- Comment #69 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173034&action=edit Bug 36118: Update status and send notice core actions logging 1) Enable ILLlog sys pref 2) Enable ILLModule and install 'FreeForm', run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Create a new FreeForm request, visit: <INTRA_URL>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 4) You need to checkout FreeForm's branch compatible with 24.05: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout 24.05.x koha-plack --restart kohadev 5) Pick a type, insert '42' on cardnumber and pick a library, hit 'Create' 6) On the next screen, click 'Confirm request' and confirm. 7) Click 'ILL request log', notice the entry is there but has no information about who did the logged action. 8) Apply patches. Repeat steps 3) to 6). Notice the logged action now has information about the user who did the action. 9) Extra: Click 'Send notice to patron' and confirm that action is also logged with patron information. To my knowledge, these are the only 2 actions logged by core Logger. Backends logging their own actions that want patron information need to add it themselves following this pattern. Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173029|0 |1 is obsolete| | --- Comment #70 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173035&action=edit Bug 36118: (QA follow-up): Make labels translatable Also move the space+colon from 'Patron notice sent: ' label to ill-request-log.inc template Adjust status_change.tt 'From' capitalized because for status changed this is now: $ Status changed: From "New request" to "Requested" Instead of the previous: $ Status changed from "New request" to "Requested" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173030|0 |1 is obsolete| | --- Comment #71 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173036&action=edit Bug 36118: [DONT PUSH] patch to test patron notice only Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173031|0 |1 is obsolete| | --- Comment #72 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173037&action=edit Bug 36118: Send patron object to template Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173032|0 |1 is obsolete| | --- Comment #73 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173038&action=edit Bug 36118: Preparation: Move action logs tt methods This moves action logs related methods to its own .inc file in order to be reusable Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173033|0 |1 is obsolete| | --- Comment #74 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173039&action=edit Bug 36118: Move common ILL log parts to single ill-request-log.inc file Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173034|0 |1 is obsolete| | --- Comment #75 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173040&action=edit Bug 36118: Update status and send notice core actions logging 1) Enable ILLlog sys pref 2) Enable ILLModule and install 'FreeForm', run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 3) Create a new FreeForm request, visit: <INTRA_URL>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 4) You need to checkout FreeForm's branch compatible with 24.05: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout 24.05.x koha-plack --restart kohadev 5) Pick a type, insert '42' on cardnumber and pick a library, hit 'Create' 6) On the next screen, click 'Confirm request' and confirm. 7) Click 'ILL request log', notice the entry is there but has no information about who did the logged action. 8) Apply patches. Repeat steps 3) to 6). Notice the logged action now has information about the user who did the action. 9) Extra: Click 'Send notice to patron' and confirm that action is also logged with patron information. To my knowledge, these are the only 2 actions logged by core Logger. Backends logging their own actions that want patron information need to add it themselves following this pattern. Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173035|0 |1 is obsolete| | --- Comment #76 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173041&action=edit Bug 36118: (QA follow-up): Make labels translatable Also move the space+colon from 'Patron notice sent: ' label to ill-request-log.inc template Adjust status_change.tt 'From' capitalized because for status changed this is now: $ Status changed: From "New request" to "Requested" Instead of the previous: $ Status changed from "New request" to "Requested" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 --- Comment #77 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #57)
Hope you are not going to hate me for it, but please rebase on top of bug 37103.
I hope as this is only template changes it won't give to much trouble.
Can you please do a quick rebase? I will get back to it ASAP. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #78 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Applies nicely for me. Please note to apply interactively and comment out any [23.11] patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 --- Comment #79 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- That might have been it, will re-try. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #80 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #79)
That might have been it, will re-try.
Yep, that was the issue. I think we will need a follow-up then for 23.11 too - leaving with additional_work_needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 --- Comment #81 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|**Sponsored by** *UKHSA - | release notes|UK Health Security Agency* | |and *PTFS Europe Ltd* | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |With the ILLlog system release notes| |preference enabled, the | |actions logged for each ILL | |request lacked details | |about which patron user | |performed the action. This | |enhancement addresses this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |lucas@bywatersolutions.com --- Comment #82 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Enhancement, no 24.05.x backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|With the ILLlog system |With the IllLog system release notes|preference enabled, the |preference enabled, the |actions logged for each ILL |actions logged for each ILL |request lacked details |request lacked details |about which patron user |about which patron user |performed the action. This |performed the action. This |enhancement addresses this. |enhancement addresses this. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org