[Bug 6724] New: Holds Ratio does not allow decimals
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6724 Bug #: 6724 Summary: Holds Ratio does not allow decimals Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Circulation AssignedTo: kyle.m.hall@gmail.com ReportedBy: joy@bywatersolutions.com QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Holds Ratio report does not allow decimals. When decimal is entered (1.5) as the ratio, the system reverts to the default value. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6724 --- Comment #1 from Brett Wilkins <brett@catalyst.net.nz> 2011-08-29 05:56:12 UTC --- Created attachment 5201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5201 bug 6724: enable decimals on values greater than 1 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6724 --- Comment #2 from Brett Wilkins <brett@catalyst.net.nz> 2011-08-29 05:57:47 UTC --- Created attachment 5202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5202 Separating perl standard uses from koha uses -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6724 --- Comment #3 from Brett Wilkins <brett@catalyst.net.nz> 2011-08-29 06:03:21 UTC --- Created attachment 5203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5203 bug 6724: enable decimals on values greater than 1 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6724 --- Comment #4 from Brett Wilkins <brett@catalyst.net.nz> 2011-08-29 06:03:42 UTC --- Created attachment 5204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5204 bug 6724: enable decimals on values greater than 1 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6724 Brett Wilkins <brett@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5203|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6724 Brett Wilkins <brett@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5204|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6724 Brett Wilkins <brett@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |brett@catalyst.net.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6724 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5201|0 |1 is obsolete| | Attachment #5202|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2011-08-29 14:26:30 UTC --- Created attachment 5210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5210 Signed-off patches, squashed Before applying the patch entering a value like "1.5" would return the same results as leaving the default "3." After applying the patch I get revised results using the "1.5" value. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6724 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Patch Status|Needs Signoff |Signed Off AssignedTo|kyle.m.hall@gmail.com |brett@catalyst.net.nz Severity|enhancement |normal -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6724 --- Comment #6 from Brett Wilkins <brett@catalyst.net.nz> 2011-08-29 23:14:11 UTC --- It occurs to me that we could do away with the if-not-defined block, as undef += 0 == 0. Shouldn't worry about it for now, though? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6724 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Passed QA --- Comment #7 from Ian Walls <ian.walls@bywatersolutions.com> 2011-09-06 13:56:34 UTC --- Math-only patch, easy to read, marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6724 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-06 20:53:55 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6724 --- Comment #9 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-10-26 18:02:22 UTC --- The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6724 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org