[Bug 23114] New: Inventory: allow to scan barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23114 Bug ID: 23114 Summary: Inventory: allow to scan barcodes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: matthias.meusburger@biblibre.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Currently, in the inventory tool, the user can upload a file containing barcodes. It would be nice for the user to be able to scan barcodes as well, like in other tools (batch item modification, for example). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23114 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matthias.meusburger@biblibr |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23114 --- Comment #1 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 91020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91020&action=edit Bug 23114 - Inventory: allow to scan barcodes This patch allows the user to scan barcodes in the inventory tool (in addition to upload a barcode file, like in other tools) Test plan: 1) Apply the patch. 2) Check that you can still upload a barcode file. 3) Check that you can scan/enter barcodes in the new textarea. 4) Check that if you both upload a barcode file and enter barcodes, you will be prompted to choose only one method. 5) Check that you can then proceed to the next step by either resetting the upload file input or emptying the textarea. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23114 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23114 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org --- Comment #2 from George Williams (NEKLS) <george@nekls.org> --- I can still upload the barcode file. I can scan/enter barcodes in the textarea. I get a warning when I try to upload a file and enter barcodes scanned in the text area. I can proceed to the next step in both cases. But once I proceed to the next step, the uploaded file works with the inventory tool as expected. The scanned barcodes do not - it's as if I uploaded a text file with no data in it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23114 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |eric.begin@inLibro.com --- Comment #3 from Eric Bégin <eric.begin@inLibro.com> --- Applying: Bug 23114 - Inventory: allow to scan barcodes Using index info to reconstruct a base tree... M tools/inventory.pl Falling back to patching base and 3-way merge... Auto-merging tools/inventory.pl CONFLICT (content): Merge conflict in tools/inventory.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23114 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91020|0 |1 is obsolete| | --- Comment #4 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 93667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93667&action=edit Bug 23114 - Inventory: allow to scan barcodes This patch allows the user to scan barcodes in the inventory tool (in addition to upload a barcode file, like in other tools) Test plan: 1) Apply the patch. 2) Check that you can still upload a barcode file. 3) Check that you can scan/enter barcodes in the new textarea. 4) Check that if you both upload a barcode file and enter barcodes, you will be prompted to choose only one method. 5) Check that you can then proceed to the next step by either resetting the upload file input or emptying the textarea. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23114 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #5 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Patch rebased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23114 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Eric Bégin <eric.begin@inLibro.com> --- When I import the file, I get 2 messages : [3 items modified : datelastseen set to 10/05/2019] [Number of potential barcodes read: 3] I don't get any of those messages using the scanned barcodes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23114 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #7 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- *** Bug 23755 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23114 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Thanks for the feedback Eric. I just tested this again on master, and I get both "datelastseen set to" and "Number of potential barcodes read" messages whether I use file upload or barcode scan. Could you please test it again, and be more specific about the options you used to make it fail? Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23114 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23114 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93667|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 110773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110773&action=edit Bug 23114 - Inventory: allow to scan barcodes This patch allows the user to scan barcodes in the inventory tool (in addition to upload a barcode file, like in other tools) Test plan: 1) Apply the patch. 2) Check that you can still upload a barcode file. 3) Check that you can scan/enter barcodes in the new textarea. 4) Check that if you both upload a barcode file and enter barcodes, you will be prompted to choose only one method. 5) Check that you can then proceed to the next step by either resetting the upload file input or emptying the textarea. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23114 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #10 from David Nind <david@davidnind.com> --- (In reply to Matthias Meusburger from comment #8)
Thanks for the feedback Eric.
I just tested this again on master, and I get both "datelastseen set to" and "Number of potential barcodes read" messages whether I use file upload or barcode scan.
Could you please test it again, and be more specific about the options you used to make it fail?
Thanks
I managed to replicate Eric's behavour - doing a flush_memcached and restart_all (on koha-testing-docker) after applying the patch and clearing the browser cache solved this for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23114 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23114 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110793&action=edit Bug 23114: Inventory: allow to scan barcodes This patch allows the user to scan barcodes in the inventory tool (in addition to upload a barcode file, like in other tools) Test plan: 1) Apply the patch. 2) Check that you can still upload a barcode file. 3) Check that you can scan/enter barcodes in the new textarea. 4) Check that if you both upload a barcode file and enter barcodes, you will be prompted to choose only one method. 5) Check that you can then proceed to the next step by either resetting the upload file input or emptying the textarea. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23114 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110794&action=edit Bug 23114: (QA follow-up) Slightly rephrase message when both barcode options are used Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23114 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Inventory: allow to scan |Inventory: allow to scan |barcodes |barcodes into input field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23114 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110773|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23114 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23114 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23114 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23114 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org