[Bug 38792] New: Move "My virtual card" tab and maybe re-label it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 Bug ID: 38792 Summary: Move "My virtual card" tab and maybe re-label it Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Depends on: 26777 When pushing bug 26777 I had made these notes on the bug:
1) Naming and positioning
This is a question: You named the tab "My virtual card", but that appears very general. What about we named it "Library card" or "Virtual library card" instead? Tbh I struggle a bit with the 'virtual and the "my" that we once had removed from all the other tabs.
Also, right now the tab appears last in the patron's account, should we move it to be first or second?
I believe they still apply and we should at least move the feature more to the top of the tabs. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 [Bug 26777] Give the user the option to display their patron card barcode from the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@ptfs-europe. | |com --- Comment #1 from Aude Charillon <aude.charillon@ptfs-europe.com> --- I was surprised when playing with the new feature that the tab was called "MY virtual card". I agree this doesn't fit with the other tabs that do not use "my" anymore. I think it's obvious the card is virtual. My preference would be for the tab to be renamed "Library card". I also agree it would make more sense to have that tab further up in the tab list, either right after the Summary or right after Personal details. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks Aude! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roman.dolny@jezuici.pl --- Comment #3 from Roman Dolny <roman.dolny@jezuici.pl> --- Virtual card is very useful and IMO should be renamed to "Library card". I think the tab should be last on the list - because of the way the user uses it on the cell phone (which is primary purpose of "Library card"). When the user logs in on the mobile device at the lending room (needs the barcode/QR there), sees his/her account (orders, rentals) first, and only below it the list of tabs. It is more convenient to scroll to the end of the screen (one fast scroll) and click on the last card, rather than looking for that tab in the middle of the list, scrolling slowly through the screen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- What about making it first? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 --- Comment #5 from Roman Dolny <roman.dolny@jezuici.pl> --- (In reply to Katrin Fischer from comment #4)
What about making it first?
Doesn't seem right to me because of desktop users. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to Roman Dolny from comment #5)
(In reply to Katrin Fischer from comment #4)
What about making it first?
Doesn't seem right to me because of desktop users.
A while ago, I implemented this same functionality using a Koha plugin. What I do is render "Your barcode" beneath "Your summary" and have a little "barcode" icon next to the person icon next to "Welcome, X Person". We used to use a tab on the opac-user.pl navigation but we found it unnecessary when we added it to those 2 other places instead. (Basically, we were looking to reduce "friction", so that users could make as few interactions as possible in order to get their barcode up for a self-checkout.) We still render them on a desktop, and I don't think there have been any complaints, but a person could hide them using CSS and/or Javascript. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jake.deery@ptfs-europe.com --- Comment #7 from Jake Deery <jake.deery@ptfs-europe.com> --- My pennies worth: I think the labelling is inconsistent and the positioning is wrong. I can't really say what I think the label should be – Library Card perhaps? All I know for sure is that I feel the “my” should be gone. As for the positioning, this much is a lot easier for me: I don't like it, and feel that it should be near the top. There should be more places to access it (one in the account dropdown, perhaps, and one in the Summary page), and it should sit directly under Summary in the list, in my view. If you look at the screenshot below (taken on iPhone 13), when scrolled 100% to the bottom, the whole list can be seen. A change does not impact mobile users. https://i.imgur.com/VB4bzVe.png If you look at the screenshot below (taken on a 1024×768 display), the my virtual card button is obscured. If a sysadmin has taken the effort of enabling this syspref, they likely see this feature as quite important. https://i.imgur.com/RkhuiTj.png Hope my opinions help. Jake -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 Bug 38792 depends on bug 26777, which changed state. Bug 26777 Summary: Give the user the option to display their patron card barcode from the OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main Depends on| |39411 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39411 [Bug 39411] Add card number and patron expiration info to OPAC Virtual Card -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 38791 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 182625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182625&action=edit Bug 38792: Rename "My virtual card" to "Library card" and move tab This patch makes a number of changes to the "My virtual card" page and associated menu item: 1. Rename it to "Library card." This fits better with the naming of other user pages. This change includes updates to the page title, breadcrumb menu, and page heading. 2. Move the menu item up to appear right after the "Summary" link. 3. Make some style changes to the display of the card, giving the card more comfortable padding and adding some responsive behavior to the card width. To test, apply the patch and rebuild the OPAC CSS. - If necessary, go to Administration -> System preferences and enable the OPACVirtualCard preference. - Log in to the OPAC. - You should see a "Library card" menu item in the left-hand sidebar menu, right below the "Summary" item. - On the "Library card" page, the page title, breadcrumb item, and page heading should read "Your library card." - The "card" should look good, and should adjust well at various browser widths. - Above 769px wide, the card should not expand wider than 500px. - Below 769px wide, the card should have a width of 100% and should adjust as the viewport is narrowed. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182625|0 |1 is obsolete| | --- Comment #10 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 182630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182630&action=edit Bug 38792: Rename "My virtual card" to "Library card" and move tab This patch makes a number of changes to the "My virtual card" page and associated menu item: 1. Rename it to "Library card." This fits better with the naming of other user pages. This change includes updates to the page title, breadcrumb menu, and page heading. 2. Move the menu item up to appear right after the "Summary" link. 3. Make some style changes to the display of the card, giving the card more comfortable padding and adding some responsive behavior to the card width. To test, apply the patch and rebuild the OPAC CSS. - If necessary, go to Administration -> System preferences and enable the OPACVirtualCard preference. - Log in to the OPAC. - You should see a "Library card" menu item in the left-hand sidebar menu, right below the "Summary" item. - On the "Library card" page, the page title, breadcrumb item, and page heading should read "Your library card." - The "card" should look good, and should adjust well at various browser widths. - Above 769px wide, the card should not expand wider than 500px. - Below 769px wide, the card should have a width of 100% and should adjust as the viewport is narrowed. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 182666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182666&action=edit Bug 39411: Add cardnumber and dateexpiry to OPAC virtual card To test: 1. APPLY PATCH 2. Enable OPACVirtualCard 3. Login to the OPAC and visit the account page. 4. Click on 'My virtual card' 5. Notice that the cardnumber and expiratrion date are now listed. Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182630|0 |1 is obsolete| | --- Comment #12 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 182667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182667&action=edit Bug 38792: Rename "My virtual card" to "Library card" and move tab This patch makes a number of changes to the "My virtual card" page and associated menu item: 1. Rename it to "Library card." This fits better with the naming of other user pages. This change includes updates to the page title, breadcrumb menu, and page heading. 2. Move the menu item up to appear right after the "Summary" link. 3. Make some style changes to the display of the card, giving the card more comfortable padding and adding some responsive behavior to the card width. To test, apply the patch and rebuild the OPAC CSS. - If necessary, go to Administration -> System preferences and enable the OPACVirtualCard preference. - Log in to the OPAC. - You should see a "Library card" menu item in the left-hand sidebar menu, right below the "Summary" item. - On the "Library card" page, the page title, breadcrumb item, and page heading should read "Your library card." - The "card" should look good, and should adjust well at various browser widths. - Above 769px wide, the card should not expand wider than 500px. - Below 769px wide, the card should have a width of 100% and should adjust as the viewport is narrowed. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de --- Comment #13 from Paul Derscheid <paul.derscheid@lmscloud.de> --- This is PQA in my opinion. I think there are some points in the discussion that are worth exploring further, e.g. more options to access it. Within the scope of this bug, the changes make sense and should be pushed. The base for iteration is there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Dependency is not signed off yet - bug 39411. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 --- Comment #15 from Aude Charillon <aude.charillon@openfifth.co.uk> --- The move and renaming look good :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA --- Comment #16 from David Cook <dcook@prosentient.com.au> --- (In reply to Paul Derscheid from comment #13)
This is PQA in my opinion.
I think there are some points in the discussion that are worth exploring further, e.g. more options to access it.
Within the scope of this bug, the changes make sense and should be pushed. The base for iteration is there.
(In reply to Katrin Fischer from comment #14)
Dependency is not signed off yet - bug 39411.
Looks like Paul PQAed bug 39411 after Katrin commented, so I'll move this back to Passed QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |me@paulderscheid.xyz |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Passed QA |Failed QA --- Comment #17 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Owen, there are two attachments here with different bug numbers in the commit messages. Can you have a look? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182666|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182667|0 |1 is obsolete| | --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183257&action=edit Bug 38792: Rename "My virtual card" to "Library card" and move tab This patch makes a number of changes to the "My virtual card" page and associated menu item: 1. Rename it to "Library card." This fits better with the naming of other user pages. This change includes updates to the page title, breadcrumb menu, and page heading. 2. Move the menu item up to appear right after the "Summary" link. 3. Make some style changes to the display of the card, giving the card more comfortable padding and adding some responsive behavior to the card width. To test, apply the patch and rebuild the OPAC CSS. - If necessary, go to Administration -> System preferences and enable the OPACVirtualCard preference. - Log in to the OPAC. - You should see a "Library card" menu item in the left-hand sidebar menu, right below the "Summary" item. - On the "Library card" page, the page title, breadcrumb item, and page heading should read "Your library card." - The "card" should look good, and should adjust well at various browser widths. - Above 769px wide, the card should not expand wider than 500px. - Below 769px wide, the card should have a width of 100% and should adjust as the viewport is narrowed. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Lucas Gass (lukeg) from comment #17)
Owen, there are two attachments here with different bug numbers in the commit messages. Can you have a look?
Accidentally attached the dependency, sorry! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 --- Comment #20 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 --- Comment #21 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x for 25.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #22 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 --- Comment #23 from Aude Charillon <aude.charillon@openfifth.co.uk> --- Created follow-up bug 40615 to also update the mention of 'My virtual card' in the OPACVirtualCard system preference description. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38792 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1159 Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org