https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51125&action=edit Bug 16428: Use the biblio framework to know if a field is mapped The subroutine _build_default_values_for_mod_marc takes the frameworkcode in parameter, but ModItemFromMarc did not pass it. It uses it to know if a field is mapped or not to a Koha field (C4::Koha::IsKohaFieldLinked). Consequently the default framework ("") was always used. This bug has been found working on bug 13074 and has been put on a separate bug report to ease the backport. Test plan: Without this change, the tests added by bug 16428 won't pass -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Attachment #51230|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Comment on attachment 51230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51230 Bug 16428: (regression tests) The same tests are introduced on 13074 by Jonathan. I'm picking his tests. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51125|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 51327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51327&action=edit Bug 16428: Use the biblio framework to know if a field is mapped The subroutine _build_default_values_for_mod_marc takes the frameworkcode in parameter, but ModItemFromMarc did not pass it. It uses it to know if a field is mapped or not to a Koha field (C4::Koha::IsKohaFieldLinked). Consequently the default framework ("") was always used. This bug has been found working on bug 13074 and has been put on a separate bug report to ease the backport. Test plan: Without this change, the tests added by bug 16428 won't pass Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51327|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 51430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51430&action=edit Bug 16428: Use the biblio framework to know if a field is mapped The subroutine _build_default_values_for_mod_marc takes the frameworkcode in parameter, but ModItemFromMarc did not pass it. It uses it to know if a field is mapped or not to a Koha field (C4::Koha::IsKohaFieldLinked). Consequently the default framework ("") was always used. This bug has been found working on bug 13074 and has been put on a separate bug report to ease the backport. Test plan: Without this change, the tests added by bug 16428 won't pass Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jesse Weaver from comment #7)

I have some qualms about pushing this... there are a very significant number of places in Koha that use the default framework's mappings (enough to make it a de-facto standard). See the results of a $ git grep TransformMarcToKoha

It seems that we are using it when adding/modifying a record/item. git grep TransformMarcToKoha|grep -v frameworkcode does not return a lot of relevant results :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Just adding to the discussion, this is a specific context. We are looking at items. And only looking at default values to use when an item field would be empty. And maybe adding somewhat more weight, the default framework by standard does not even contain any other default value than NULL.. Since this patch theoretically does the right thing and its change of behavior may probably be quite limited (only impacting local defaults for items), I still would support to push it to master. We c/should add a dbrev with a warning about this change. Or even copy (in this dbrev) all item defaults from the current default framework to other frameworks (not overwriting not-null values), more or less ensuring unchanged behavior? Note that not-null items defaults currently are not used in this context, but it seems better not to overwrite them without consent. What do you think? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #12 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.01. -- You are receiving this mail because: You are watching all bug changes.