[Bug 37115] New: Add the option to delete linked serials when deleting items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Bug ID: 37115 Summary: Add the option to delete linked serials when deleting items Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: matt.blenkinsop@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 167847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167847&action=edit Bug 37115: Delete linked serial when deleting a single item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 167848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167848&action=edit Bug 37115: Batch delete linked serials -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37116 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37116 [Bug 37116] Add the option to edit linked serials when editing items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Nathalie SAVARIT <nathalie.savarit@univ-amu.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nathalie.savarit@univ-amu.f | |r Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Nathalie SAVARIT <nathalie.savarit@univ-amu.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Nathalie SAVARIT <nathalie.savarit@univ-amu.fr> --- OK for deleting a single item and linked serial. KO for batch delete linked serials. Items are deleted but not linked serials. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167847|0 |1 is obsolete| | --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 168133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168133&action=edit Bug 37115: Delete linked serial when deleting a single item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167848|0 |1 is obsolete| | --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 168134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168134&action=edit Bug 37115: Batch delete linked serials -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Martin AUBEUT <martin.aubeut@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.aubeut@gmail.com --- Comment #6 from Martin AUBEUT <martin.aubeut@gmail.com> --- Hello Matt. Thanks for your work and your interest in the serial matters ! Can you provide a test plan ? It will be better for a correct sign off. Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168133|0 |1 is obsolete| | --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 168373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168373&action=edit Bug 37115: Delete linked serial when deleting a single item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168134|0 |1 is obsolete| | --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 168374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168374&action=edit Bug 37115: Batch delete linked serials -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 --- Comment #9 from Nathalie SAVARIT <nathalie.savarit@univ-amu.fr> --- Here's a test plan for 'Delete linked serial when deleting a single item' : - Add a new subscription to a serial notice (with option 'create an item record') - Receive one issue and create the item linked - Back to bibliographic record - Edit item - Action - Delete - Tick the box 'delete serial issues linked to item' and confirm - Back to subscription : the issue linked to item doesn't exist any more -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 --- Comment #10 from Nathalie SAVARIT <nathalie.savarit@univ-amu.fr> --- Hello Matt. I confirm that the patch 'deleting a single item and linked serial' works. But the second 'Batch deleted linked serials' does not meet expectations. Issues are still presents after the items have been deleted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 --- Comment #11 from Nathalie SAVARIT <nathalie.savarit@univ-amu.fr> --- Here's a test plan for 'Batch delete linked serials' : - Add a new subscription to a serial record (with option 'create an item record') - Receive several issues and create the items linked - Back to bibliographic record - Select several items - Click to 'Delete selected items' - Tick the box 'delete serial issues linked to items' and confirm - Back to subscription : the issues linked to items should no longer exist -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168373|0 |1 is obsolete| | --- Comment #12 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 168495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168495&action=edit Bug 37115: Delete linked serial when deleting a single item Test plan: - Add a new subscription to a serial notice (with the option 'create an item record' selected) - Receive one issue and create the linked item - Return to the bibliographic record - Edit item - Action - Delete - Tick the box 'delete serial issues linked to item' and confirm - The item should still be deleted correctly - Back to subscription : the issue linked to the item doesn't exist any more -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168374|0 |1 is obsolete| | --- Comment #13 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 168496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168496&action=edit Bug 37115: Batch delete linked serials Test plan: - Add a new subscription to a serial record (with the option 'create an item record' selected) - Receive several issues and create the linked items - Return to the bibliographic record - Select several items - Click to 'Delete selected items' - Tick the box 'delete serial issues linked to items' and confirm - The items should be deleted correctly - Back to subscription : the issues linked to items should no longer exist -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 --- Comment #14 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 168497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168497&action=edit Bug 37115: Add unit tests prove t/db_dependent/Koha/Item.t prove t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168495|0 |1 is obsolete| | --- Comment #15 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 171208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171208&action=edit Bug 37115: Delete linked serial when deleting a single item Test plan: - Add a new subscription to a serial notice (with the option 'create an item record' selected) - Receive one issue and create the linked item - Return to the bibliographic record - Edit item - Action - Delete - Tick the box 'delete serial issues linked to item' and confirm - The item should still be deleted correctly - Back to subscription : the issue linked to the item doesn't exist any more -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168496|0 |1 is obsolete| | --- Comment #16 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 171209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171209&action=edit Bug 37115: Batch delete linked serials Test plan: - Add a new subscription to a serial record (with the option 'create an item record' selected) - Receive several issues and create the linked items - Return to the bibliographic record - Select several items - Click to 'Delete selected items' - Tick the box 'delete serial issues linked to items' and confirm - The items should be deleted correctly - Back to subscription : the issues linked to items should no longer exist -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168497|0 |1 is obsolete| | --- Comment #17 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 171210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171210&action=edit Bug 37115: Add unit tests prove t/db_dependent/Koha/Item.t prove t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- Early QA: this is going to conflict with bug 37637. Saying that because you are using a bad pattern: using a TT plugin to retrieve additional info from items (it will cause 1 additional fetch + a JOIN per item). With bug 37637 you will be able to retrieve this information from the REST API and get rid of this TT plugin. `api/v1/swagger/definitions/item.yaml: serial_item` The downside is that it is a non-trivial change and you don't know when it will be pushed... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Nathalie SAVARIT <nathalie.savarit@univ-amu.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #19 from Nathalie SAVARIT <nathalie.savarit@univ-amu.fr> --- Hi Matthew. the link "Delete >>>>>>> Bug 37115: Delete linked serial when deleting a single item" is inactive. And for batch delete, items are deleted but not linked serials. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171208|0 |1 is obsolete| | --- Comment #20 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 171938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171938&action=edit Bug 37115: Delete linked serial when deleting a single item Test plan: - Add a new subscription to a serial notice (with the option 'create an item record' selected) - Receive one issue and create the linked item - Return to the bibliographic record - Edit item - Action - Delete - Tick the box 'delete serial issues linked to item' and confirm - The item should still be deleted correctly - Back to subscription : the issue linked to the item doesn't exist any more -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171209|0 |1 is obsolete| | --- Comment #21 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 171939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171939&action=edit Bug 37115: Batch delete linked serials Test plan: - Add a new subscription to a serial record (with the option 'create an item record' selected) - Receive several issues and create the linked items - Return to the bibliographic record - Select several items - Click to 'Delete selected items' - Tick the box 'delete serial issues linked to items' and confirm - The items should be deleted correctly - Back to subscription : the issues linked to items should no longer exist -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171210|0 |1 is obsolete| | --- Comment #22 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 171940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171940&action=edit Bug 37115: Add unit tests prove t/db_dependent/Koha/Item.t prove t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 --- Comment #23 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #18)
Early QA: this is going to conflict with bug 37637.
Saying that because you are using a bad pattern: using a TT plugin to retrieve additional info from items (it will cause 1 additional fetch + a JOIN per item).
With bug 37637 you will be able to retrieve this information from the REST API and get rid of this TT plugin. `api/v1/swagger/definitions/item.yaml: serial_item`
The downside is that it is a non-trivial change and you don't know when it will be pushed...
I've fixed the patches and reattached them using the TT plugin so that Nathalie can test them to check that the functionality is what she is expecting. Once we are happy with the concept I will look to rebase on 37637 and see what assistance is needed on that bug to help get this one through -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Koha collecto <koha@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@collecto.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Boubacar OUATTARA <boubacar.ouattara@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Boubacar OUATTARA <boubacar.ouattara@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171938|0 |1 is obsolete| | --- Comment #24 from Boubacar OUATTARA <boubacar.ouattara@biblibre.com> --- Created attachment 173256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173256&action=edit Bug 37115: Delete linked serial when deleting a single item Test plan: - Add a new subscription to a serial notice (with the option 'create an item record' selected) - Receive one issue and create the linked item - Return to the bibliographic record - Edit item - Action - Delete - Tick the box 'delete serial issues linked to item' and confirm - The item should still be deleted correctly - Back to subscription : the issue linked to the item doesn't exist any more Signed-off-by: Boubacar OUATTARA <boubacar.ouattara@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Boubacar OUATTARA <boubacar.ouattara@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171939|0 |1 is obsolete| | --- Comment #25 from Boubacar OUATTARA <boubacar.ouattara@biblibre.com> --- Created attachment 173257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173257&action=edit Bug 37115: Batch delete linked serials Test plan: - Add a new subscription to a serial record (with the option 'create an item record' selected) - Receive several issues and create the linked items - Return to the bibliographic record - Select several items - Click to 'Delete selected items' - Tick the box 'delete serial issues linked to items' and confirm - The items should be deleted correctly - Back to subscription : the issues linked to items should no longer exist Signed-off-by: Boubacar OUATTARA <boubacar.ouattara@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Boubacar OUATTARA <boubacar.ouattara@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171940|0 |1 is obsolete| | --- Comment #26 from Boubacar OUATTARA <boubacar.ouattara@biblibre.com> --- Created attachment 173258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173258&action=edit Bug 37115: Add unit tests prove t/db_dependent/Koha/Item.t prove t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t Signed-off-by: Boubacar OUATTARA <boubacar.ouattara@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173256|0 |1 is obsolete| | --- Comment #27 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174879&action=edit Bug 37115: Delete linked serial when deleting a single item Test plan: - Add a new subscription to a serial notice (with the option 'create an item record' selected) - Receive one issue and create the linked item - Return to the bibliographic record - Edit item - Action - Delete - Tick the box 'delete serial issues linked to item' and confirm - The item should still be deleted correctly - Back to subscription : the issue linked to the item doesn't exist any more Signed-off-by: Boubacar OUATTARA <boubacar.ouattara@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173257|0 |1 is obsolete| | --- Comment #28 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174880&action=edit Bug 37115: Batch delete linked serials Test plan: - Add a new subscription to a serial record (with the option 'create an item record' selected) - Receive several issues and create the linked items - Return to the bibliographic record - Select several items - Click to 'Delete selected items' - Tick the box 'delete serial issues linked to items' and confirm - The items should be deleted correctly - Back to subscription : the issues linked to items should no longer exist Signed-off-by: Boubacar OUATTARA <boubacar.ouattara@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173258|0 |1 is obsolete| | --- Comment #29 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174881&action=edit Bug 37115: Add unit tests prove t/db_dependent/Koha/Item.t prove t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t Signed-off-by: Boubacar OUATTARA <boubacar.ouattara@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174879|0 |1 is obsolete| | --- Comment #30 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 176434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176434&action=edit Bug 37115: Delete linked serial when deleting a single item Test plan: - Add a new subscription to a serial notice (with the option 'create an item record' selected) - Receive one issue and create the linked item - Return to the bibliographic record - Edit item - Action - Delete - Tick the box 'delete serial issues linked to item' and confirm - The item should still be deleted correctly - Back to subscription : the issue linked to the item doesn't exist any more Signed-off-by: Boubacar OUATTARA <boubacar.ouattara@biblibre.com> Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174880|0 |1 is obsolete| | --- Comment #31 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 176435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176435&action=edit Bug 37115: Batch delete linked serials Test plan: - Add a new subscription to a serial record (with the option 'create an item record' selected) - Receive several issues and create the linked items - Return to the bibliographic record - Select several items - Click to 'Delete selected items' - Tick the box 'delete serial issues linked to items' and confirm - The items should be deleted correctly - Back to subscription : the issues linked to items should no longer exist Signed-off-by: Boubacar OUATTARA <boubacar.ouattara@biblibre.com> Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174881|0 |1 is obsolete| | --- Comment #32 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 176436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176436&action=edit Bug 37115: Add unit tests prove t/db_dependent/Koha/Item.t prove t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t Signed-off-by: Boubacar OUATTARA <boubacar.ouattara@biblibre.com> Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Sophie Wawrzyniak <sophie.wawrzyniak@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.wawrzyniak@univ-lyon | |3.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 pjouve <pauline.jouve@enssib.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pauline.jouve@enssib.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 --- Comment #33 from Nathalie SAVARIT <nathalie.savarit@univ-amu.fr> --- Hi, It would be interesting to compare it with the ticket https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13870 : Add warnings about subscriptions and orders when deleting items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176434|0 |1 is obsolete| | --- Comment #34 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 179639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179639&action=edit Bug 37115: Delete linked serial when deleting a single item Test plan: - Add a new subscription to a serial notice (with the option 'create an item record' selected) - Receive one issue and create the linked item - Return to the bibliographic record - Edit item - Action - Delete - Tick the box 'delete serial issues linked to item' and confirm - The item should still be deleted correctly - Back to subscription : the issue linked to the item doesn't exist any more Signed-off-by: Boubacar OUATTARA <boubacar.ouattara@biblibre.com> Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176435|0 |1 is obsolete| | --- Comment #35 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 179640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179640&action=edit Bug 37115: Batch delete linked serials Test plan: - Add a new subscription to a serial record (with the option 'create an item record' selected) - Receive several issues and create the linked items - Return to the bibliographic record - Select several items - Click to 'Delete selected items' - Tick the box 'delete serial issues linked to items' and confirm - The items should be deleted correctly - Back to subscription : the issues linked to items should no longer exist Signed-off-by: Boubacar OUATTARA <boubacar.ouattara@biblibre.com> Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176436|0 |1 is obsolete| | --- Comment #36 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 179641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179641&action=edit Bug 37115: Add unit tests prove t/db_dependent/Koha/Item.t prove t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t Signed-off-by: Boubacar OUATTARA <boubacar.ouattara@biblibre.com> Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 --- Comment #37 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Comment on attachment 179639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179639 Bug 37115: Delete linked serial when deleting a single item Review of attachment 179639: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=37115&attachment=179639) ----------------------------------------------------------------- ::: Koha/Template/Plugin/Item.pm @@ +1,3 @@
+package Koha::Template::Plugin::Item; + +# Copyright PTFS EUROPE 2024
introduction of outdated name in Copyright notice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |baptiste.wojtkowski@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179639|0 |1 is obsolete| | --- Comment #38 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 183430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183430&action=edit Bug 37115: Delete linked serial when deleting a single item Test plan: - Add a new subscription to a serial notice (with the option 'create an item record' selected) - Receive one issue and create the linked item - Return to the bibliographic record - Edit item - Action - Delete - Tick the box 'delete serial issues linked to item' and confirm - The item should still be deleted correctly - Back to subscription : the issue linked to the item doesn't exist any more Signed-off-by: Boubacar OUATTARA <boubacar.ouattara@biblibre.com> Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179640|0 |1 is obsolete| | --- Comment #39 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 183431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183431&action=edit Bug 37115: Batch delete linked serials Test plan: - Add a new subscription to a serial record (with the option 'create an item record' selected) - Receive several issues and create the linked items - Return to the bibliographic record - Select several items - Click to 'Delete selected items' - Tick the box 'delete serial issues linked to items' and confirm - The items should be deleted correctly - Back to subscription : the issues linked to items should no longer exist Signed-off-by: Boubacar OUATTARA <boubacar.ouattara@biblibre.com> Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179641|0 |1 is obsolete| | --- Comment #40 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 183432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183432&action=edit Bug 37115: Add unit tests prove t/db_dependent/Koha/Item.t prove t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t Signed-off-by: Boubacar OUATTARA <boubacar.ouattara@biblibre.com> Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m --- Comment #41 from Lisette Scheer <lisette@bywatersolutions.com> --- Worked well! I did find that changes/deletion of issues aren't logged so I filed 40572 for that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183430|0 |1 is obsolete| | --- Comment #42 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 184948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184948&action=edit Bug 37115: Delete linked serial when deleting a single item Test plan: - Add a new subscription to a serial notice (with the option 'create an item record' selected) - Receive one issue and create the linked item - Return to the bibliographic record - Edit item - Action - Delete - Tick the box 'delete serial issues linked to item' and confirm - The item should still be deleted correctly - Back to subscription : the issue linked to the item doesn't exist any more Signed-off-by: Boubacar OUATTARA <boubacar.ouattara@biblibre.com> Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183431|0 |1 is obsolete| | --- Comment #43 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 184949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184949&action=edit Bug 37115: Batch delete linked serials Test plan: - Add a new subscription to a serial record (with the option 'create an item record' selected) - Receive several issues and create the linked items - Return to the bibliographic record - Select several items - Click to 'Delete selected items' - Tick the box 'delete serial issues linked to items' and confirm - The items should be deleted correctly - Back to subscription : the issues linked to items should no longer exist Signed-off-by: Boubacar OUATTARA <boubacar.ouattara@biblibre.com> Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183432|0 |1 is obsolete| | --- Comment #44 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 184950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184950&action=edit Bug 37115: Add unit tests prove t/db_dependent/Koha/Item.t prove t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t Signed-off-by: Boubacar OUATTARA <boubacar.ouattara@biblibre.com> Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 --- Comment #45 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 --- Comment #46 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40859 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40859 [Bug 40859] Item deletion is broken when using the linktools button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #47 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40908 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40908 [Bug 40908] Issues with deleting items from additem page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |**Sponsored-by:** release notes| |*Association KohaLa - | |https://koha-fr.org/* | | | |This bug introduces the | |ability to delete linked | |serials when deleting items | |(both individually and in | |batches). Users will be | |prompted with a checkbox as | |part of the deletion | |confirmation and so will | |have the option of whether | |to delete the linked | |item(s) or not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37115 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Text to go in the|**Sponsored-by:** |This bug introduces the release notes|*Association KohaLa - |ability to delete linked |https://koha-fr.org/* |serials when deleting items | |(both individually and in |This bug introduces the |batches). Users will be |ability to delete linked |prompted with a checkbox as |serials when deleting items |part of the deletion |(both individually and in |confirmation and so will |batches). Users will be |have the option of whether |prompted with a checkbox as |to delete the linked |part of the deletion |item(s) or not. |confirmation and so will | |have the option of whether |**Sponsored-by:** |to delete the linked |*Association KohaLa - |item(s) or not. |https://koha-fr.org/* -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org