https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 148438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148438&action=edit Bug 33260: Add NoticesManagement system preference -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #4 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 148440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148440&action=edit Bug 33260: [WIP] Add Notice management tool -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 AspenCat Team <aspencatteam@clicweb.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam@clicweb.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148943|0 |1 is obsolete| | --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 149009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149009&action=edit Bug 33260: Add Notice management tool This enhancement makes it easy for the library to view sent notices and filter by various search parameters. You can also print individual sent notices. TODO: Print multiple notices at once. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149009|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 149413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149413&action=edit Bug 33260: Add Notice management tool This enhancement makes it easy for the library to view sent notices and filter by various search parameters. You can also print sent notices, individually or in a batch. This enhancement uses a new system preference NoticesManagement and a new view_generated_notices user permission. To test: 1. Apply patches, install database updates, restart services 2. Make sure your logged in user has the view_generated_notices permission checked 3. Enable the NoticesManagement system preference 4. Generate a few notices. There are a few ways to do this including: - place holds, check in items and confirm the holds - place recalls, check in items and confirm the recalls 5. Go to Tools -> Notices management 6. There are two search functions on the left navigation. Confirm the patron search box works by searching for one of the patrons you generated a notice for, you should be redirected to their Notice history. 7. Go back to Notices management. Use the set of search filters to search for notices. Leaving the search filters empty will return all notices generated. Confirm the filters work as expected by using different combinations of filters. 8. Conduct a search so your notices show in a table. Confirm the information fetched about the notices is correct. 9. Click on a notice title. Confirm the contents of the notice show in a pop-up box. 10. Click one of the Print buttons next to a notice. Confirm the notice is opened to be printed. 11. Redo your notices search. Confirm the status of the notice you just printed has now been updated to 'sent'. 12. Use the 'Select all' and 'Clear all' buttons to select or clear the checkboxes. 13. Select a few checkboxes and click the button at the bottom of the table to 'Print selected notices'. Confirm the notices have been collated into one document, separated by horizontal lines, and prints successfully. The statuses for the notices should all be updated to 'sent'. 14. Confirm the Notices management page is not visible without the view_generated_notices permission 15. Confirm the Notices management page is not visible without the NoticesManagement system preference being enabled. 16. Go to a patron's Notices history. If the view_generated_notices user permission is checked for your logged in patron, you should see a Print button for each notice. Confirm this works. Confirm this button doesn't show if your logged in patron does not have the view_generated_notices user permission. It does not require the NoticesManagement system preference. Sponsored-by: Colorado Library Consortium -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Needs Signoff |Failed QA --- Comment #8 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Hi! Overall the new syspref and notices management page is working as expected. However, there are a few things I noticed that seem to be a little broken. 1. In the Notices Management page if you search for a patron and their name populates then clicking on the populated name will appropriately take you to their notice history. However, if you use the "Browse by last name" option or if you just search for a letter such as "K", then the table that is supposed to show the patron names is not displayed properly. It is askew to the left and mixes into the filter options. 2. The print notices work, but there is a lot of whitespace within the messages. This might be a separate bug, but having the messages more condensed and still separated by the horizontal line would be ideal. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149581|0 |1 is obsolete| | --- Comment #11 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 149593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149593&action=edit Bug 33260: Move patron search into main body of page This patch moves the patron search in the Notices management page to the main body of the page so that the patron search result table displays more nicely. This is a better place for it anyway, as using this search takes the user to a different page. In the sidebar, where it was previously, it implied it would have the same results display as the search filters. Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148438|0 |1 is obsolete| | --- Comment #13 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 149595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149595&action=edit Bug 33260: Add NoticesManagement system preference Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149413|0 |1 is obsolete| | --- Comment #15 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 149597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149597&action=edit Bug 33260: Add Notice management tool This enhancement makes it easy for the library to view sent notices and filter by various search parameters. You can also print sent notices, individually or in a batch. This enhancement uses a new system preference NoticesManagement and a new view_generated_notices user permission. To test: 1. Apply patches, install database updates, restart services 2. Make sure your logged in user has the view_generated_notices permission checked 3. Enable the NoticesManagement system preference 4. Generate a few notices. There are a few ways to do this including: - place holds, check in items and confirm the holds - place recalls, check in items and confirm the recalls 5. Go to Tools -> Notices management 6. There are two search functions on the left navigation. Confirm the patron search box works by searching for one of the patrons you generated a notice for, you should be redirected to their Notice history. 7. Go back to Notices management. Use the set of search filters to search for notices. Leaving the search filters empty will return all notices generated. Confirm the filters work as expected by using different combinations of filters. 8. Conduct a search so your notices show in a table. Confirm the information fetched about the notices is correct. 9. Click on a notice title. Confirm the contents of the notice show in a pop-up box. 10. Click one of the Print buttons next to a notice. Confirm the notice is opened to be printed. 11. Redo your notices search. Confirm the status of the notice you just printed has now been updated to 'sent'. 12. Use the 'Select all' and 'Clear all' buttons to select or clear the checkboxes. 13. Select a few checkboxes and click the button at the bottom of the table to 'Print selected notices'. Confirm the notices have been collated into one document, separated by horizontal lines, and prints successfully. The statuses for the notices should all be updated to 'sent'. 14. Confirm the Notices management page is not visible without the view_generated_notices permission 15. Confirm the Notices management page is not visible without the NoticesManagement system preference being enabled. 16. Go to a patron's Notices history. If the view_generated_notices user permission is checked for your logged in patron, you should see a Print button for each notice. Confirm this works. Confirm this button doesn't show if your logged in patron does not have the view_generated_notices user permission. It does not require the NoticesManagement system preference. Sponsored-by: Colorado Library Consortium Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #17 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Love the way the new setup looks for the notice management page! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff Depends on| |33478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 [Bug 33478] Customise the format of notices when they are printed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149598|0 |1 is obsolete| | --- Comment #19 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 150347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150347&action=edit Bug 33260: Move patron search into main body of page This patch moves the patron search in the Notices management page to the main body of the page so that the patron search result table displays more nicely. This is a better place for it anyway, as using this search takes the user to a different page. In the sidebar, where it was previously, it implied it would have the same results display as the search filters. Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |emmi.takkinen@koha-suomi.fi --- Comment #21 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- I'm getting this error when trying to apply the patches: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 33260: Add view_generated_notices user permission Applying: Bug 33260: Add NoticesManagement system preference Applying: Bug 33260: Add a patron getter method to Koha::Notice::Message Applying: Bug 33260: Add Notice management tool Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt M koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt A koha-tmpl/intranet-tmpl/prog/js/patron-autocomplete.js Falling back to patching base and 3-way merge... CONFLICT (modify/delete): koha-tmpl/intranet-tmpl/prog/js/patron-autocomplete.js deleted in HEAD and modified in Bug 33260: Add Notice management tool. Version Bug 33260: Add Notice management tool of koha-tmpl/intranet-tmpl/prog/js/patron-autocomplete.js left in tree. Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 33260: Add Notice management tool hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-33260-Add-Notice-management-tool-wp4ViP.patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150346|0 |1 is obsolete| | --- Comment #22 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 154927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154927&action=edit Bug 33260: Add Notice management tool This enhancement makes it easy for the library to view sent notices and filter by various search parameters. You can also print sent notices, individually or in a batch. This enhancement uses a new system preference NoticesManagement and a new view_generated_notices user permission. This enhancement has been built on top of Bug 33478 so print format settings are taken into account when printing notices. To test: 1. Apply patches, install database updates, restart services 2. Make sure your logged in user has the view_generated_notices permission checked 3. Enable the NoticesManagement system preference 4. Generate a few notices. There are a few ways to do this including: - place holds, check in items and confirm the holds - place recalls, check in items and confirm the recalls 5. Go to Tools -> Notices management 6. There are two search functions on the left navigation. Confirm the patron search box works by searching for one of the patrons you generated a notice for, you should be redirected to their Notice history. 7. Go back to Notices management. Use the set of search filters to search for notices. Leaving the search filters empty will return all notices generated. Confirm the filters work as expected by using different combinations of filters. 8. Conduct a search so your notices show in a table. Confirm the information fetched about the notices is correct. 9. Click on a notice title. Confirm the contents of the notice show in a pop-up box. 10. Click one of the Print buttons next to a notice. Confirm the notice is opened to be printed. 11. Redo your notices search. Confirm the status of the notice you just printed has now been updated to 'sent'. 12. Use the 'Select all' and 'Clear all' buttons to select or clear the checkboxes. 13. Select a few checkboxes and click the button at the bottom of the table to 'Print selected notices'. Confirm the notices have been collated into one document, separated by horizontal lines, and prints successfully. The statuses for the notices should all be updated to 'sent'. 14. Confirm the Notices management page is not visible without the view_generated_notices permission 15. Confirm the Notices management page is not visible without the NoticesManagement system preference being enabled. 16. Go to a patron's Notices history. If the view_generated_notices user permission is checked for your logged in patron, you should see a Print button for each notice. Confirm this works. Confirm this button doesn't show if your logged in patron does not have the view_generated_notices user permission. It does not require the NoticesManagement system preference. 17. Go to Tools -> Notices & slips 18. Edit the format settings of a few different notices i.e. HOLD and WELCOME 19. Generate these notices by filling a hold for a patron and sending a welcome email 20. Search for all notices under Tools -> Notices management 21. Select all notices and print selected notices 22. Confirm the notices different format settings are taken into account in the printed PDF Sponsored-by: Colorado Library Consortium -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #24 from David Nind <david@davidnind.com> --- Patch no longer applies 8-(... Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 33260: Add view_generated_notices user permission Applying: Bug 33260: Add NoticesManagement system preference Applying: Bug 33260: Add a patron getter method to Koha::Notice::Message Using index info to reconstruct a base tree... M t/db_dependent/Letters.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Letters.t CONFLICT (content): Merge conflict in t/db_dependent/Letters.t error: Failed to merge in the changes. Patch failed at 0001 Bug 33260: Add a patron getter method to Koha::Notice::Message -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154927|0 |1 is obsolete| | --- Comment #26 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 157384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157384&action=edit Bug 33260: Add Notice management tool This enhancement makes it easy for the library to view sent notices and filter by various search parameters. You can also print sent notices, individually or in a batch. This enhancement uses a new system preference NoticesManagement and a new view_generated_notices user permission. This enhancement has been built on top of Bug 33478 so print format settings are taken into account when printing notices. To test: 1. Apply patches, install database updates, restart services 2. Make sure your logged in user has the view_generated_notices permission checked 3. Enable the NoticesManagement system preference 4. Generate a few notices. There are a few ways to do this including: - place holds, check in items and confirm the holds - place recalls, check in items and confirm the recalls 5. Go to Tools -> Notices management 6. There are two search functions on the left navigation. Confirm the patron search box works by searching for one of the patrons you generated a notice for, you should be redirected to their Notice history. 7. Go back to Notices management. Use the set of search filters to search for notices. Leaving the search filters empty will return all notices generated. Confirm the filters work as expected by using different combinations of filters. 8. Conduct a search so your notices show in a table. Confirm the information fetched about the notices is correct. 9. Click on a notice title. Confirm the contents of the notice show in a pop-up box. 10. Click one of the Print buttons next to a notice. Confirm the notice is opened to be printed. 11. Redo your notices search. Confirm the status of the notice you just printed has now been updated to 'sent'. 12. Use the 'Select all' and 'Clear all' buttons to select or clear the checkboxes. 13. Select a few checkboxes and click the button at the bottom of the table to 'Print selected notices'. Confirm the notices have been collated into one document, separated by horizontal lines, and prints successfully. The statuses for the notices should all be updated to 'sent'. 14. Confirm the Notices management page is not visible without the view_generated_notices permission 15. Confirm the Notices management page is not visible without the NoticesManagement system preference being enabled. 16. Go to a patron's Notices history. If the view_generated_notices user permission is checked for your logged in patron, you should see a Print button for each notice. Confirm this works. Confirm this button doesn't show if your logged in patron does not have the view_generated_notices user permission. It does not require the NoticesManagement system preference. 17. Go to Tools -> Notices & slips 18. Edit the format settings of a few different notices i.e. HOLD and WELCOME 19. Generate these notices by filling a hold for a patron and sending a welcome email 20. Search for all notices under Tools -> Notices management 21. Select all notices and print selected notices 22. Confirm the notices different format settings are taken into account in the printed PDF Sponsored-by: Colorado Library Consortium -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #28 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 157386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157386&action=edit Bug 33260: Make styles apply per notice -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com --- Comment #30 from Kelly McElligott <kelly@bywatersolutions.com> --- Upon testing this, I am getting, for every notice, I try to print, No Slip Template Found. Each notice that I have tested has a template created which include checkin, hold, checkout, welcome. Not sure why I am getting this message. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #32 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Hi Kelly, I think you may have been seeing that message if you forgot to apply the patches from Bug 33478 first. Bug 33478 now needs to be rebased so will update when this patchset can be tested again. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157383|0 |1 is obsolete| | --- Comment #33 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 158852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158852&action=edit Bug 33260: Add a patron getter method to Koha::Notice::Message Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157385|0 |1 is obsolete| | --- Comment #35 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 158854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158854&action=edit Bug 33260: Move patron search into main body of page This patch moves the patron search in the Notices management page to the main body of the page so that the patron search result table displays more nicely. This is a better place for it anyway, as using this search takes the user to a different page. In the sidebar, where it was previously, it implied it would have the same results display as the search filters. Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34030 --- Comment #37 from Aleisha Amohia <aleisha@catalyst.net.nz> --- I have reworked this feature to apply on top of the new Preservation Module, which changed the markup for how most notices are sent. Please test that any formatting applies to all notices again, thank you! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34030 [Bug 34030] Print slips in a batch from the preservation module -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30287 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Just starting to look here; just a couple of comments from initial testing so far * Could you take bug 30287 into account for the notice previews, please? * I used bug 35279 to test using the WELCOME message (it adds print fallback) Once I'd created a print type welcome notice for the ktd henry user, it displayed OK in print preview from the new notice management page, but the same print button on the patron notices tab yields 'No slip template found'. I must admit, I find the print process a little confusing at the moment, but need to test more before really commenting further. I do however like the idea of the feature overall.. will be watching it closeing during the next cycle. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149594|0 |1 is obsolete| | Attachment #158855|0 |1 is obsolete| | --- Comment #40 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 162570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162570&action=edit Bug 33260: Add view_generated_notices user permission Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158852|0 |1 is obsolete| | --- Comment #42 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 162572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162572&action=edit Bug 33260: Add a patron getter method to Koha::Notice::Message Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158854|0 |1 is obsolete| | --- Comment #44 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 162574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162574&action=edit Bug 33260: Move patron search into main body of page This patch moves the patron search in the Notices management page to the main body of the page so that the patron search result table displays more nicely. This is a better place for it anyway, as using this search takes the user to a different page. In the sidebar, where it was previously, it implied it would have the same results display as the search filters. Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #45 from Kelly McElligott <kelly@bywatersolutions.com> --- When searching for a notice in the search filters within the Notice Management Tool, several notices appear multiple times. For example, there are 3 HOLD notices. In the sandbox I am testing in, there is only one HOLD notice within the Notices and Slips, so it shouldn't appear three times. In addition, there are two check-in digest and two checkout digest options in this drop-down menu. There are many that only appear once, but some appear more than once. I think that the notice should only appear once when the library only has one notice. This list becomes very long with duplicates and it is very confusing. Just testing, I did create a library-specific HOLD notice, which appeared in the dropdown menu as with all the others with no indication of it being a library-specific notice. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162573|0 |1 is obsolete| | --- Comment #46 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 162624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162624&action=edit Bug 33260: Add Notice management tool This enhancement makes it easy for the library to view sent notices and filter by various search parameters. You can also print sent notices, individually or in a batch. This enhancement uses a new system preference NoticesManagement and a new view_generated_notices user permission. This enhancement has been built on top of Bug 33478 so print format settings are taken into account when printing notices. To test: 1. Apply patches, install database updates, restart services 2. Make sure your logged in user has the view_generated_notices permission checked 3. Enable the NoticesManagement system preference 4. Generate a few notices. There are a few ways to do this including: - place holds, check in items and confirm the holds - place recalls, check in items and confirm the recalls 5. Go to Tools -> Notices management 6. There are two search functions on the left navigation. Confirm the patron search box works by searching for one of the patrons you generated a notice for, you should be redirected to their Notice history. 7. Go back to Notices management. Use the set of search filters to search for notices. Leaving the search filters empty will return all notices generated. Confirm the filters work as expected by using different combinations of filters. 8. Conduct a search so your notices show in a table. Confirm the information fetched about the notices is correct. 9. Click on a notice title. Confirm the contents of the notice show in a pop-up box. 10. Click one of the Print buttons next to a notice. Confirm the notice is opened to be printed. 11. Redo your notices search. Confirm the status of the notice you just printed has now been updated to 'sent'. 12. Use the 'Select all' and 'Clear all' buttons to select or clear the checkboxes. 13. Select a few checkboxes and click the button at the bottom of the table to 'Print selected notices'. Confirm the notices have been collated into one document, separated by horizontal lines, and prints successfully. The statuses for the notices should all be updated to 'sent'. 14. Confirm the Notices management page is not visible without the view_generated_notices permission 15. Confirm the Notices management page is not visible without the NoticesManagement system preference being enabled. 16. Go to a patron's Notices history. If the view_generated_notices user permission is checked for your logged in patron, you should see a Print button for each notice. Confirm this works. Confirm this button doesn't show if your logged in patron does not have the view_generated_notices user permission. It does not require the NoticesManagement system preference. 17. Go to Tools -> Notices & slips 18. Edit the format settings of a few different notices i.e. HOLD and WELCOME 19. Generate these notices by filling a hold for a patron and sending a welcome email 20. Search for all notices under Tools -> Notices management 21. Select all notices and print selected notices 22. Confirm the notices different format settings are taken into account in the printed PDF Sponsored-by: Colorado Library Consortium -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #48 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Kelly McElligott from comment #45)

When searching for a notice in the search filters within the Notice Management Tool, several notices appear multiple times. For example, there are 3 HOLD notices. In the sandbox I am testing in, there is only one HOLD notice within the Notices and Slips, so it shouldn't appear three times. In addition, there are two check-in digest and two checkout digest options in this drop-down menu. There are many that only appear once, but some appear more than once. I think that the notice should only appear once when the library only has one notice. This list becomes very long with duplicates and it is very confusing.

Just testing, I did create a library-specific HOLD notice, which appeared in the dropdown menu as with all the others with no indication of it being a library-specific notice.

Good catch, this was because of the many message transport types that might be available for a notice. I've fixed that up in latest patches - please test again when you can. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162571|0 |1 is obsolete| | --- Comment #50 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 162678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162678&action=edit Bug 33260: Add NoticesManagement system preference Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: kelly <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162624|0 |1 is obsolete| | --- Comment #52 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 162680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162680&action=edit Bug 33260: Add Notice management tool This enhancement makes it easy for the library to view sent notices and filter by various search parameters. You can also print sent notices, individually or in a batch. This enhancement uses a new system preference NoticesManagement and a new view_generated_notices user permission. This enhancement has been built on top of Bug 33478 so print format settings are taken into account when printing notices. To test: 1. Apply patches, install database updates, restart services 2. Make sure your logged in user has the view_generated_notices permission checked 3. Enable the NoticesManagement system preference 4. Generate a few notices. There are a few ways to do this including: - place holds, check in items and confirm the holds - place recalls, check in items and confirm the recalls 5. Go to Tools -> Notices management 6. There are two search functions on the left navigation. Confirm the patron search box works by searching for one of the patrons you generated a notice for, you should be redirected to their Notice history. 7. Go back to Notices management. Use the set of search filters to search for notices. Leaving the search filters empty will return all notices generated. Confirm the filters work as expected by using different combinations of filters. 8. Conduct a search so your notices show in a table. Confirm the information fetched about the notices is correct. 9. Click on a notice title. Confirm the contents of the notice show in a pop-up box. 10. Click one of the Print buttons next to a notice. Confirm the notice is opened to be printed. 11. Redo your notices search. Confirm the status of the notice you just printed has now been updated to 'sent'. 12. Use the 'Select all' and 'Clear all' buttons to select or clear the checkboxes. 13. Select a few checkboxes and click the button at the bottom of the table to 'Print selected notices'. Confirm the notices have been collated into one document, separated by horizontal lines, and prints successfully. The statuses for the notices should all be updated to 'sent'. 14. Confirm the Notices management page is not visible without the view_generated_notices permission 15. Confirm the Notices management page is not visible without the NoticesManagement system preference being enabled. 16. Go to a patron's Notices history. If the view_generated_notices user permission is checked for your logged in patron, you should see a Print button for each notice. Confirm this works. Confirm this button doesn't show if your logged in patron does not have the view_generated_notices user permission. It does not require the NoticesManagement system preference. 17. Go to Tools -> Notices & slips 18. Edit the format settings of a few different notices i.e. HOLD and WELCOME 19. Generate these notices by filling a hold for a patron and sending a welcome email 20. Search for all notices under Tools -> Notices management 21. Select all notices and print selected notices 22. Confirm the notices different format settings are taken into account in the printed PDF Sponsored-by: Colorado Library Consortium Signed-off-by: kelly <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162678|0 |1 is obsolete| | --- Comment #56 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 164784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164784&action=edit Bug 33260: Add NoticesManagement system preference Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: kelly <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162680|0 |1 is obsolete| | --- Comment #58 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 164786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164786&action=edit Bug 33260: Add Notice management tool This enhancement makes it easy for the library to view sent notices and filter by various search parameters. You can also print sent notices, individually or in a batch. This enhancement uses a new system preference NoticesManagement and a new view_generated_notices user permission. This enhancement has been built on top of Bug 33478 so print format settings are taken into account when printing notices. To test: 1. Apply patches, install database updates, restart services 2. Make sure your logged in user has the view_generated_notices permission checked 3. Enable the NoticesManagement system preference 4. Generate a few notices. There are a few ways to do this including: - place holds, check in items and confirm the holds - place recalls, check in items and confirm the recalls 5. Go to Tools -> Notices management 6. There are two search functions on the left navigation. Confirm the patron search box works by searching for one of the patrons you generated a notice for, you should be redirected to their Notice history. 7. Go back to Notices management. Use the set of search filters to search for notices. Leaving the search filters empty will return all notices generated. Confirm the filters work as expected by using different combinations of filters. 8. Conduct a search so your notices show in a table. Confirm the information fetched about the notices is correct. 9. Click on a notice title. Confirm the contents of the notice show in a pop-up box. 10. Click one of the Print buttons next to a notice. Confirm the notice is opened to be printed. 11. Redo your notices search. Confirm the status of the notice you just printed has now been updated to 'sent'. 12. Use the 'Select all' and 'Clear all' buttons to select or clear the checkboxes. 13. Select a few checkboxes and click the button at the bottom of the table to 'Print selected notices'. Confirm the notices have been collated into one document, separated by horizontal lines, and prints successfully. The statuses for the notices should all be updated to 'sent'. 14. Confirm the Notices management page is not visible without the view_generated_notices permission 15. Confirm the Notices management page is not visible without the NoticesManagement system preference being enabled. 16. Go to a patron's Notices history. If the view_generated_notices user permission is checked for your logged in patron, you should see a Print button for each notice. Confirm this works. Confirm this button doesn't show if your logged in patron does not have the view_generated_notices user permission. It does not require the NoticesManagement system preference. 17. Go to Tools -> Notices & slips 18. Edit the format settings of a few different notices i.e. HOLD and WELCOME 19. Generate these notices by filling a hold for a patron and sending a welcome email 20. Search for all notices under Tools -> Notices management 21. Select all notices and print selected notices 22. Confirm the notices different format settings are taken into account in the printed PDF Sponsored-by: Colorado Library Consortium Signed-off-by: kelly <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #60 from Lucas Gass <lucas@bywatersolutions.com> --- Needs rebased on top of Bug 36490 now. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164786|0 |1 is obsolete| | --- Comment #61 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 165238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165238&action=edit Bug 33260: Add Notice management tool This enhancement makes it easy for the library to view sent notices and filter by various search parameters. You can also print sent notices, individually or in a batch. This enhancement uses a new system preference NoticesManagement and a new view_generated_notices user permission. This enhancement has been built on top of Bug 33478 so print format settings are taken into account when printing notices. To test: 1. Apply patches, install database updates, restart services 2. Make sure your logged in user has the view_generated_notices permission checked 3. Enable the NoticesManagement system preference 4. Generate a few notices. There are a few ways to do this including: - place holds, check in items and confirm the holds - place recalls, check in items and confirm the recalls 5. Go to Tools -> Notices management 6. There are two search functions on the left navigation. Confirm the patron search box works by searching for one of the patrons you generated a notice for, you should be redirected to their Notice history. 7. Go back to Notices management. Use the set of search filters to search for notices. Leaving the search filters empty will return all notices generated. Confirm the filters work as expected by using different combinations of filters. 8. Conduct a search so your notices show in a table. Confirm the information fetched about the notices is correct. 9. Click on a notice title. Confirm the contents of the notice show in a pop-up box. 10. Click one of the Print buttons next to a notice. Confirm the notice is opened to be printed. 11. Redo your notices search. Confirm the status of the notice you just printed has now been updated to 'sent'. 12. Use the 'Select all' and 'Clear all' buttons to select or clear the checkboxes. 13. Select a few checkboxes and click the button at the bottom of the table to 'Print selected notices'. Confirm the notices have been collated into one document, separated by horizontal lines, and prints successfully. The statuses for the notices should all be updated to 'sent'. 14. Confirm the Notices management page is not visible without the view_generated_notices permission 15. Confirm the Notices management page is not visible without the NoticesManagement system preference being enabled. 16. Go to a patron's Notices history. If the view_generated_notices user permission is checked for your logged in patron, you should see a Print button for each notice. Confirm this works. Confirm this button doesn't show if your logged in patron does not have the view_generated_notices user permission. It does not require the NoticesManagement system preference. 17. Go to Tools -> Notices & slips 18. Edit the format settings of a few different notices i.e. HOLD and WELCOME 19. Generate these notices by filling a hold for a patron and sending a welcome email 20. Search for all notices under Tools -> Notices management 21. Select all notices and print selected notices 22. Confirm the notices different format settings are taken into account in the printed PDF Sponsored-by: Colorado Library Consortium Signed-off-by: kelly <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #63 from David Nind <david@davidnind.com> --- I could not test steps 5-13 (Tools > Notices management) because I get these errors (maybe partially related to Bug 34478 and Bug 36192 - CSRF protection) (other steps all work as expected): 1. Patron search: entering a partial name doesn't come up with the full name and card number to select (for example: start typing mary). Two errors in the console: jQuery.Deferred exception: Cannot set properties of undefined (setting '_renderItem') TypeError: Cannot set properties of undefined (setting '_renderItem') at patron_autocomplete (http://127.0.0.1:8081/intranet-tmpl/prog/js/staff-global_23.1200025.js:574:4...) at HTMLDocument.<anonymous> (http://127.0.0.1:8081/cgi-bin/koha/tools/notices.pl:2803:21) at e (http://127.0.0.1:8081/intranet-tmpl/lib/jquery/jquery-3.6.0.min_23.1200025.j...) at t (http://127.0.0.1:8081/intranet-tmpl/lib/jquery/jquery-3.6.0.min_23.1200025.j...) undefined Uncaught TypeError: Cannot set properties of undefined (setting '_renderItem') at patron_autocomplete (staff-global_23.1200025.js:574:46) at HTMLDocument.<anonymous> (notices.pl:2803:21) at e (jquery-3.6.0.min_23.1200025.js:2:30038) at t (jquery-3.6.0.min_23.1200025.js:2:30340) 2. Browse by last name: selecting any letter displays all patrons ("showing 1 to 20 of 53 entries"). 3. Selecting a patron (after choosing a letter) - nothing displays apart from the patrons search/browse by last name box) (for example: http://127.0.0.1:8081/cgi-bin/koha/tools/notices.pl?&borrowernumber=49) 4. Error when using the search filters. Click 'Search' (no need to change any filter options), error displayed: An error has occurred! Error 403 Programming error - op 'search' must start with 'cud-' for POST http://127.0.0.1:8081/intranet/tools/notices.pl (referer: http://127.0.0.1:8081/cgi-bin/koha/tools/notices.pl?&borrowernumber=49) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #64 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 165717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165717&action=edit Bug 33260: (follow-up) Fix search forms on notices mgmt page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #66 from David Nind <david@davidnind.com> --- (In reply to Aleisha Amohia from comment #65)

(In reply to David Nind from comment #63)

...

I could not test steps 5-13 (Tools > Notices management) because I get these errors (maybe partially related to Bug 34478 and Bug 36192 - CSRF protection) (other steps all work as expected):

Thanks for testing David, I believe I have addressed these errors in the latest follow up.

Thanks Aleisha for updating! The patron search block on the notices management tool page is now working. However, for the search filters on the left, I'm still getting an error when clicking on 'Search': An error has occurred! Error 403 Programming error - op 'search' must start with 'cud-' for POST http://127.0.0.1:8081/intranet/tools/notices.pl (referer: http://127.0.0.1:8081/cgi-bin/koha/tools/notices.pl) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165717|0 |1 is obsolete| | --- Comment #67 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 165939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165939&action=edit Bug 33260: (follow-up) Fix search forms on notices mgmt page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164783|0 |1 is obsolete| | --- Comment #68 from David Nind <david@davidnind.com> --- Created attachment 165946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165946&action=edit Bug 33260: Add view_generated_notices user permission Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: kelly <kelly@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164785|0 |1 is obsolete| | --- Comment #70 from David Nind <david@davidnind.com> --- Created attachment 165948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165948&action=edit Bug 33260: Add a patron getter method to Koha::Notice::Message Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: kelly <kelly@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165239|0 |1 is obsolete| | --- Comment #72 from David Nind <david@davidnind.com> --- Created attachment 165950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165950&action=edit Bug 33260: Move patron search into main body of page This patch moves the patron search in the Notices management page to the main body of the page so that the patron search result table displays more nicely. This is a better place for it anyway, as using this search takes the user to a different page. In the sidebar, where it was previously, it implied it would have the same results display as the search filters. Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: kelly <kelly@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #74 from David Nind <david@davidnind.com> --- Thanks for fixing Aleisha! This looks great, and things worked as set out in the test plan. Some things I noticed and some suggestions (but not showstoppers for me): 1. Background for search results - I think this needs the white background div. 2. Step 13 - each notice was on a separate page, I didn't notice any horizontal lines. 3. Search filters: maybe this should also have a clear button or link beside the search button. 4. Search results display after printing selected notices. If you select multiple notices and click "Print selected notices", after you have saved the PDF and returned to the notices management screen, items are still selected, the print selected notices button is still selected, and the status stays as pending. Once you do another search or refresh the page, things display as expected. Is there a way to refresh the page once the selected notices are printed? Testing notes (using KTD): 1. I added an email address to the patron(s) I generated the notices for. 2. I updated the patron messaging preferences for the patron(s) I generated the notices for (I enabled item check-in and item checkout). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #76 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Still looking here.. must admit I'm a little disappointed to find it all coded in a style we've long since moved away from even though it's a very recent project in the grand scheme. I'm worried about performance.. that table fills up with notice quickly and we're not paging or using API's. Also, we now have non-template driven notices and those cause a spectacular error on attempting to print. It looks like you're generating the notice from scratch at print time rather than using the notice that exists.. that also feels odd.. it could lead to viewing the preview and then printing something entirely different to what you just previewed. Anyway.. I'll come back to this asap once I've dug a little further. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #78 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm a little worried about data privacy here I'm afraid.. I think I would expect to see use of Koha::Patrons->search_limited to limit results to patrons the logged-in user has the right to see. I'd be interested to get some feedback on that from a wider audience -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #81 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Thanks for the comments, I've attached a new patch implementing Koha::Notice::Messages->search_limited. I'm not sure what you mean by non-templated notices - are you able to give me an example of this please? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165947|0 |1 is obsolete| | --- Comment #83 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166336&action=edit Bug 33260: Add NoticesManagement system preference Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: kelly <kelly@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165949|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166338&action=edit Bug 33260: Add Notice management tool This enhancement makes it easy for the library to view sent notices and filter by various search parameters. You can also print sent notices, individually or in a batch. This enhancement uses a new system preference NoticesManagement and a new view_generated_notices user permission. This enhancement has been built on top of Bug 33478 so print format settings are taken into account when printing notices. To test: 1. Apply patches, install database updates, restart services 2. Make sure your logged in user has the view_generated_notices permission checked 3. Enable the NoticesManagement system preference 4. Generate a few notices. There are a few ways to do this including: - place holds, check in items and confirm the holds - place recalls, check in items and confirm the recalls 5. Go to Tools -> Notices management 6. There are two search functions on the left navigation. Confirm the patron search box works by searching for one of the patrons you generated a notice for, you should be redirected to their Notice history. 7. Go back to Notices management. Use the set of search filters to search for notices. Leaving the search filters empty will return all notices generated. Confirm the filters work as expected by using different combinations of filters. 8. Conduct a search so your notices show in a table. Confirm the information fetched about the notices is correct. 9. Click on a notice title. Confirm the contents of the notice show in a pop-up box. 10. Click one of the Print buttons next to a notice. Confirm the notice is opened to be printed. 11. Redo your notices search. Confirm the status of the notice you just printed has now been updated to 'sent'. 12. Use the 'Select all' and 'Clear all' buttons to select or clear the checkboxes. 13. Select a few checkboxes and click the button at the bottom of the table to 'Print selected notices'. Confirm the notices have been collated into one document, separated by horizontal lines, and prints successfully. The statuses for the notices should all be updated to 'sent'. 14. Confirm the Notices management page is not visible without the view_generated_notices permission 15. Confirm the Notices management page is not visible without the NoticesManagement system preference being enabled. 16. Go to a patron's Notices history. If the view_generated_notices user permission is checked for your logged in patron, you should see a Print button for each notice. Confirm this works. Confirm this button doesn't show if your logged in patron does not have the view_generated_notices user permission. It does not require the NoticesManagement system preference. 17. Go to Tools -> Notices & slips 18. Edit the format settings of a few different notices i.e. HOLD and WELCOME 19. Generate these notices by filling a hold for a patron and sending a welcome email 20. Search for all notices under Tools -> Notices management 21. Select all notices and print selected notices 22. Confirm the notices different format settings are taken into account in the printed PDF Sponsored-by: Colorado Library Consortium Signed-off-by: kelly <kelly@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165951|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166340&action=edit Bug 33260: (follow-up) Fix search forms on notices mgmt page Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166178|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166342&action=edit Bug 33260: Use search_limited to protect message privacy, and unit test This patch adds a Koha::Notice::Messages->search_limited sub to allow better control over which patron's notices the user can see. Test added to t/db_dependent/Koha/Notice/Message.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #91 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166344&action=edit Bug 33260: (QA follow-up) Add template relation This patch add the 'template' relation to the Koha::Notice::Message object to fetch the Koha::Notice::Template object that may have been used to generate the notice. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #93 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've added some follow-ups.. 1) Tidy the new unit test for search_limited 2) Add a relation (Still need to add a unit test for this) for 'template' from the Koha::Notice::Message class 3) To safely degrade rather than throw a nasty 500 error to screen when a notice doesn't have a corresponding template (Try the new 'Add message - email' functionality from the patron details page to see the 500) Still a little more to do here and I will continue tomorrow (It's 8pm here already). We need that unit test adding for the new relation I introduce.. but I also want to investigate how the styling works together with a mix of HTML and non-HTML notices.. also interested in seeing how SlipCSS works with this as I'm surprised to now see it using the circ/print-slip template.. I thought that was very much intended for slip printers where as I thought this particular feature was more about printing notices to a Letter/A4 size printer.. especially 'email' notices.. does it also work with other message transport type notices? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34030 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34030 [Bug 34030] Print slips in a batch from the preservation module -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36809 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36809 [Bug 36809] DRY out notice and slip printing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166335|0 |1 is obsolete| | --- Comment #97 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166362&action=edit Bug 33260: Add view_generated_notices user permission Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: kelly <kelly@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166337|0 |1 is obsolete| | --- Comment #99 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166364&action=edit Bug 33260: Add a patron getter method to Koha::Notice::Message Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: kelly <kelly@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166339|0 |1 is obsolete| | --- Comment #101 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166366&action=edit Bug 33260: Move patron search into main body of page This patch moves the patron search in the Notices management page to the main body of the page so that the patron search result table displays more nicely. This is a better place for it anyway, as using this search takes the user to a different page. In the sidebar, where it was previously, it implied it would have the same results display as the search filters. Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: kelly <kelly@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166341|0 |1 is obsolete| | --- Comment #103 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166368&action=edit Bug 33260: (QA follow-up) Correct relation accessor and add unit test We were missing unit tests for the patron relation accessor added to Koha::Notice::Message and once I looked at adding the test I spotted the accessor was also using a rather outdated form. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166343|0 |1 is obsolete| | --- Comment #105 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166370&action=edit Bug 33260: Tidy unit test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166345|0 |1 is obsolete| | --- Comment #107 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166372&action=edit Bug 33260: (QA follow-up) Safely continue for non-templated notices The 'letter_id'/'letter_code' field in the message queue table is a NULLable foreign key as is indeed NULL in certain circustances. We need to gracefully degrade when there isn't a template for the notice in question. Tihs patch uses the newly introduced 'template' accessor and when that returns undefined we pass 'style' as an empty string. We also use the 'is_html' method introduced in bug 35285 to set the html flag. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #109 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've burnt through too much time here already but still don't feel this is quite ready and it's too close to hard feature freeze for this cycle in my opinion. # Notices management page * I don't understand why we start with a patron search up front and centre.. we already have a powerful patron search and replicating that code here seems to detract from the main purpose of the tool which is to display a list of notices filtered by things other than patron. * Once a notice search is performed, I think the table column order should match that from the synonymous page in the patron record. # Patron notices page # Both * Should print really appear for all transport types and message statuses? * Should print really print an email notice using the email template, especially when there might be a print template designed specifically for print? * Should we really be using the 'Slip' printing code rather than 'Notice' printing here? * Should the permissions not reflect that they expose access to printing functionality rather than view functionality? * I'm not sure that calling the print dialog should set the notice to 'sent'.. you can easily cancel before the print actually happens and so the updated status is a misrepresentation. With all those open questions and ongoing work elsewhere to try and clean up the notices and slips code I feel this still needs more work. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Sylvain Def. <s.deflache@ville-caluire.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |s.deflache@ville-caluire.fr --- Comment #110 from Sylvain Def. <s.deflache@ville-caluire.fr> --- CONFLICT (content): Merge conflict in t/db_dependent/Letters.t error: Failed to merge in the changes. Patch failed at 0001 Bug 33260: Add a patron getter method to Koha::Notice::Message -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166363|0 |1 is obsolete| | --- Comment #112 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 167910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167910&action=edit Bug 33260: Add NoticesManagement system preference Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: kelly <kelly@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166365|0 |1 is obsolete| | --- Comment #114 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 167912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167912&action=edit Bug 33260: Add Notice management tool This enhancement makes it easy for the library to view sent notices and filter by various search parameters. You can also print sent notices, individually or in a batch. This enhancement uses a new system preference NoticesManagement and a new view_generated_notices user permission. This enhancement has been built on top of Bug 33478 so print format settings are taken into account when printing notices. To test: 1. Apply patches, install database updates, restart services 2. Make sure your logged in user has the view_generated_notices permission checked 3. Enable the NoticesManagement system preference 4. Generate a few notices. There are a few ways to do this including: - place holds, check in items and confirm the holds - place recalls, check in items and confirm the recalls 5. Go to Tools -> Notices management 6. There are two search functions on the left navigation. Confirm the patron search box works by searching for one of the patrons you generated a notice for, you should be redirected to their Notice history. 7. Go back to Notices management. Use the set of search filters to search for notices. Leaving the search filters empty will return all notices generated. Confirm the filters work as expected by using different combinations of filters. 8. Conduct a search so your notices show in a table. Confirm the information fetched about the notices is correct. 9. Click on a notice title. Confirm the contents of the notice show in a pop-up box. 10. Click one of the Print buttons next to a notice. Confirm the notice is opened to be printed. 11. Redo your notices search. Confirm the status of the notice you just printed has now been updated to 'sent'. 12. Use the 'Select all' and 'Clear all' buttons to select or clear the checkboxes. 13. Select a few checkboxes and click the button at the bottom of the table to 'Print selected notices'. Confirm the notices have been collated into one document, separated by horizontal lines, and prints successfully. The statuses for the notices should all be updated to 'sent'. 14. Confirm the Notices management page is not visible without the view_generated_notices permission 15. Confirm the Notices management page is not visible without the NoticesManagement system preference being enabled. 16. Go to a patron's Notices history. If the view_generated_notices user permission is checked for your logged in patron, you should see a Print button for each notice. Confirm this works. Confirm this button doesn't show if your logged in patron does not have the view_generated_notices user permission. It does not require the NoticesManagement system preference. 17. Go to Tools -> Notices & slips 18. Edit the format settings of a few different notices i.e. HOLD and WELCOME 19. Generate these notices by filling a hold for a patron and sending a welcome email 20. Search for all notices under Tools -> Notices management 21. Select all notices and print selected notices 22. Confirm the notices different format settings are taken into account in the printed PDF Sponsored-by: Colorado Library Consortium Signed-off-by: kelly <kelly@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166367|0 |1 is obsolete| | --- Comment #116 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 167914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167914&action=edit Bug 33260: (follow-up) Fix search forms on notices mgmt page Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166369|0 |1 is obsolete| | --- Comment #118 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 167916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167916&action=edit Bug 33260: Use search_limited to protect message privacy, and unit test This patch adds a Koha::Notice::Messages->search_limited sub to allow better control over which patron's notices the user can see. Test added to t/db_dependent/Koha/Notice/Message.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166371|0 |1 is obsolete| | --- Comment #120 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 167918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167918&action=edit Bug 33260: (QA follow-up) Add template relation This patch add the 'template' relation to the Koha::Notice::Message object to fetch the Koha::Notice::Template object that may have been used to generate the notice. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166373|0 |1 is obsolete| | --- Comment #122 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 167920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167920&action=edit Bug 33260: (QA follow-up) Add missing page-section Add the missing page-section div to the new page and include required messages.inc include as is now standard. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Bug 33260 depends on bug 33478, which changed state. Bug 33478 Summary: Customise the format of notices when they are printed https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #124 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172248&action=edit Bug 33260: (follow-up) Remove patron search as primary action This is a 'Notices' display tool, it doesn't make sense to me to replicate the 'Patrons' search interface as the primary action of the tool. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #126 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Still working here.. I'm thinking the individual print may be more consistent to just have available from the modal display as we do in a few other places and that, to me, makes it clearer we're printing whats displayed as apposed to using the print notice (I'd love to see a 'convert to print' at a later date to handle adding address details etc to such notices) I need to work out why resend isn't working as expected.. I think that's a regression that predates this patchset somewhere however. We're much closer again now. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167909|0 |1 is obsolete| | --- Comment #128 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172308&action=edit Bug 33260: Add view_generated_notices user permission Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: kelly <kelly@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167911|0 |1 is obsolete| | --- Comment #130 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172310&action=edit Bug 33260: Add a patron getter method to Koha::Notice::Message Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: kelly <kelly@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167913|0 |1 is obsolete| | --- Comment #132 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172312&action=edit Bug 33260: Move patron search into main body of page This patch moves the patron search in the Notices management page to the main body of the page so that the patron search result table displays more nicely. This is a better place for it anyway, as using this search takes the user to a different page. In the sidebar, where it was previously, it implied it would have the same results display as the search filters. Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: kelly <kelly@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167915|0 |1 is obsolete| | --- Comment #134 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172314&action=edit Bug 33260: (QA follow-up) Correct relation accessor and add unit test We were missing unit tests for the patron relation accessor added to Koha::Notice::Message and once I looked at adding the test I spotted the accessor was also using a rather outdated form. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167917|0 |1 is obsolete| | --- Comment #136 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172316&action=edit Bug 33260: Tidy unit test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167919|0 |1 is obsolete| | --- Comment #138 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172318&action=edit Bug 33260: (QA follow-up) Safely continue for non-templated notices The 'letter_id'/'letter_code' field in the message queue table is a NULLable foreign key as is indeed NULL in certain circustances. We need to gracefully degrade when there isn't a template for the notice in question. Tihs patch uses the newly introduced 'template' accessor and when that returns undefined we pass 'style' as an empty string. We also use the 'is_html' method introduced in bug 35285 to set the html flag. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172247|0 |1 is obsolete| | --- Comment #140 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172320&action=edit Bug 33260: (follow-up) Rebase for bootstrap 5 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172307|0 |1 is obsolete| | --- Comment #142 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172322&action=edit Bug 33260: (follow-up) Sync functionality and ordering of display This patch syncs up the functionality and order of the notice displays. We allow for resending of notices via the modal in the new tools page and we add print in bulk to the members notices page. We also fix the modal on the tools page to work with bootstrap 5 correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #144 from AspenCat Team <aspencatteam@clicweb.org> --- The idea of marking things sent was to have a way to distinguish what had been printed and what had not. So duplicate notices are not printed and delivered. If there is a better way of noting that printing has taken place, that doesn't mislead as "sent" that would cover the functionality that is needed. - Bob -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #145 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Thanks Martin, Nick and Bob! If I can be of any help let me know. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #147 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Thanks for the replies everyone. I'm sold in the marking as sent, that makes sense, especially when a notice is coming from 'pending' and is a 'print' type notice in the first place. The query comes from those notices that appear in these two pages that are already in another state and especially those that are not 'print' type. Makeing them sent when they were pending will prevent emails from going out for example.. though I suppose it does make sense if they're in a failure state and you want to use print as a fallback. Anyway, I'm happy to accept 'sent' for all. I do have another couple of questions however. In the bulk select and print process, each notice is printed without any additional spacing between, all on one page one after the other. Should we not add page breaks between notices so you have a notice per page (gather_print_notices appears to have lost this page breaking functionality somewhere along the line :( ) Do we also need to consider including headers here with address details etc. For print type notices we usually include physical address details right in the notice, but when printing an email type notice you currently won't get any addressee detail.. for a bulk print this would get confusing quickly I think. (This could be done in a follow-up bug perhaps.. or we could limit to print type notices for the print functionality at first?) The thing I'm finding hard to fully understand here is the mix of notice transport types all in this one print option. If the transport type was 'print' it makes a fair bit of sense because you usually have address details as part of the notice itself.. if it was an email then you won't get any addressee details at all in most notices with this print option. I can see it being nice to individually print a copy of an email notice upon request or when email has failed. Again, adding this header support could perhaps be a follow-up bug a this stage. Finally, I've been trying to dry out our printing code, but this itbeoduces yet another printslip controller that's almost a copy paste of the 6+ existing scripts.. why not use members/printnotice.pl which I was trying to keep as a simple single place for printing slips so we stop adding new functionality and then forgetting to replicated I. The 6+ clones of code? I'll look at doing that here to save me the job of later removing that scriot again. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172308|0 |1 is obsolete| | --- Comment #149 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172342&action=edit Bug 33260: Add view_generated_notices user permission Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: kelly <kelly@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172310|0 |1 is obsolete| | --- Comment #151 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172344&action=edit Bug 33260: Add a patron getter method to Koha::Notice::Message Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: kelly <kelly@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172312|0 |1 is obsolete| | --- Comment #153 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172346&action=edit Bug 33260: Move patron search into main body of page This patch moves the patron search in the Notices management page to the main body of the page so that the patron search result table displays more nicely. This is a better place for it anyway, as using this search takes the user to a different page. In the sidebar, where it was previously, it implied it would have the same results display as the search filters. Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: kelly <kelly@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172314|0 |1 is obsolete| | --- Comment #155 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172348&action=edit Bug 33260: (QA follow-up) Correct relation accessor and add unit test We were missing unit tests for the patron relation accessor added to Koha::Notice::Message and once I looked at adding the test I spotted the accessor was also using a rather outdated form. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172316|0 |1 is obsolete| | --- Comment #157 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172350&action=edit Bug 33260: Tidy unit test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172318|0 |1 is obsolete| | --- Comment #159 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172352&action=edit Bug 33260: (QA follow-up) Safely continue for non-templated notices The 'letter_id'/'letter_code' field in the message queue table is a NULLable foreign key as is indeed NULL in certain circustances. We need to gracefully degrade when there isn't a template for the notice in question. Tihs patch uses the newly introduced 'template' accessor and when that returns undefined we pass 'style' as an empty string. We also use the 'is_html' method introduced in bug 35285 to set the html flag. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172320|0 |1 is obsolete| | --- Comment #161 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172354&action=edit Bug 33260: (follow-up) Rebase for bootstrap 5 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172322|0 |1 is obsolete| | --- Comment #163 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172356&action=edit Bug 33260: (follow-up) Sync functionality and ordering of display This patch syncs up the functionality and order of the notice displays. We allow for resending of notices via the modal in the new tools page and we add print in bulk to the members notices page. We also fix the modal on the tools page to work with bootstrap 5 correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #165 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172358&action=edit Bug 33260: (follow-up) Limit printing to non-pending on members page This patch prevent printing of notices in the 'pending' state. This ensures that email notices will not be skipped by process message queue at it's next run as we set the 'sent' status on print with this patchset. It still allows for printing of sent and failed messages which I believe is the purpose of the original patchset. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38072 CC| |martin.renvoize@ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38072 [Bug 38072] Regression with modalPrint -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia@bywatersolutions.com --- Comment #167 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- *** Bug 7638 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #168 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172379&action=edit Bug 33260: (follow-up) Correct call to 'style' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|38078 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38078 [Bug 38078] Merge /batch/printnotice.tt and /members/print_notice.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Status|Signed Off |Failed QA --- Comment #169 from Jonathan Druart <jonathan.druart@gmail.com> --- Very quick code review and testing: 1. Koha::Notice::Message->patron + return unless $patron_rs; This is not tested 2. Koha::Notice::Message->template + return unless $template_rs; Same 3. QA script failures FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt FAIL tt_valid lines 75 FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/notices.tt FAIL spelling noice ==> noise, nice, notice 4. <th class="nosort"> </th> + "aoColumnDefs": [ + { 'bSortable': false, 'aTargets': [ 'nosort' ] } + ], You should use .NoSort on the th and don't need the aoColumnDefs. 5. members/notices.pl?borrowernumber=5 Without entry we should not show the table but "There are no notices for this patron" instead. 6. "Pending" notices have their checkbox disabled, we should display a onmouseover tooltip. 7. if you print a notice that was "failed", it's then "sent" but the "delivery note" failure is still displayed on the template. Does it make sense? 8. Is it expected to print using "email" mtt, shouldn't we use the "print" template instead? 9. 2 different outputs: * Using "Print" from the actions column http://localhost:8081/cgi-bin/koha/tools/print_notice.pl?message_ids=73 Using CHECKIN, all on one line "The following items have been checked out: E Street shuffle Thank you for visiting Centerville." * Using "Print" from the modal http://localhost:8081/cgi-bin/koha/members/notices.pl?borrowernumber=5 "Checkouts The following items have been checked out: E Street shuffle Thank you for visiting Centerville." Also the name of the pdf in the second example is "notices.pl.pdf" 10. "Resend" - Shouldn't we actually enqueue another message in order to keep track of what have been failed/sent? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172343|0 |1 is obsolete| | --- Comment #171 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175502&action=edit Bug 33260: Add NoticesManagement system preference Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: kelly <kelly@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172345|0 |1 is obsolete| | --- Comment #173 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175504&action=edit Bug 33260: Add Notice management tool This enhancement makes it easy for the library to view sent notices and filter by various search parameters. You can also print sent notices, individually or in a batch. This enhancement uses a new system preference NoticesManagement and a new view_generated_notices user permission. This enhancement has been built on top of Bug 33478 so print format settings are taken into account when printing notices. To test: 1. Apply patches, install database updates, restart services 2. Make sure your logged in user has the view_generated_notices permission checked 3. Enable the NoticesManagement system preference 4. Generate a few notices. There are a few ways to do this including: - place holds, check in items and confirm the holds - place recalls, check in items and confirm the recalls 5. Go to Tools -> Notices management 6. There are two search functions on the left navigation. Confirm the patron search box works by searching for one of the patrons you generated a notice for, you should be redirected to their Notice history. 7. Go back to Notices management. Use the set of search filters to search for notices. Leaving the search filters empty will return all notices generated. Confirm the filters work as expected by using different combinations of filters. 8. Conduct a search so your notices show in a table. Confirm the information fetched about the notices is correct. 9. Click on a notice title. Confirm the contents of the notice show in a pop-up box. 10. Click one of the Print buttons next to a notice. Confirm the notice is opened to be printed. 11. Redo your notices search. Confirm the status of the notice you just printed has now been updated to 'sent'. 12. Use the 'Select all' and 'Clear all' buttons to select or clear the checkboxes. 13. Select a few checkboxes and click the button at the bottom of the table to 'Print selected notices'. Confirm the notices have been collated into one document, separated by horizontal lines, and prints successfully. The statuses for the notices should all be updated to 'sent'. 14. Confirm the Notices management page is not visible without the view_generated_notices permission 15. Confirm the Notices management page is not visible without the NoticesManagement system preference being enabled. 16. Go to a patron's Notices history. If the view_generated_notices user permission is checked for your logged in patron, you should see a Print button for each notice. Confirm this works. Confirm this button doesn't show if your logged in patron does not have the view_generated_notices user permission. It does not require the NoticesManagement system preference. 17. Go to Tools -> Notices & slips 18. Edit the format settings of a few different notices i.e. HOLD and WELCOME 19. Generate these notices by filling a hold for a patron and sending a welcome email 20. Search for all notices under Tools -> Notices management 21. Select all notices and print selected notices 22. Confirm the notices different format settings are taken into account in the printed PDF Sponsored-by: Colorado Library Consortium Signed-off-by: kelly <kelly@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172347|0 |1 is obsolete| | --- Comment #175 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175506&action=edit Bug 33260: (follow-up) Fix search forms on notices mgmt page Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172349|0 |1 is obsolete| | --- Comment #177 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175508&action=edit Bug 33260: Use search_limited to protect message privacy, and unit test This patch adds a Koha::Notice::Messages->search_limited sub to allow better control over which patron's notices the user can see. Test added to t/db_dependent/Koha/Notice/Message.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.