https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27928 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 118120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118120&action=edit Bug 27928: FindDuplicate shuold use simple_search_compat This patch switches from calling SimpleSearch directly to using the compat method so that Elastic is used when it is the chosen search engine To test: 1 - Set SearchEngine syspref to 'Zebra' 2 - Add a suggestion with an existing title, e.g.: 'E street shuffle' 3 - Confirm you get a duplication warning 4 - Change SearchEngine to ES 5 - Repeat get same warning 6 - sudo koha-zebra --stop 'ps aux | grep zebra' to confirm they are stoped 'sudo pkill -9 zebra' if they arent; 7 - Repeat suggestion - no duplication warning (because zebra returns nothing) 8 - Delete the suggestion 9 - Apply patches 10 - Restart all the things, stop zebra 11 - Repeat suggestion 12 - Successful warning from ES 13 - prove -v t/db_dependent/Search.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27928 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27928 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118120|0 |1 is obsolete| | --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 118577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118577&action=edit Bug 27928: FindDuplicate shuold use simple_search_compat This patch switches from calling SimpleSearch directly to using the compat method so that Elastic is used when it is the chosen search engine To test: 1 - Set SearchEngine syspref to 'Zebra' 2 - Add a suggestion with an existing title, e.g.: 'E street shuffle' 3 - Confirm you get a duplication warning 4 - Change SearchEngine to ES 5 - Repeat get same warning 6 - sudo koha-zebra --stop 'ps aux | grep zebra' to confirm they are stoped 'sudo pkill -9 zebra' if they arent; 7 - Repeat suggestion - no duplication warning (because zebra returns nothing) 8 - Delete the suggestion 9 - Apply patches 10 - Restart all the things, stop zebra 11 - Repeat suggestion 12 - Successful warning from ES 13 - prove -v t/db_dependent/Search.t Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27928 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118577|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118816&action=edit Bug 27928: FindDuplicate shuold use simple_search_compat This patch switches from calling SimpleSearch directly to using the compat method so that Elastic is used when it is the chosen search engine To test: 1 - Set SearchEngine syspref to 'Zebra' 2 - Add a suggestion with an existing title, e.g.: 'E street shuffle' 3 - Confirm you get a duplication warning 4 - Change SearchEngine to ES 5 - Repeat get same warning 6 - sudo koha-zebra --stop 'ps aux | grep zebra' to confirm they are stoped 'sudo pkill -9 zebra' if they arent; 7 - Repeat suggestion - no duplication warning (because zebra returns nothing) 8 - Delete the suggestion 9 - Apply patches 10 - Restart all the things, stop zebra 11 - Repeat suggestion 12 - Successful warning from ES 13 - prove -v t/db_dependent/Search.t Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27928 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27928 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27928 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24562 -- You are receiving this mail because: You are watching all bug changes.