https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 126373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126373&action=edit Bug 29255: Built-in offline circulation broken with SQL error This patch makes a minor correction to one of the queries used when synchronizing transactions in the built-in offline circulation system. This fixes the error: DBD::mysql::st execute failed: Column 'branchcode' in field list is ambiguous at /kohadevbox/koha/offline_circ/download.pl line 84 To test you must be using a browser which still supports applicationCache (Firefox before version 81, Chrome before version 94). - Apply the patch and restart services. - Enable the AllowOfflineCirculation system preference. - Go to Circulation -> Built-in offline circulation interface. - Click "Synchronize." - Click the "Download records" button. - After the page refreshes you should see updated dates where it lists "last synced" information. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- It wasn't until I tested this in a new instance of KTD that this ALSO suffers from SQL errors if SQL strict mode is on, so please test with strict mode off. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- The strict mode problem is now described in Bug 29371. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126373|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127179&action=edit Bug 29255: Built-in offline circulation broken with SQL error This patch makes a minor correction to one of the queries used when synchronizing transactions in the built-in offline circulation system. This fixes the error: DBD::mysql::st execute failed: Column 'branchcode' in field list is ambiguous at /kohadevbox/koha/offline_circ/download.pl line 84 To test you must be using a browser which still supports applicationCache (Firefox before version 81, Chrome before version 94). - Apply the patch and restart services. - Enable the AllowOfflineCirculation system preference. - Go to Circulation -> Built-in offline circulation interface. - Click "Synchronize." - Click the "Download records" button. - After the page refreshes you should see updated dates where it lists "last synced" information. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi QA Contact|testopia@bugs.koha-communit |joonas.kylmala@iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Version(s)|21.11.00,21.05.05,20.11.12 |21.11.00,21.05.05,20.11.12, released in| |20.05.18 --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 20.05.x branch for 20.05.18 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #10 from wainuiwitikapark@catalyst.net.nz --- Not backporting to 19.11.x - LTS version will just backport security patches -- You are receiving this mail because: You are watching all bug changes.