[Bug 17418] New: Move staff client home page JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Bug ID: 17418 Summary: Move staff client home page JavaScript to the footer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org This patch will do two things: 1. Update the header and footer include files in order to be able to manage JavaScript either in the header or the footer. 2. Modify the staff client home page as a proof of concept, moving global and in-page JavaScript assets to the footer. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 56115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56115&action=edit Bug 17418 - Move staff client home page JavaScript to the footer This patch alters the header and footer include files so that JavaScript can be included in either one or the other. As a proof of concept, the staff client home page is updated to include JS in the footer instead of the header. The processing of JavaScript included on individual pages can now be similar to how it is done in the OPAC. A block is created with the page's JavaScript which is then processed in js_includes.inc in the correct order, after other required js assets. On pages which have been modified to allow JavaScript to be moved to the footer you must add a variable to the template: [% SET footerjs = 1 %]. Eventually all staff client templates should be modified so that setting a flag is not required. "[% MACRO jsinclude BLOCK %]" is used instead of "[% BLOCK %]" and "[% PROCESS %]" because MACRO allows the template directives to be processed correctly when included by intranet-bottom.inc. To test, apply the patch and view the staff client home page. - Confirm that you get a confirmation when deleting a news item from the home page. - Enable the CircAutocompl system preference and test that patron autocomplete works from the "Check out" tab from the staff home page and from other pages where the "Check out" tab is present. - Test that JavaScript is working correctly on other pages like Circulation, Preferences, etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17416 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416 [Bug 17416] Move javascript in doc-head-close.inc into a separate include -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56115|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 56164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56164&action=edit Bug 17418 - Move staff client home page JavaScript to the footer This patch alters the header and footer include files so that JavaScript can be included in either one or the other. As a proof of concept, the staff client home page is updated to include JS in the footer instead of the header. The processing of JavaScript included on individual pages can now be similar to how it is done in the OPAC. A block is created with the page's JavaScript which is then processed in js_includes.inc in the correct order, after other required js assets. On pages which have been modified to allow JavaScript to be moved to the footer you must add a variable to the template: [% SET footerjs = 1 %]. Eventually all staff client templates should be modified so that setting a flag is not required. "[% MACRO jsinclude BLOCK %]" is used instead of "[% BLOCK %]" and "[% PROCESS %]" because MACRO allows the template directives to be processed correctly when included by intranet-bottom.inc. To test, apply the patch and view the staff client home page. - Confirm that you get a confirmation when deleting a news item from the home page. - Enable the CircAutocompl system preference and test that patron autocomplete works from the "Check out" tab from the staff home page and from other pages where the "Check out" tab is present. - Test that JavaScript is working correctly on other pages like Circulation, Preferences, etc. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56164|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57723&action=edit Bug 17418 - Move staff client home page JavaScript to the footer This patch alters the header and footer include files so that JavaScript can be included in either one or the other. As a proof of concept, the staff client home page is updated to include JS in the footer instead of the header. The processing of JavaScript included on individual pages can now be similar to how it is done in the OPAC. A block is created with the page's JavaScript which is then processed in js_includes.inc in the correct order, after other required js assets. On pages which have been modified to allow JavaScript to be moved to the footer you must add a variable to the template: [% SET footerjs = 1 %]. Eventually all staff client templates should be modified so that setting a flag is not required. "[% MACRO jsinclude BLOCK %]" is used instead of "[% BLOCK %]" and "[% PROCESS %]" because MACRO allows the template directives to be processed correctly when included by intranet-bottom.inc. To test, apply the patch and view the staff client home page. - Confirm that you get a confirmation when deleting a news item from the home page. - Enable the CircAutocompl system preference and test that patron autocomplete works from the "Check out" tab from the staff home page and from other pages where the "Check out" tab is present. - Test that JavaScript is working correctly on other pages like Circulation, Preferences, etc. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Bug 17418 depends on bug 17416, which changed state. Bug 17416 Summary: Move javascript in doc-head-close.inc into a separate include https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get backported to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17790 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |bouzid.fergani@inlibro.com Resolution|FIXED |--- --- Comment #6 from Bouzid <bouzid.fergani@inlibro.com> --- BREAK CATALOGUING MODULE - Koha home - Cataloguing - New record - Number 1 to 9 is not show correctly. error javascript : TypeError: $(...).autocomplete(...).data(...) is undefined -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Bouzid from comment #6)
BREAK CATALOGUING MODULE - Koha home - Cataloguing - New record - Number 1 to 9 is not show correctly. error javascript : TypeError: $(...).autocomplete(...).data(...) is undefined
Must be fixed bug 17790, otherwise open a new bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17858 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17859 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 [Bug 17859] Move JavaScript to the footer on about and auth pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17870 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 [Bug 17870] Call to include file incorrectly moved into the footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17893 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 [Bug 17893] Move JavaScript to the footer on staff client catalog pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19041 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19041 [Bug 19041] footerjs = 1 removed by bug 17855 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17893 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 [Bug 17893] Move JavaScript to the footer on staff client catalog pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17859 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 [Bug 17859] Move JavaScript to the footer on about and auth pages -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org