https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25038 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |14862 Assignee|oleonard@myacpl.org |jonathan.druart@bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Certainly caused by commit 8b1fb387acee35ba64f61d59fd332a79d5759e06 Bug 14862: Upgrade jQuery from 1.7 to 3.4.1 in OPAC Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14862 [Bug 14862] Upgrade jQuery from 1.7 to 3.4.1 in OPAC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25038 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102508&action=edit Bug 25038: Fix tabs on the OPAC reading history view OPAC reading history table has three tabs for different checkout types: All, Checkouts, On-site checkouts. However, all of your checkouts are visible every tab regardless of checkout type. Test plan: 1. Enable OnSiteCheckouts system preference 2. Perform two checkouts: one normal checkout, one on-site checkout 3. Go to OPAC /cgi-bin/koha/opac-readingrecord.pl 4. Observe your checkouts all are visible in first tab 5. Select second tab and notice that the table is now filtered 6. Same with third tab -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25038 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102508|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 102509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102509&action=edit Bug 25038: Fix tabs on the OPAC reading history view OPAC reading history table has three tabs for different checkout types: All, Checkouts, On-site checkouts. However, all of your checkouts are visible every tab regardless of checkout type. Test plan: 1. Enable OnSiteCheckouts system preference 2. Perform two checkouts: one normal checkout, one on-site checkout 3. Go to OPAC /cgi-bin/koha/opac-readingrecord.pl 4. Observe your checkouts all are visible in first tab 5. Select second tab and notice that the table is now filtered 6. Same with third tab Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25038 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102509|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 102693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102693&action=edit Bug 25038: Fix tabs on the OPAC reading history view OPAC reading history table has three tabs for different checkout types: All, Checkouts, On-site checkouts. However, all of your checkouts are visible every tab regardless of checkout type. Test plan: 1. Enable OnSiteCheckouts system preference 2. Perform two checkouts: one normal checkout, one on-site checkout 3. Go to OPAC /cgi-bin/koha/opac-readingrecord.pl 4. Observe your checkouts all are visible in first tab 5. Select second tab and notice that the table is now filtered 6. Same with third tab Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25038 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102693|0 |1 is obsolete| | --- Comment #6 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102770&action=edit Bug 25038: Fix tabs on the OPAC reading history view OPAC reading history table has three tabs for different checkout types: All, Checkouts, On-site checkouts. However, all of your checkouts are visible every tab regardless of checkout type. Test plan: 1. Enable OnSiteCheckouts system preference 2. Perform two checkouts: one normal checkout, one on-site checkout 3. Go to OPAC /cgi-bin/koha/opac-readingrecord.pl 4. Observe your checkouts all are visible in first tab 5. Select second tab and notice that the table is now filtered 6. Same with third tab Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25038 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25038 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependencies for 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.