[Bug 30549] New: Replace the use of jQueryUI Accordion on pending patron updates page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549 Bug ID: 30549 Summary: Replace the use of jQueryUI Accordion on pending patron updates page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 30494 Blocks: 29224 As part of Bug 29224, "OMNIBUS: Replace the use of jQueryUI Accordion" we should replace the use of the jQueryUI accordion component on the pending patron updates page with Bootstrap's Collapse component. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29224 [Bug 29224] OMNIBUS: Replace the use of jQueryUI Accordion https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30494 [Bug 30494] Replace the use of jQueryUI Accordion on the table settings page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 133332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133332&action=edit Bug 30549: Replace the use of jQueryUI Accordion on pending patron updates page This patch updates the pending patron updates page to use Bootstrap collapse instead of jQueryUI. This patch contains whitespace changes, so view the diff with this in mind. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - If necessary, log into the OPAC and submit an update via the "Your personal details" page. Ideally do this for two or more patrons. - In the staff client, follow the "Patrons requesting modifications" link. - On the "Update patron records" page you should see the headings representing each of the patrons with pending updates. The first panel should be expanded. - Confirm that the panels expand and collapse correctly. - Follow the "Patron details" link for one of these patrons. - Click the "Review pending modifications" link on the patron detail page. - When the update page opens that patron's panel should be expanded. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133332|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 133412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133412&action=edit Bug 30549: Replace the use of jQueryUI Accordion on pending patron updates page This patch updates the pending patron updates page to use Bootstrap collapse instead of jQueryUI. This patch contains whitespace changes, so view the diff with this in mind. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - If necessary, log into the OPAC and submit an update via the "Your personal details" page. Ideally do this for two or more patrons. - In the staff client, follow the "Patrons requesting modifications" link. - On the "Update patron records" page you should see the headings representing each of the patrons with pending updates. The first panel should be expanded. - Confirm that the panels expand and collapse correctly. - Follow the "Patron details" link for one of these patrons. - Click the "Review pending modifications" link on the patron detail page. - When the update page opens that patron's panel should be expanded. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |lisetteslatah@gmail.com --- Comment #3 from Lisette Scheer <lisetteslatah@gmail.com> --- Worked as expected. Lisette -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133412|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 133472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133472&action=edit Bug 30549: Replace the use of jQueryUI Accordion on pending patron updates page This patch updates the pending patron updates page to use Bootstrap collapse instead of jQueryUI. This patch contains whitespace changes, so view the diff with this in mind. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - If necessary, log into the OPAC and submit an update via the "Your personal details" page. Ideally do this for two or more patrons. - In the staff client, follow the "Patrons requesting modifications" link. - On the "Update patron records" page you should see the headings representing each of the patrons with pending updates. The first panel should be expanded. - Confirm that the panels expand and collapse correctly. - Follow the "Patron details" link for one of these patrons. - Click the "Review pending modifications" link on the patron detail page. - When the update page opens that patron's panel should be expanded. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Keywords| |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549 Bug 30549 depends on bug 30494, which changed state. Bug 30494 Summary: Replace the use of jQueryUI Accordion on the table settings page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30494 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30549 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org